Re: Disable by default KRandR in 4.11

On Thursday 04 July 2013 01:06:27 Àlex Fiestas wrote: > Hi there > > I want to propose to disable by default KRandR from kde-workspace release > for 4.11. +1 > Ideally I would like to remove the source code completely, but I guess we > are too late into 4.11 to do such thing. why not? You could re

Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

> On July 4, 2013, 5:35 a.m., Luca Beltrame wrote: > > Ship It! Please put this modification also in kdelibs master branch (in fact, put it in master so it'll get merged in next time dfaure merges master into frameworks). - Luca --- Th

Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/#review35551 --- Ship it! Ship It! - Luca Beltrame On July 2, 2013, 6:58 p.m

Re: Disable by default KRandR in 4.11

On Thu, Jul 4, 2013 at 11:06 AM, Àlex Fiestas wrote: > Hi there > > I want to propose to disable by default KRandR from kde-workspace release > for 4.11. > > While I'm considered the maintainer of KRandR truth is I have never been it, > I just made it "work" around 4.7 times but it is still full o

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

On Tuesday, June 25, 2013 10:10:03 Aurélien Gâteau wrote: > > Why would the code be specific to kiosk? - You asked for an example, not > > justification. > > I asked for an example, you provided one about kiosk, I answer how your > kiosk example is actually painful. As someone who has done deploy

Re: Disable by default KRandR in 4.11

On Thursday, July 4, 2013 01:06:27 Àlex Fiestas wrote: > Since we have KScreen (which tomorrow I will propose for Extragear) which > almost all distributions are shipping I see no point on keeping KRandR > around, specially in 4.11 that will be the last release of 4.11. The only thing missing (tho

Moving KScreen and libkscreen to extragear

I would like to request a review so we can move KScreen and libkscreen to extragear/base. KScreen is a new manager for outputs such: monitors, projectors, embedded screens... It contains: -KDED Module which does some magic by auto configuring the screens, and saving configurations whenever th

Disable by default KRandR in 4.11

Hi there I want to propose to disable by default KRandR from kde-workspace release for 4.11. While I'm considered the maintainer of KRandR truth is I have never been it, I just made it "work" around 4.7 times but it is still full of bugs and annoyances. Since we have KScreen (which tomorrow I wil

Re: KF5 Update Meeting Minutes 2013-w27

On Tuesday 02 July 2013, Alexander Neundorf wrote: > On Tuesday 02 July 2013, Kevin Ottens wrote: > > Hello everyone, > > > > This is the minutes of the Week 27 KF5 meeting. As usual it has been held > > on #kde-devel at 4pm Paris time. > > > > Were present: apol, ben2367, dfaure, R_Rios, sandsma

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35523 --- Ship it! Congratulations :P - Andreas Hartmetz On July 3, 2

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/ --- (Updated July 3, 2013, 3:53 p.m.) Review request for kde-workspace and Kai

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/#review35522 --- This review has been submitted with commit 736d5237f822fc72736

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/ --- (Updated July 3, 2013, 2:59 p.m.) Status -- This change has been mark

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/#review35521 --- Ship it! I tested the patch with the filename from the bug rep

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

> On July 3, 2013, 2:20 p.m., Christoph Feck wrote: > > Is the + 1 really required? It does not hurt to be extra safe, though. No, it's a leftover from the QT code, probably it was there for BOM. But in the usual case we overshoot the size anyway and truncate at the end, so it doesn't actually

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/#review35519 --- Is the + 1 really required? It does not hurt to be extra safe,

Re: Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/ --- (Updated July 3, 2013, 1:54 p.m.) Review request for kdelibs. Descriptio

Review Request 111379: Fix for kio_file crash on non-utf filenames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/ --- Review request for kdelibs. Description --- Buffersize fix for the pa

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35511 --- plasma/generic/applets/systemtray/ui/widgetitem.cpp

Re: Review Request 111341: Oxygenify KNetattach

> On July 2, 2013, 1:32 a.m., Thomas Lübking wrote: > > Looks like the proper source, but i guess the icon should be rather > > replaced so that any user of knetattach (eg. a local .desktop file) gets > > the updated variant. > > > > Please attach Nuno to the review as the icons are his domain

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/ --- (Updated July 3, 2013, 12:19 p.m.) Review request for kdelibs. Changes -

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/ --- (Updated July 3, 2013, 12:15 p.m.) Status -- This change has been mar

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/#review35509 --- This review has been submitted with commit d27838a49e958c7c22e

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/ --- (Updated July 3, 2013, 11:58 a.m.) Review request for kde-workspace and Ka

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35508 --- plasma/generic/applets/systemtray/ui/widgetitem.cpp

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 3, 2013, 10:48 a.m., Andreas Hartmetz wrote: > > kio/kio/scheduler.cpp, line 660 > > > > > > Just return a QString. With the pointer you have more verbosity in the > > caller, and the state of key is un

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

> On July 2, 2013, 7:48 a.m., David Faure wrote: > > kdecore/services/kservice.h, line 82 > > > > > > How about a setExec() method rather than a special constructor? This > > seems a lot clearer to me (and e.g. ea

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/ --- (Updated July 3, 2013, 10:54 a.m.) Review request for kde-workspace and Ka

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35500 --- plasma/generic/applets/systemtray/ui/widgetitem.cpp

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/#review35497 --- kio/kio/scheduler.cpp

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

> On July 2, 2013, 7:48 a.m., David Faure wrote: > > kdecore/services/kservice.h, line 82 > > > > > > How about a setExec() method rather than a special constructor? This > > seems a lot clearer to me (and e.g. ea

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/#review35490 --- Ship it! - David Faure On July 3, 2013, 2:22 a.m., Dawit Ale

Re: Review Request 111070: Drop internal PostgreSQL cmake module

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111070/ --- (Updated July 3, 2013, 7:21 a.m.) Status -- This change has been mark

Re: Review Request 111070: Drop internal PostgreSQL cmake module

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111070/#review35488 --- This review has been submitted with commit 6fbe7bf1e334c40910b