Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread Xuetian Weng
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-26 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/ --- (Updated Oct. 26, 2013, 5:56 p.m.) Review request for kdelibs. Changes -

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 26, 2013, 1:12 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 26, 2013, 1:04 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review42387 --- CMakeLists.txt