----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review42387 -----------------------------------------------------------
CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30794> we don't need to copy the same statement into endif any more. Makes it way more maintainable :-) CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30795> why did you move kwin around? CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30799> this could go into one if statement kcontrol/CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30796> why another level of indentation. just merge the not win32 and not mac kcontrol/CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30797> empty new line? libs/CMakeLists.txt <http://git.reviewboard.kde.org/r/112991/#comment30798> here I would also just merge the two into one if statement Just as a matter of fact: it will need someone else to give a ship-it for it. I do not feel qualified for it from cmake and multi-platform support side. I would suggest to add Aaron to the reviewers as the workspace module coordinator. - Martin Gräßlin On Oct. 26, 2013, 6:57 a.m., Gilles Caulier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112991/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2013, 6:57 a.m.) > > > Review request for kde-workspace. > > > Bugs: https://trac.macports.org/ticket/33780 > http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 > > > Repository: kde-workspace > > > Description > ------- > > This patch fix broken compilation under OSX / macports about kde-workspace. > > Patch do not touch implementation. Only compilation rules are changed in > cmake script to follow the way way than Windows rules, where no X11 lib are > available. > > By this way, Oxygen is compiled and installed to macport and digiKam has a > suitable GUI under OSX. > > See my Macports bug report for details : > https://trac.macports.org/ticket/33780 > > Gilles Caulier > > > Diffs > ----- > > CMakeLists.txt c37ab8b > kcontrol/CMakeLists.txt a25aaa0 > libs/CMakeLists.txt 9d71a03 > > Diff: http://git.reviewboard.kde.org/r/112991/diff/ > > > Testing > ------- > > I tested this patch under my macbook pro, using a fresh install of Macports > (KDE 4.11.1 / Qt 4.8.5) > > As kde-workspace macports package is broken, i checkout code from KDE > git/master repository and fixed compilation rules as well. > > > File Attachments > ---------------- > > patch to fix compilation rules under OSX with KDE 4.11 branch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/644e987a-967f-44f0-a266-428f4c9b9579__compilerulesOSX-KDE411.patch > > > Thanks, > > Gilles Caulier > >
