Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Michael Zanetti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42503 --- Confirming that this prevents plasma from crashing for me. With

Re: Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.

2013-10-27 Thread Ivan Shapovalov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113360/ --- (Updated Oct. 27, 2013, 10:01 p.m.) Review request for kde-workspace and P

Re: Upcoming changes to CI system

2013-10-27 Thread Ben Cooksley
On Sun, Oct 27, 2013 at 9:43 PM, Peter Grasch wrote: > Hi Ben, > > On 10/27/2013 05:32 PM, Ben Cooksley wrote: > > A shared dependency is essentially a non-KDE project: > > a) Where distribution packages are too old (like CMake) > > b) projects which depend on Qt (and therefore cannot be installe

Re: Upcoming changes to CI system

2013-10-27 Thread Ben Cooksley
On Mon, Oct 28, 2013 at 1:59 AM, Scott Kitterman wrote: > > > Ben Cooksley wrote: > >Hi all, > > > >In order to improve the maintainability and cleanliness of the "shared > >dependencies" the way they will be handled on the CI system will be > >changing. > > > >The nature of this change is that

Re: Upcoming changes to CI system

2013-10-27 Thread Ben Cooksley
On Mon, Oct 28, 2013 at 12:46 AM, Allen Winter wrote: > On Sunday, October 27, 2013 09:32:59 PM Ben Cooksley wrote: > > Hi all, > > > > In order to improve the maintainability and cleanliness of the "shared > > dependencies" the way they will be handled on the CI system will be > > changing. > >

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Kai Uwe Broulik
> On Oct. 27, 2013, 7:09 p.m., Kai Uwe Broulik wrote: > > Note that this needs similar adjustments in Dolphin [kde-baseapps] > > dolphin/src/panels/places/placesitemmodel.cpp then. Belay that, I guess showing "Recent places" in Dolphin isn't that needed. Sorry for the noise. - Kai Uwe

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104222/#review42492 --- Note that this needs similar adjustments in Dolphin [kde-baseap

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104222/ --- (Updated Oct. 27, 2013, 7:07 p.m.) Review request for kdelibs, Andrius da

Re: Review Request 104222: Display recent documents in places bookmark by default

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104222/#review42491 --- kdelibs guys, can anyone review this? - Albert Astals Cid On

Re: Review Request 103808: Report file errors when extracting files using karchive

2013-10-27 Thread Theofilos Intzoglou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103808/ --- (Updated Oct. 27, 2013, 7:03 p.m.) Status -- This change has been dis

Re: Review Request 102391: Don't hang when determining MIME type of corrupted files

2013-10-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102391/ --- (Updated Oct. 27, 2013, 7:02 p.m.) Status -- This change has been mar

Re: Review Request 102231: Pass KAboutData::productName() to DrKonqi

2013-10-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102231/ --- (Updated Oct. 27, 2013, 7 p.m.) Status -- This change has been discar

Re: Review Request 101815: Change the way favicons are stored in bookmarks.xml file

2013-10-27 Thread Filip Brcic
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101815/ --- (Updated Oct. 27, 2013, 6:59 p.m.) Status -- This change has been dis

Re: Review Request 111238: Remove .end() calls from iteration loops in KDirLister

2013-10-27 Thread Albert Astals Cid
> On June 26, 2013, 10:56 a.m., David Faure wrote: > > The change itself looks OK, but all it will do is create a gigantic merge > > conflict for me in frameworks... is that really worth it? > > > > I think it would be better to make such cleanups in frameworks directly. Dawit, David, what sho

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated Oct. 27, 2013, 6:55 p.m.) Status -- This change has been dis

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Mark Gaiser
> On Oct. 27, 2013, 6:50 p.m., Albert Astals Cid wrote: > > Mark, David, what's the status of this? Are you going to work further on > > this or shall it be discarded not to clutter the kdelibs group review list? Yes, there would be "a" speedup by further tweaking this patch. But would it be w

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-10-27 Thread Johannes Obermayr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111042/ --- (Updated Oct. 27, 2013, 6:51 p.m.) Status -- This change has been dis

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review42488 --- Mark, David, what's the status of this? Are you going to work f

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-27 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113219/ --- (Updated Oct. 27, 2013, 6:48 p.m.) Status -- This change has been mar

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113219/#review42486 --- This review has been submitted with commit 6a25d43aba774067b07

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-10-27 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/ --- (Updated Oct. 27, 2013, 6:46 p.m.) Status -- This change has been dis

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-10-27 Thread Albert Astals Cid
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Frederik Gladhorn wrote: > Thanks for asking. On the (frameworks

Re: Review Request 111576:

2013-10-27 Thread Philipp Schmidt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111576/ --- (Updated Oct. 27, 2013, 6:44 p.m.) Status -- This change has been mar

Re: Review Request 111576:

2013-10-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111576/#review42484 --- This review has been submitted with commit 619143f0e71911d44fb

Re: R: Re: kde review kartesio

2013-10-27 Thread Albert Astals Cid
El Diumenge, 27 d'octubre de 2013, a les 18:48:21, LucaTringali va escriure: > Hi Albert, > I'm working on the points but, since I'm kinda busy with my work, the code I > have written for now is still not stable. I think it'll be ready in the > first week of January 2014. > If you study something,

Re: kde review kartesio

2013-10-27 Thread Albert Astals Cid
El Dijous, 9 de maig de 2013, a les 18:06:16, LucaTringali va escriure: > Hello,I have been working on Kartesio, a program for calculating best fit > curves with experimental points. I think it is ready to be moved in the KDE > Edu main repo now, so I'm asking your approval.I followed the guideline

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42444 --- Ship it! not pretty, but it works. one small code issue below

Re: Upcoming changes to CI system

2013-10-27 Thread Scott Kitterman
Ben Cooksley wrote: >Hi all, > >In order to improve the maintainability and cleanliness of the "shared >dependencies" the way they will be handled on the CI system will be >changing. > >The nature of this change is that all projects which need a "shared >dependency" will now need to declare a de

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/ --- (Updated Oct. 27, 2013, 12:19 p.m.) Review request for kdelibs and Plasma.

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/#review42433 --- Ship it! this is also a pretty bad hack because it will cause

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/ --- (Updated Oct. 27, 2013, 12:19 p.m.) Review request for kdelibs, Plasma, Aa

Re: Upcoming changes to CI system

2013-10-27 Thread Allen Winter
On Sunday, October 27, 2013 09:32:59 PM Ben Cooksley wrote: > Hi all, > > In order to improve the maintainability and cleanliness of the "shared > dependencies" the way they will be handled on the CI system will be > changing. > > The nature of this change is that all projects which need a "share

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42418 --- Ah, that makes sense, thanks for your investigation! What coul

Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/ --- Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael Zanetti.

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-27 Thread Albert Astals Cid
> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > > > Some key name doesn't looks correct (F1 - F12

Re: Upcoming changes to CI system

2013-10-27 Thread Peter Grasch
Hi Ben, On 10/27/2013 05:32 PM, Ben Cooksley wrote: > A shared dependency is essentially a non-KDE project: > a) Where distribution packages are too old (like CMake) > b) projects which depend on Qt (and therefore cannot be installed system > wide) > > A list of shared dependencies can be seen >

Upcoming changes to CI system

2013-10-27 Thread Ben Cooksley
Hi all, In order to improve the maintainability and cleanliness of the "shared dependencies" the way they will be handled on the CI system will be changing. The nature of this change is that all projects which need a "shared dependency" will now need to declare a dependency against it in the appr