Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs

2014-01-30 Thread Inge Wallin
On Wednesday, January 29, 2014 22:53:59 Sven Brauch wrote: Hi! Cool project, I really missed such a component a while back (I actually wrote my own back then, which was less nice than yours). The code looks sane too from a quick look, so I'm all for moving it to extragear (although I'm not

Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs

2014-01-30 Thread Sebastian Gottfried
Hi, Cool project, I really missed such a component a while back (I actually wrote my own back then, which was less nice than yours). The code looks sane too from a quick look, so I'm all for moving it to extragear (although I'm not exactly an expert for sane code). Thanks! It doesn't

Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs

2014-01-30 Thread Sebastian Gottfried
Hi, So maybe KDE QtQuick Charts as the official name and kdeqtquickcharts for the repository? kqtquickcharts? That's better. More concise. So be it. Best regards, Sebastian

Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread kdeuser56 kdeuser56
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- tried to center align it? - Thomas Lübking On Jan. 30,

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread kdeuser56 kdeuser56
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as the icon of the icon button. I tried

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread kdeuser56 kdeuser56
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread kdeuser56 kdeuser56
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as