Re: small but Big request

2014-03-29 Thread Martin Gräßlin
On Friday 28 March 2014 16:17:19 David Boosalis wrote: > At the risk of getting 50 lashes. Can I make a request for new KDE Git > build instructions. All the instructions for building might be out there > and I know there is the uber "kdesrc-build" script, but you really got to > squint to get all

Re: Review Request 117090: add version to libmolletnetwork

2014-03-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117090/#review54533 --- This review has been submitted with commit d9c6e9aacf46ec8c56

Re: Review Request 117090: add version to libmolletnetwork

2014-03-29 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117090/ --- (Updated March 29, 2014, 10:24 a.m.) Status -- This change has been

Re: Moving Milou to Extragear

2014-03-29 Thread Vishesh Handa
Vishesh HandaOn Friday, February 14, 2014 01:09:19 PM wrote: > On Thursday, February 13, 2014 11:28:40 AM Burkhard Lück wrote: > > That loads the translation catalog, which also contains messages from the > > plasmoid outside the library. > > > > Apparently that happens early enough at runtime (a

Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157/ --- Review request for kde-workspace. Bugs: 314989 http://bugs.kde.org/sh

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157/ --- (Updated March 29, 2014, 11:58 a.m.) Review request for kde-workspace.

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157/#review54536 --- what is the valid (read: not malicious) usecase for this? i'd

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:02 p.m., Thomas Lübking wrote: > > what is the valid (read: not malicious) usecase for this? > > > > i'd rather say that if quitting the greeter to exit the lock w/o password, > > that should be fixed to *not* exit the lock w/o password provision. There are some usecase

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157/#review54538 --- I also have problems imagining what a use case for this is and

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. You have to authenticate anyway to a

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You ha

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Thomas Lübking
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You ha

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Thomas Lübking
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-29 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/ --- (Updated March 29, 2014, 5:14 p.m.) Review request for kde-workspace and

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-29 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/ --- (Updated March 29, 2014, 5:38 p.m.) Review request for kde-workspace and

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-29 Thread Stefan Brüns
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1351 > > > > > > you can leave out the "automatic multiseat won't be enabled" from the > > followup messages. > > > >

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-29 Thread Stefan Brüns
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1397 > > > > > > that seems questionable to me. why are you re-defining the display to > > be permanent? when the seat goes

Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/ --- Review request for kde-workspace, Martin Gräßlin and Kirill Elagin. Repos

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Kirill Elagin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- Why not simply add a parameter to KApplication constructor? -

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? Being? I'm not aware of such parameter, kdelibs is semi-frozen and the requirement is also pretty special to add such feature to KApplication, yesno? - Thomas ---

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplicat

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplicat

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty special to add such feature to KApplicat

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Thiago Macieira
Em sáb 29 mar 2014, às 12:25:48, Martin Gräßlin escreveu: > no, the lockscreen is secure. If you are logged in at a tty there is no way > to unlock the screen - the only way to bypass the lock is to kill ksmserver > which results in the session being killed. You can attach gdb to ksmserver and mak

kde-workspace/master is frozen until split happens

2014-03-29 Thread Víctor Blázquez
Hello everybody, As Àlex Fiestas requested, I created the following repositories: - khotkeys - kinfocenter - kmenuedit - ksysguard - kwin - kwrited - libksysguard - oxygen - plasma-desktop - plasma-workspace - systemsettings - powerdevil All those projects are under kde/kde-workspace [1] except p

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Klapetek
On Sat, Mar 29, 2014 at 11:25 PM, Thiago Macieira wrote: > Em sáb 29 mar 2014, às 12:25:48, Martin Gräßlin escreveu: > > no, the lockscreen is secure. If you are logged in at a tty there is no > way > > to unlock the screen - the only way to bypass the lock is to kill > ksmserver > > which result

Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-29 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure,

Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-29 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian Monr