Re: Review Request 112294: Implement multi-seat support in KDM

2014-06-02 Thread Oswald Buddenhagen
On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: kdm/backend/dm.c, line 1463 https://git.reviewboard.kde.org/r/112294/diff/8/?file=276202#file276202line1463 this is actually tricky ... what if the display is still there but the seat changed? i don't think you are handling

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
On June 1, 2014, 6:09 p.m., Andrea Iacovitti wrote: Are you sure about PPC-x86_64 substitution? Should not that be PPC-Intel instead? Just checked safari 6.0.5 sends Intel. I don't have other versions to test. Looking at http://www.useragentstring.com the other version seem to do the

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/ --- (Updated June 2, 2014, 10:22 a.m.) Review request for KDE Base Apps.

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/#review58978 --- Ship it! I think it can go in 4.13 branch, there should not

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
On June 2, 2014, 11:20 a.m., Andrea Iacovitti wrote: I think it can go in 4.13 branch, there should not be risk of regression. I don't have submit access so some one will have to do the submit for me. - Michael --- This is an

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/#review59012 --- This review has been submitted with commit

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

2014-06-02 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/ --- (Updated June 2, 2014, 6:36 p.m.) Status -- This change has been

Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- Review request for kde-workspace. Bugs:

SymbolEditor moved to KDE Review

2014-06-02 Thread Steve Allewell
Greetings The application SymbolEditor was recently imported to KDE Playground under the KDE Incubator process (with KXStitch) having previously been hosted on Sourceforge. SymbolEditor is a QPainterPath symbol creator and was originally written to provide symbol libraries for the KXStitch

Re: Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 3, 2014, 5:58 a.m.) Review request for kde-workspace.