Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review60482 --- Ship it! Ship It! - Oswald Buddenhagen On June 18, 2014, 1

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

2014-06-19 Thread Milian Wolff
> On June 19, 2014, 4:55 a.m., Dawit Alemayehu wrote: > > Is this patch not going into 4.13 branch? You can no longer compile KDE on > > rolling release based distros like ArchLinux without this patch. If others agree, I'll push this into the 4.13 branch. Imo, it's safe to do so as this patch

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review60485 --- This review has been submitted with commit b8aaeff128233cfaec

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-19 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 19, 2014, 10:04 a.m.) Status -- This change has been m

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review60489 --- This review has been submitted with commit 9aeacb07b1169fa3dc

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

2014-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/#review60494 --- This review has been submitted with commit 40e073c60f6cc8df13

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-19 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 19, 2014, 6:48 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/ --- (Updated June 19, 2014, 1:39 p.m.) Status -- This change has been di

Re: Review Request 118750: Prevent use after free

2014-06-19 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/ --- (Updated June 19, 2014, 8:11 p.m.) Status -- This change has been ma

Re: Review Request 118750: Prevent use after free

2014-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/#review60560 --- This review has been submitted with commit c77da7f565dc327ddd

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60569 --- kcms/keyboard/bindings.cpp

Re: Kronometer now in KDE Review

2014-06-19 Thread Elvis Angelaccio
2014-06-18 18:50 GMT+02:00 David Faure : > On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > > Hello, > > in the last two months this thread has not been updated, so I assume that > > the Kronometer UI is ok. > > What is still not clear is whether to move Kronometer in extragear-utils >