Re: Review Request 103815: Add yet another code generation option for having invokable methods

2014-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103815/#review69240 --- What happened to this? It stalled because of the request for

Re: [cmake-developers] Severe behavioural change regressions in release branch

2014-10-28 Thread Ben Boeckel
On Tue, Oct 28, 2014 at 09:58:58 +1300, Ben Cooksley wrote: If anyone is interested, help would be appreciated to get a Contracts style build up and running. In particular, pointers to documentation on how to perform such builds would be appreciated - we'll need to run make install for parts

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:36 a.m.) Review request for kdelibs, Solid

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:43 a.m.) Review request for kdelibs, Solid

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69293 --- Aside the minor WS issues, this patch looks correct and

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-28 Thread Dan Vrátil
On Oct. 24, 2014, 10:09 p.m., Christophe Giboudeaux wrote: konqueror/CMakeLists.txt, line 32 https://git.reviewboard.kde.org/r/120782/diff/1/?file=321968#file321968line32 should be merged with line 22 or 24 if it's optional It cannot, because KDED framework does not install into

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-28 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782/ --- (Updated Oct. 28, 2014, 4:22 p.m.) Review request for KDE Base Apps.

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-28 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120781/ --- (Updated Oct. 28, 2014, 4:24 p.m.) Review request for KDE Base Apps.

Gerrit: merging feature branches

2014-10-28 Thread Marco Martin
Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. now i tried the following 3 approaches, that all fail miserably: * from my branch: git push gerrit HEAD:refs/for/master gives [remote rejected] master

Re: Gerrit: merging feature branches

2014-10-28 Thread Thomas Lübking
On Dienstag, 28. Oktober 2014 19:13:53 CEST, Marco Martin wrote: Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. Google reply:

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Okt. 28, 2014, 7:50 nachm.) Review request for kdelibs, Solid

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
On Okt. 28, 2014, 2:59 nachm., Thomas Lübking wrote: solid-device-automounter/kded/DeviceAutomounter.cpp, line 76 https://git.reviewboard.kde.org/r/120839/diff/1/?file=322442#file322442line76 unrelated to this patch, but i'd like to raise: wtf does the function that

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69337 --- Ship it! I'm not familiar with the policies. I resolved the

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Thomas Lübking
On Okt. 28, 2014, 8:09 nachm., Frank Schütte wrote: I'm not familiar with the policies. I resolved the raised issues, so should I review my own request or is this something stupid? You're not supposed to approve your own patches (but if nobody ever feels in charge to approve it, no veto

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review69367 --- forward port, for interested ones -

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-28 Thread Ian Wadham
On Oct. 28, 2014, 11:05 p.m., Hrvoje Senjan wrote: forward port, for interested ones - https://git.reviewboard.kde.org/r/120876/ Thank you, Hrvoje, you are a gentleman and a scholar... and I am happy to have been able to help... :-) - Ian

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Christoph Feck
On Oct. 28, 2014, 8:09 p.m., Frank Schütte wrote: I'm not familiar with the policies. I resolved the raised issues, so should I review my own request or is this something stupid? Thomas Lübking wrote: You're not supposed to approve your own patches (but if nobody ever feels in

Re: Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

2014-10-28 Thread Frank Schütte
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/ --- (Updated Oct. 28, 2014, 11:37 p.m.) Review request for kdelibs, Solid,