Re: Why is C90 enforced in KDE?

On Sunday, December 06, 2015 04:08:04 PM Antonio Rojas wrote: > Hi, > Kipi-plugins fails to build with flex 2.6. This is due to the autogenerated > code in libpanorama containing //-style comments, which are disallowed in > C90. Adding -std=c99 to the CFLAGS at compile time doesn't have any

Re: Review Request 126253: kxmlgui.xsd add Separator append attribute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126253/ --- (Updated Dec. 6, 2015, 2:34 p.m.) Review request for kdelibs and Martin

Re: Why is C90 enforced in KDE?

2015-12-06 12:54 GMT-03:00 Thomas Lübking : > On Sonntag, 6. Dezember 2015 16:08:04 CEST, Antonio Rojas wrote: >> >> C90. Adding -std=c99 to the CFLAGS at compile time doesn't have any >> effect, since it is overriden by kdelibs (and by extra-cmake-modules in >> KF5).

Re: Review Request 126253: kxmlgui.xsd add Separator append attribute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126253/#review89184 --- Should the specification in kpartgui.dtd also be updated? -

Why is C90 enforced in KDE?

Hi, Kipi-plugins fails to build with flex 2.6. This is due to the autogenerated code in libpanorama containing //-style comments, which are disallowed in C90. Adding -std=c99 to the CFLAGS at compile time doesn't have any effect, since it is overriden by kdelibs (and by extra-cmake-modules in

Re: Why is C90 enforced in KDE?

On Sonntag, 6. Dezember 2015 16:08:04 CEST, Antonio Rojas wrote: C90. Adding -std=c99 to the CFLAGS at compile time doesn't have any effect, since it is overriden by kdelibs (and by extra-cmake-modules in KF5). What is the reason for this? I guess because of poor compiler support. One needs

Re: Review Request 126253: kxmlgui.xsd add Separator append attribute

> On Dec. 6, 2015, 3:17 p.m., Martin Walch wrote: > > Should the specification in kpartgui.dtd also be updated? Krazy doesn't look at kpartgui.dtd . I don't know what kpartgui.dtd is used for. I suppose adding the line "append CDATA #IMPLIED" into the Separator ATTLIST (line 125) would work.

Re: Why is C90 enforced in KDE?

2015-12-06 13:13 GMT-03:00 Allen Winter : > We have (had?) a policy that flex/yacc generated source files should be part > of the repo. > do not make everyone run flex/yacc when building. I disagree with this. It has happened to me more than once that I modify a flex

Re: Why is C90 enforced in KDE?

On Sunday, December 06, 2015 01:34:51 PM Nicolás Alvarez wrote: > 2015-12-06 13:13 GMT-03:00 Allen Winter : > > We have (had?) a policy that flex/yacc generated source files should be > > part of the repo. > > do not make everyone run flex/yacc when building. > > I

Re: Generated files in version control (was: Re: Why is C90 enforced in KDE?)

2015-12-06 18:46 GMT-03:00 Thomas Lübking : > On Sonntag, 6. Dezember 2015 22:23:01 CEST, Nicolás Alvarez wrote: > >> I am aware that Nuno manually chose rendering engine and scaling >> method for every individual Oxygen icon based on seeing which one gave >>

Generated files in version control (was: Re: Why is C90 enforced in KDE?)

2015-12-06 17:28 GMT-03:00 Ingo Klöcker : > On Sunday 06 December 2015 13:34:51 Nicolás Alvarez wrote: >> If it was up to me, there wouldn't even be .png icons in git version >> control, they would be generated from their .svg files at compile >> time. > > You do not seem to be

Re: Generated files in version control (was: Re: Why is C90 enforced in KDE?)

On Sonntag, 6. Dezember 2015 22:23:01 CEST, Nicolás Alvarez wrote: I am aware that Nuno manually chose rendering engine and scaling method for every individual Oxygen icon based on seeing which one gave (subjectively) better results. That is not documented anywhere Seriously? I mean, are you

Re: Why is C90 enforced in KDE?

Nicolás Alvarez wrote: > I disagree with this. It has happened to me more than once that I > modify a flex file, regenerate it, and find it has been broken for > *years* due to incompatibilities with newer flex versions and nobody > noticed. Or I forget to regenerate it. > > Should we put .mo

Re: Why is C90 enforced in KDE?

Thomas Lübking wrote: > Wtf does flex/yacc produce incompliant comments? > Seriously, COMMENTS! > That's a convenience thing. I remember a mail from several years ago where Flex developers said they had no interest in supporting an ancient C standard when C99 has been out for years. (I think it

Re: Why is C90 enforced in KDE?

On Sonntag, 6. Dezember 2015 17:41:07 CEST, Nicolás Alvarez wrote: Then we ignore warnings about // comments and pay attention to others Wtf does flex/yacc produce incompliant comments? Seriously, COMMENTS! That's a convenience thing. int foo = bar; // bar defined in wherever is simpler than

Re: Why is C90 enforced in KDE?

2015-12-06 18:59 GMT-03:00 Thomas Lübking : > On Sonntag, 6. Dezember 2015 17:41:07 CEST, Nicolás Alvarez wrote: >> >> Then we ignore warnings about // comments and pay attention >> to others > > > Wtf does flex/yacc produce incompliant comments? > Seriously, COMMENTS! >