Re: K(Abstract)FileItemActionPlugin

2013-06-18 Thread Chao Feng
with KAbstractFileItemActionPlugins also comes with > > >> great responsibility: code that is executed in the actions() method > > >> (that is the one that gets called every time the context menu is > > >> opened) must be written with great care, and the most imp

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-02-02 Thread Chao Feng
> On Jan. 31, 2013, 1:16 p.m., Chao Feng wrote: > > File Attachment: Bulk operations (2nd layout) - 2 > > <http://git.reviewboard.kde.org/r/108570/#fcomment33> > > > > I think lots of people will be confused by this check list. Why I need > > to selec

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-31 Thread Chao Feng
It is the limitation of old web form. Now more and more sites fix it by using ajax action. This change did not save many clicks. Can we find a simple way to do it instead of make it confusing? - Chao Feng On Jan. 30, 2013, 1:50 p.m., Sand

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

2013-01-12 Thread Chao Feng
> > Thomas Lübking wrote: > itemsize (spacing would also increase space between text) and it's > actually the only way to fix the bug (look at the cn text of notifications or > a11y) and scales better when eg. egypt returned to hieroglyphs or so ;-) > > Chao Feng wrote: &

Re: Review Request: fix 234407 - set minimum width for system settings icon view

2013-01-11 Thread Chao Feng
ttp://git.reviewboard.kde.org//r/108328/#scomment131> Others looks good, I still think here it looks strange. Increase to 7 characters? Screenshot: chinese after change <http://git.reviewboard.kde.org//r/108328/#scomment132> Same here - Chao Feng On Jan. 10, 2013, 8:48 p.m., Xuetia

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

2013-01-10 Thread Chao Feng
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25091 --- On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote: > > --- &

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

2013-01-10 Thread Chao Feng
nfiguration option. Let the user choose what they want. - Chao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25038

Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

2013-01-09 Thread Chao Feng
37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e Diff: http://git.reviewboard.kde.org/r/108285/diff/ Testing --- 1. Apply patch 2. Systemsetting show ok on CJK Thanks, Chao Feng