Re: New repo in kdereview: PlasmaTube

2023-02-05 Thread Devin
t; i18n Should be fixed now. > LocalizedString::setApplicationDomain("tokodon"); Fixed. Thanks, Devin On Sun, Feb 5, 2023 at 4:16 AM Albert Astals Cid wrote: > > El dissabte, 4 de febrer de 2023, a les 19:14:20 (CET), Devin va escriure: > > Hi everyone, > > > &

New repo in kdereview: PlasmaTube

2023-02-04 Thread Devin
Hi everyone, I would like to put PlasmaTube through kdereview: https://invent.kde.org/multimedia/plasmatube PlasmaTube is a YouTube client for both mobile and desktop. Thanks, Devin

Re: New repo in kdereview: kclock

2023-02-02 Thread Devin
Hi everyone, Is there any feedback left for KClock? If not, I will consider it to have passed kdereview. Thanks, Devin On Fri, Dec 30, 2022 at 2:27 AM Justin wrote: > > Thanks for the quick reply Albert. I'm not a developer but I've gone > over much of the comments from previous: &

Re: New repo in kdereview: KRecorder

2022-12-07 Thread Devin
idUnit. On Mon, Dec 5, 2022 at 4:55 PM Nate Graham wrote: > > On 12/4/22 16:47, Devin wrote: > >> I can reproduce it in the following way on Desktop: > > > > Hmm, I'm on Kirigami from master and still can't reproduce it, see the > > attached video. > > I think I

Re: New repo in kdereview: KWeather

2022-11-30 Thread Devin
Should be fixed now, I removed the dialog flag on the window. Thanks, Devin On Tue, Nov 29, 2022 at 10:33 PM Nate Graham wrote: > > This happens on X11 when using QtDialogs for reasons I don't understand. > See > https://invent.kde.org/frameworks/knewst

Re: New repo in kdereview: KWeather

2022-11-29 Thread Devin
Hmm, I have no idea why the behaviour is different for you, but I get: https://i.imgur.com/CvGD8HS.png If you removed the "Qt.Dialog" flag here: https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14, does it still have the issue? Tha

Re: New repo in kdereview: KWeather

2022-11-29 Thread Devin
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's > uncloseable, any idea why that would be? That's very strange, it should be showing up as a regular window, does pressing the close button on the window decoration not work? Thanks, Devin On Tue, Nov 29, 202

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
ency version... Nicolas added a change to add it as a proper compile time dependency now: https://invent.kde.org/plasma-mobile/kweather/-/merge_requests/79 Thanks, Devin On Mon, Nov 28, 2022 at 7:48 PM Nate Graham wrote: > > Thanks, I'm happy with the UI now!  Really great app. > > Nate

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
Is there some way I can do this at runtime? kirigami-addons is used here as a QML API. Thanks, Devin On Mon, Nov 28, 2022 at 12:17 PM Ingo Klöcker wrote: > > On Montag, 28. November 2022 17:53:59 CET Devin wrote: > > > FWIW i can't open settings anymore > > > > Ma

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
> FWIW i can't open settings anymore Make sure you have the latest kirigami-addons built (from master). Thanks, Devin On Mon, Nov 28, 2022 at 11:15 AM Albert Astals Cid wrote: > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: > > > T

Re: New repo in kdereview: KWeather

2022-11-24 Thread Devin
Astals Cid wrote: > > El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure: > > Hi everyone, > > > > I would like to put kweather through kdereview: > > > > https://invent.kde.org/plasma-mobile/kweather > > > > KWeather is a

Re: New repo in kdereview: KRecorder

2022-11-24 Thread Devin
> I can still see this: https://i.imgur.com/MrrwyAo.jpg No matter how I try to resize the window, I can't seem to reproduce the issue... weird > When I look at other platforms, what I see is that it's common and > traditional for the *record* button to be a red circle, but the stop button > is

Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
settings window. I guess I can make the about page a popup as well, thanks! Regards, Devin On Wed, Nov 9, 2022 at 5:37 PM Jeremy Whiting wrote: > > After installing kirigami-addons it runs fine, adding my location went > smooth, etc. Only nitpick I found as a user was that it's a bi

Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
Hi Jeremy, Looks like I forgot to add a CMake check for Kirigami Addons. It has been added now. KWeather has a runtime dependency on Kirigami Addons as well, not just Kirigami. Thanks, Devin On Wed, Nov 9, 2022 at 5:31 PM Jeremy Whiting wrote: > > Looks like it's got a runtime depe

New repo in kdereview: KWeather

2022-11-09 Thread Devin
kdereview. Thanks, Devin

Re: New repo in kdereview: QMLKonsole

2022-11-09 Thread Devin
timeline on doing so, and we still need a terminal emulator for Plasma Mobile for the time being. Any other feedback? Thanks, Devin On Fri, Oct 21, 2022 at 5:47 PM Devin wrote: > > > qrc:/SavedCommandsDialog.qml:44:9: QML PlaceholderMessage: Cannot specify > > left, right, and h

Re: New repo in kdereview: KRecorder

2022-11-09 Thread Devin
it spawns Switched. > On the "Editing [name]" OverlaySheet, the filename field's label is "Audio > Input:" which seems inappropriate. Fixed. > Playback buttons can get cut off with short windows: Fixed. > None of the icons-only buttons on the recording or playback p

Re: New repo in kdereview: KRecorder

2022-10-26 Thread Devin
Any other comments or issues to address? Thanks, Devin On Fri, Oct 21, 2022 at 6:21 PM Albert Astals Cid wrote: > > El divendres, 21 d’octubre de 2022, a les 23:55:28 (CEST), Devin va escriure: > > > make install doesn't install any icon for me with the current master. > &g

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
ted to the prior commit which installed the icon fine (it should be installing to /usr/share/icons/hicolor/scalable/apps/krecorder.svg), does this not work for you on X11? I double checked and the application icon shows for me. Thanks, Devin On Fri, Oct 21, 2022 at 5:08 PM Albert Astals Cid wrote: >

Re: New repo in kdereview: QMLKonsole

2022-10-21 Thread Devin
> > El divendres, 21 d’octubre de 2022, a les 4:28:13 (CEST), Devin va escriure: > > Hi everyone, > > > > I would like to put qmlkonsole through kdereview: > > > > https://invent.kde.org/plasma-mobile/qmlkonsole > > > > QMLKonsole is

Re: New repo in kdereview: KRecorder

2022-10-21 Thread Devin
e icon installed to might be non-standard. I think I've fixed it on master now by copying the way other KDE apps install the icon. > The model was kind-of-potentially an infinite tree, fixed with other small tweaks at https://invent.kde.org/plasma-mobile/krecorder/-/merge_requests/15 Thank you! Regar

New repo in kdereview: QMLKonsole

2022-10-20 Thread Devin
Hi everyone, I would like to put qmlkonsole through kdereview: https://invent.kde.org/plasma-mobile/qmlkonsole QMLKonsole is an Qt Quick based terminal emulator application for Plasma Mobile. It depends on qmltermwidget: https://github.com/Swordfish90/qmltermwidget Thanks, Devin

New repo in kdereview: KRecorder

2022-10-20 Thread Devin
/krecorder KRecorder is an audio recording application for Plasma Mobile and Desktop. Thanks, Devin