Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

2014-04-11 Thread Martin Bříza
://github.com/sddm/sddm/pull/139 - Martin Bříza On April 11, 2014, 1:06 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
, Martin Bříza

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
/r/119088/diff/ Testing --- Thanks, Martin Bříza

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
reply, visit: https://git.reviewboard.kde.org/r/119088/#review61501 ------- On July 2, 2014, 6:02 p.m., Martin Bříza wrote: > > --- > This is an automatically generated e-m

Re: Review Request 110089: fix lightdm with systemd and kde user switch

2013-04-19 Thread Martin Bříza
implemented in the code. I think it was written against an old branch, not 4.10, as the code differs on a lot of places and doesn't apply at all. - Martin Bříza On April 19, 2013, 7:36 p.m., Xuetian Weng wrote: > > --- > This is an

Review Request 110099: Fix ksplash geometry when kscreen is used

2013-04-20 Thread Martin Bříza
: http://git.reviewboard.kde.org/r/110099/diff/ Testing --- ./ksplashqml Minimalistic --test and connecting another screen while in progress Thanks, Martin Bříza

Re: Review Request 110099: Fix ksplash geometry when kscreen is used

2013-04-20 Thread Martin Bříza
dated) - ksplash/ksplashqml/CMakeLists.txt c2065d9 ksplash/ksplashqml/SplashApp.h 6bcdc7a ksplash/ksplashqml/SplashApp.cpp d8e6b42 Diff: http://git.reviewboard.kde.org/r/110099/diff/ Testing --- ./ksplashqml Minimalistic --test and connecting another screen while in progress Thanks, M

Re: Review Request 110099: Fix ksplash geometry when kscreen is used

2013-04-20 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110099/#review31348 --- Ship it! Ship It! - Martin Bříza On April 20, 2013, 4:58

Re: Review Request 110894: Add missing error mapping to KTcpSocket

2013-06-11 Thread Martin Bříza
added over time and aren't included and mapped in the class? I mean the UnfinishedSocketOperationError and every Proxy error except the ProxyAuthenticationRequiredError. Seems they shouldn't be needed but just to be sure. - Martin Bříza On June 11, 2013, 12:35 p.m., Dawit Alema

Re: Review Request 112294: Implement multi-seat support in KDM

2013-08-27 Thread Martin Bříza
as kde-workspace is being frozen at 4.11 and KDM was being said to be obsoleted for Plasma Workspaces 2. Could please anybody explain if this does relate? Thanks. - Martin Bříza On Aug. 26, 2013, 3:49 p.m., Stefan Brüns wrote: > > --

Review Request 113147: Propagate NTP clock to hwclock, too

2013-10-07 Thread Martin Bříza
. Thanks, Martin Bříza

Re: Review Request 113147: Propagate NTP clock to hwclock, too

2013-10-07 Thread Martin Bříza
/dateandtime/helper.cpp 9168db3 Diff: http://git.reviewboard.kde.org/r/113147/diff/ Testing --- Built, ran, RTC is the same as system clock. Thanks, Martin Bříza

Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2013-10-07 Thread Martin Bříza
13152/diff/ Testing --- Built and tested on Fedora 19 x86_64. Thanks, Martin Bříza

Re: Review Request 113147: Propagate NTP clock to hwclock, too

2013-10-24 Thread Martin Bříza
://git.reviewboard.kde.org/r/113147/diff/ Testing --- Built, ran, RTC is the same as system clock. Thanks, Martin Bříza

Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2013-10-31 Thread Martin Bříza
--- Initialize the user's groups in between calling setegid and seteuid to have the correct supplemental groups in place. Diffs - kdm/kfrontend/kgreeter.cpp 1bddab5 Diff: http://git.reviewboard.kde.org/r/113518/diff/ Testing --- Thanks, Martin Bříza

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2013-11-05 Thread Martin Bříza
/diff/ Testing --- Thanks, Martin Bříza

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza
ing - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113518/#review43117 --- On Jan. 2, 2014, 3:28 p.m., Mart

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza
Diff: https://git.reviewboard.kde.org/r/113518/diff/ Testing --- Thanks, Martin Bříza

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Martin Bříza
kcontrol/dateandtime/helper.cpp 9168db3 Diff: https://git.reviewboard.kde.org/r/113152/diff/ Testing --- Built and tested on Fedora 19 x86_64. Thanks, Martin Bříza