Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-31 Thread Oswald Buddenhagen
please make sure you use that (apart from adding the BUG lines). - Oswald Buddenhagen On July 29, 2015, 9:39 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Using Gerrit for code review in KDE

2014-09-16 Thread Oswald Buddenhagen
On Mon, Sep 15, 2014 at 09:34:27AM -0700, Thiago Macieira wrote: > On Monday 15 September 2014 16:49:39 Milian Wolff wrote: > > Where do I see the diff there? In the gerrit that runs on qt-project, I can > > easily click one button to go to a unified or side-by-side diff view. Is > > that a custom

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review60482 --- Ship it! Ship It! - Oswald Buddenhagen On June 18, 2014

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

2014-06-07 Thread Oswald Buddenhagen
icant compared to everything else. i have no idea whether keeping a string table of the converted values on top of that would still add value. it could if the many identical values are actually all used (identical keys should not matter, as they are never converted - unless you enumerate them). - O

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

2014-06-07 Thread Oswald Buddenhagen
if the entry map was an actual tree. thomas braxton sent me a preliminary version of that years ago, but never finished it. are you interested in picking this up? - Oswald Buddenhagen On June 6, 2014, 11:22 a.m., Milian Wolff wrote

Re: Review Request 112294: Implement multi-seat support in KDM

2014-06-01 Thread Oswald Buddenhagen
> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1463 > > <https://git.reviewboard.kde.org/r/112294/diff/8/?file=276202#file276202line1463> > > > > this is actually tricky ... what if the display is still there but the &g

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1463 > > <https://git.reviewboard.kde.org/r/112294/diff/8/?file=276202#file276202line1463> > > > > this is actually tricky ... what if the display is still there but the &g

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
new capabilities. i pushed the off-by-one fixes so we have that out of the way. - Oswald Buddenhagen On May 29, 2014, 7:03 p.m., Stefan Brüns wrote: > > --- > This is an autom

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1436 > > <https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1436> > > > > "no matching unused" > > Stefan Brüns wrote: > "

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-28 Thread Oswald Buddenhagen
-------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112294/ > --- > > (Updated May 26, 2014, 12:06 a.m.) > > > Review request for kde-wor

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-26 Thread Oswald Buddenhagen
git.reviewboard.kde.org/r/112294/#comment40649> cls + 1 kdm/backend/session.c <https://git.reviewboard.kde.org/r/112294/#comment40655> what is the point of that? i don't think the greeter can use this for anything as-is. the docu of StaticServers needs to be extended now

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-25 Thread Oswald Buddenhagen
.reviewboard.kde.org/r/112294/#review58394 --- On May 18, 2014, 7:44 p.m., Stefan Brüns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112294/ > -

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-24 Thread Oswald Buddenhagen
h an error to the log). if somebody feels like implementing actual support for that, they can. as before, the ReserveServers are only meant for demo purposes. don't worry about them. would that work? - Oswald Buddenhagen On May 18, 2014, 7:44 p.m., Stefan Brüns wrote: > >

Re: Review Request 118058: Allow quotation marks in passwords

2014-05-09 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118058/#review57627 --- Ship it! Ship It! - Oswald Buddenhagen On May 8, 2014, 9

Re: Review Request 112294: Implement multi-seat support in KDM

2014-04-09 Thread Oswald Buddenhagen
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1397 > > <https://git.reviewboard.kde.org/r/112294/diff/2/?file=186612#file186612line1397> > > > > that seems questionable to me. why are you re-defining the display to >

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

2014-04-09 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117400/#review55254 --- Ship it! Ship It! - Oswald Buddenhagen On April 6, 2014

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

2014-04-06 Thread Oswald Buddenhagen
> excess braces (yup, qt style in kdm). kdm/backend/client.c <https://git.reviewboard.kde.org/r/117400/#comment38415> for pedantry, you actually should free() desktopNames (to be buf). - Oswald Buddenhagen On April 6, 2014,

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-31 Thread Oswald Buddenhagen
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1397 > > <https://git.reviewboard.kde.org/r/112294/diff/2/?file=186612#file186612line1397> > > > > that seems questionable to me. why are you re-defining the display to >

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-30 Thread Oswald Buddenhagen
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1351 > > <https://git.reviewboard.kde.org/r/112294/diff/2/?file=186612#file186612line1351> > > > > you can leave out the "automatic multiseat won't

Re: Review Request 112294: Implement multi-seat support in KDM

2014-02-18 Thread Oswald Buddenhagen
> On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote: > > given that there is no intention to make further feature releases of the > > kde workspace which will include kdm, i wonder why we'd go through the > > (potentially tedious) process of upstreaming this no

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2013-11-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113518/#review43117 --- what exploit do you have in mind? - Oswald Buddenhagen On

Re: Review Request 113493: Fix entering kcm_kdm resets settings of current session

2013-10-29 Thread Oswald Buddenhagen
will be forward-merged to master at some point... - Oswald Buddenhagen On Oct. 28, 2013, 11:14 p.m., Luc Menut wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-06 Thread Oswald Buddenhagen
> On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote: > > given that there is no intention to make further feature releases of the > > kde workspace which will include kdm, i wonder why we'd go through the > > (potentially tedious) process of upstreaming this no

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-04 Thread Oswald Buddenhagen
> On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote: > > given that there is no intention to make further feature releases of the > > kde workspace which will include kdm, i wonder why we'd go through the > > (potentially tedious) process of upstreaming this no

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-03 Thread Oswald Buddenhagen
releases of the kde workspace which will include kdm, i wonder why we'd go through the (potentially tedious) process of upstreaming this now? - Oswald Buddenhagen On Sept. 2, 2013, 11:34 p.m., Stefan Brüns wrote: > > --- &

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Oswald Buddenhagen
> On June 29, 2013, 11:37 a.m., Oswald Buddenhagen wrote: > > Ship It! > > Albert Astals Cid wrote: > Mr Mancha Mancha we're going to need your real name and email before we > can submit this for proper attribution. > > mr. mancha wrote: > Hello Alb

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35275 --- Ship it! Ship It! - Oswald Buddenhagen On June 28, 2013, 7

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread Oswald Buddenhagen
rap any of these statements to start with - they are short enough for my taste (qt has a 100 column soft limit). kdm/backend/client.c <http://git.reviewboard.kde.org/r/111261/#comment25786> i really meant line 543. ;) just as the code using it, it must be in the else branch of PAM and AIX.

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread Oswald Buddenhagen
will cause unused variable warnings. follow the #ifdef cascade closer. line 543 should fit, with the addition of a compound !ultrix clause (mostly for formal correctness). kdm/backend/client.c <http://git.reviewboard.kde.org/r/111261/#comment25741> remove trailing space - Oswald B

Re: Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

2013-06-18 Thread Oswald Buddenhagen
the higher-level cascading without reading all the code again, but at this low level, the change is logically correct afaict. - Oswald Buddenhagen On June 7, 2013, 1:28 p.m., David Faure wrote: > > --- > This is an automatically

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32080 --- Ship it! Ship It! - Oswald Buddenhagen On May 5, 2013, 12

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
g/r/110315/#comment23889> and now you ignored the warning from the compiler. ;) - Oswald Buddenhagen On May 5, 2013, 11:37 a.m., Raymond Wooninck wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
g/r/110315/#comment23888> you didn't compile that ... - Oswald Buddenhagen On May 5, 2013, 11:22 a.m., Raymond Wooninck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
g/r/110315/#comment23883> i wonder whether this condition is actually useful. i originally added it because some *BSDs (iirc) had an incompatible adduser command. the situation may be entirely different for useradd. - Oswald Buddenhagen On May 5, 2013, 10:53 a.m., Raymond Wooninck

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
up. did i look wrong? or is this feature a semi-new addition? - Oswald Buddenhagen On May 5, 2013, 8:04 a.m., Raymond Wooninck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread Oswald Buddenhagen
was involved in: http://www.mail-archive.com/development@qt-project.org/msg04255.html http://comments.gmane.org/gmane.comp.kde.devel.core/54679 - Oswald Buddenhagen On May 5, 2013, 8:13 a.m., Róbert Szókovács wrote: > > --- > T

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Oswald Buddenhagen
On Mon, Apr 29, 2013 at 03:48:35PM +0200, Martin Briza wrote: > On Mon, 29 Apr 2013 09:17:15 +0200, Oswald Buddenhagen wrote: > >note that partial works (be it regressions or just a highly asymmetrical > >code structure) will not be accepted. if you don't find somebody to d

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Oswald Buddenhagen
On Thu, Apr 25, 2013 at 03:11:25PM +0200, Martin Bříza wrote: > after fixing a bit in the $subj file I've realized it (in my opinion) should > be split into one abstract class with a factory handling the back-ends > provided by the current session managers such as ConsoleKit and > systemd-logind wh

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-24 Thread Oswald Buddenhagen
nation how that would correlate with your hangs. - Oswald Buddenhagen On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: KCoreConfigSkeleton::writeConfig is void

2013-03-21 Thread Oswald Buddenhagen
On Thu, Mar 21, 2013 at 11:21:15PM +0100, Albert Astals Cid wrote: > Anyone knows why KCoreConfigSkeleton::writeConfig is void? > > Maybe we can change it to bool in frameworks? > yes. we had that in kconfig as well. i think i fixed it for 4.0. at least i hope i did. ^^

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-19 Thread Oswald Buddenhagen
> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote: > > kpty/tests/kptyprocesstest.cpp, line 193 > > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line193> > > > > i don't think eating the sleep is a good idea. i

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Oswald Buddenhagen
y/tests/kptyprocesstest.cpp <http://git.reviewboard.kde.org/r/109551/#comment21998> the -c needs to be a separate argument. the quotes, backslashes and attempt at a newline are all garbage. - Oswald Buddenhagen On March 18, 2013, 7:54 p.m., Martin

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Oswald Buddenhagen
ttp://git.reviewboard.kde.org/r/109551/#comment21968> why should they? you already have the solution in the previous hunk. - Oswald Buddenhagen On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatica

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-02 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108711/#review26540 --- Ship it! Ship It! - Oswald Buddenhagen On Feb. 2, 2013, 8

Re: Finalized proposal for changes to i18n in KF5

2013-01-09 Thread Oswald Buddenhagen
On Tue, Jan 08, 2013 at 03:05:25PM +0100, Chusslove Illich wrote: > >> [: Chusslove Illich :] > >> I'm not opposed to some additional bureaucracy in order to make the > >> framework more accessible to potential users. [...] > > > > [: Oswald Bu

Re: Finalized proposal for changes to i18n in KF5

2013-01-07 Thread Oswald Buddenhagen
On Sat, Jan 05, 2013 at 06:38:58PM +0100, Chusslove Illich wrote: > > [: Oswald Buddenhagen :] > > of course, it would be even better if you strived for submission to qt- > > project, if at all realistic (for now probably an add-on, but definitely > > under cla). other

Re: Plans for SVN infrastructure shutdown

2013-01-04 Thread Oswald Buddenhagen
On Wed, Jan 02, 2013 at 06:52:32PM -0300, Nicolás Alvarez wrote: > http://community.kde.org/Sysadmin/SVNInfrastructureShutdown > this whole thing ignores that svn is still simply the better option for certain types of content - multimedia data in particular. of course git could be hacked to Not Su

Re: Finalized proposal for changes to i18n in KF5

2013-01-04 Thread Oswald Buddenhagen
On Sat, Dec 22, 2012 at 10:44:22AM +0100, Chusslove Illich wrote: > I have written up the headers and Doxygen pages for the Ki18n framework as > it should finally look like, available here: > excellent work. though i was too lazy to make a real api review. ^^ of course, it would be even better if

Re: Review Request: port Sonnet to QSettings

2012-12-18 Thread Oswald Buddenhagen
h KConfig or by passing values as QVariant maps or hashes. > > > > Oswald Buddenhagen wrote: > and where exactly do you see that kconfig maintainer? ;) > > it's unfortunate that the chosen config class is part of the API. > judging by uses, would it be reasonable

Re: Review Request: port Sonnet to QSettings

2012-12-17 Thread Oswald Buddenhagen
> On Dec. 17, 2012, 10:38 p.m., Kevin Krammer wrote: > > IMHO this is wrong. > > Not code wise but conceptual. As far as I understand QSettings is basically > > deprecated, it is just not official marked as such because there is no > > replacement. This would be porting away from a fully functi

Re: Review Request: Prevent KConfigGroup::revertToDefault from marking the kconfig as dirty if there's nothing to do

2012-11-28 Thread Oswald Buddenhagen
On Wed, Nov 28, 2012 at 03:43:46PM -, David Faure wrote: > I don't see a KConfigData class, not a revertToDefault outside of > KConfigGroup, so I wonder what you saw and where... > ah. that's because it's called KEntryMap in fact. it's in a file called kconfigdata.h.

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Oswald Buddenhagen
hould adjust the other plugins as well). - Oswald Buddenhagen On Sept. 19, 2012, 4:57 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Oswald Buddenhagen
> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > <http://git.reviewboard.kde.org/r/106124/diff/3/?file=83586#file83586line13> > > > > "xembe[]ds" > > > > this sounds funny

Re: Review Request: Ability to select which screen savers are used for "Random"

2012-09-22 Thread Oswald Buddenhagen
stent with yourself. kcontrol/screensaver/scrnsave.cpp <http://git.reviewboard.kde.org/r/106524/#comment15270> endsWith kcontrol/screensaver/scrnsave.cpp <http://git.reviewboard.kde.org/r/106524/#comment15271> unrelated style change. don't do that. - Oswald Budd

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-08 Thread Oswald Buddenhagen
nsaver/shell/CMakeLists.txt <http://git.reviewboard.kde.org/r/106124/#comment14772> indentation plasma/screensaver/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/106124/#comment14773> you shouldn't "eat" the empty line. - Oswald Buddenhagen On Sept. 4,

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-08-25 Thread Oswald Buddenhagen
ment14200> don't leave dead code in you could/should fix at least the most blatant coding style violations (like wholly wrong indentation) while you are re-importing the code. - Oswald Buddenhagen On Aug. 24, 2012, 11:30 a.m., Marco Martin wrote: > > -

Re: Review Request: Fix hang in kcm_useraccount

2012-08-15 Thread Oswald Buddenhagen
right (and thus providing a prototype for the new kdesu) or want to take the shortcut? - Oswald Buddenhagen On Aug. 14, 2012, 12:33 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Fix hang in kcm_useraccount

2012-08-11 Thread Oswald Buddenhagen
code seemed rather arcane and fragile, so i simplified it "a bit" ... - Oswald Buddenhagen On Aug. 9, 2012, 7:50 a.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request: Fix hang in kcm_useraccount

2012-08-07 Thread Oswald Buddenhagen
> On Aug. 7, 2012, 7:26 a.m., Oswald Buddenhagen wrote: > > did you look at the changes i did in kdelibs/kdesu a while ago? this should > > probably go in line with them (i didn't check whether it already does). > > Michael Palimaka wrote: > What should I be l

Re: Review Request: Support for GRUB2 submenus

2012-08-07 Thread Oswald Buddenhagen
> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote: > > Ship It! > > Konstantinos Smanis wrote: > What should I commit to which branches? 4.8.5 is out, so any commits in > the 4.8.x branch won't ever be officially released. I guess the kdm part can > affec

Re: Review Request: Support for GRUB2 submenus

2012-08-07 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17055 --- Ship it! Ship It! - Oswald Buddenhagen On Aug. 7, 2012, 3

Re: Review Request: Support for GRUB2 submenus

2012-08-07 Thread Oswald Buddenhagen
e.org/r/105563/#comment13372> len isn't actually used in that loop - Oswald Buddenhagen On Aug. 7, 2012, 9:20 a.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request: Fix hang in kcm_useraccount

2012-08-07 Thread Oswald Buddenhagen
? this should probably go in line with them (i didn't check whether it already does). - Oswald Buddenhagen On Aug. 6, 2012, 5:03 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Support for GRUB2 submenus

2012-08-06 Thread Oswald Buddenhagen
d() detects the no-op case). ksmserver/shutdowndlg.cpp <http://git.reviewboard.kde.org/r/105563/#comment13363> remove the braces (qt style here, not kdelibs). ksmserver/shutdowndlg.cpp <http://git.reviewboard.kde.org/r/105563/#comment13362> i'd swap this with the next lin

Re: Review Request: Support for GRUB2 submenus

2012-08-06 Thread Oswald Buddenhagen
> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 488 > > <http://git.reviewboard.kde.org/r/105563/diff/14/?file=76096#file76096line488> > > > > as you make assumptions about the list structure below anyway, you can

Re: Review Request: Support for GRUB2 submenus

2012-08-05 Thread Oswald Buddenhagen
e submenu case, so it should be in the if ksmserver/shutdowndlg.cpp <http://git.reviewboard.kde.org/r/105563/#comment13309> if you put the declaration of action outside the conditional and assign only the action here, the duplicated setData call can be outside the

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Oswald Buddenhagen
> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 239 > > <http://git.reviewboard.kde.org/r/105563/diff/11/?file=75565#file75565line239> > > > > this implementation is very clever, but i wonder whether it wouldn'

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Oswald Buddenhagen
t;http://git.reviewboard.kde.org/r/105563/#comment13023> fwiw, the assignment of label is pointless here, as replace modifies the original object. see that in the context of the above comment. - Oswald Buddenhagen On July 31, 2012, 5:54 p.m., Konstantinos Smanis wrote: > > --

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
rd.kde.org/r/105563/#comment12971> brace symmetry violated - Oswald Buddenhagen On July 29, 2012, 7:05 p.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 29, 2012, 6:56 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 288 > > <http://git.reviewboard.kde.org/r/105563/diff/5/?file=75332#file75332line288> > > > > as this is a constant, you could use stringify() and literal > > co

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
arn() messages which be properly capitalized. - Oswald Buddenhagen On July 29, 2012, 6:50 p.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
visit: > http://git.reviewboard.kde.org/r/105563/ > --- > > (Updated July 29, 2012, 6:06 p.m.) > > > Review request for KDE Runtime and Oswald Buddenhagen. > > > Description > --- > > Recent versions of GRUB2 introduce sub

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
mment12952> you can just use ...toString() == title - Oswald Buddenhagen On July 29, 2012, 6:06 p.m., Konstantinos Smanis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73177#file73177line477> > > > > no way. the backend should directly communicate the hierarchy > >

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73177#file73177line477> > > > > no way. the backend should directly communicate the hierarchy > >

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73175#file73175line282> > > > > as you are putting the submenus into the selection list anyway, "m

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73175#file73175line282> > > > > as you are putting the submenus into the selection list anyway, "m

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73175#file73175line282> > > > > as you are putting the submenus into the selection list anyway, "m

Re: Review Request: Support for GRUB2 submenus

2012-07-29 Thread Oswald Buddenhagen
> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > <http://git.reviewboard.kde.org/r/105563/diff/2/?file=73175#file73175line231> > > > > you don't seem to be actually counting opening braces, so detaching

Re: Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Oswald Buddenhagen
On Fri, Jul 20, 2012 at 08:27:36PM +0200, Thomas Lübking wrote: > Am 20.07.2012, 20:18 Uhr, schrieb Martin Gräßlin : > >already on the system (to my knowledge hardly anything not running as root > >can be protected against an attacker with same user privs). > > You can establish secure IPC - i fran

Re: Review Request: Support for GRUB2 submenus

2012-07-17 Thread Oswald Buddenhagen
05563/#comment12626> don't fix the style of code you didn't touch otherwise ksmserver/shutdowndlg.cpp <http://git.reviewboard.kde.org/r/105563/#comment12627> missing space after keyword execess braces (kdm uses qt style, not kdelibs style) - Oswald Buddenhag

Re: Review Request: Add submenu support to QML shutdown dialog.

2012-07-17 Thread Oswald Buddenhagen
> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Support for GRUB2 submenus

2012-07-17 Thread Oswald Buddenhagen
s is not a public header or code using boost, so please use the proper foreach keyword - Oswald Buddenhagen On July 14, 2012, 8:16 a.m., Konstantinos Smanis wrote: > > --- > This is an au

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-28 Thread Oswald Buddenhagen
d for frameworks qt5 has an equivalent macro. - Oswald Buddenhagen On Jan. 31, 2012, 8:58 p.m., Allen Winter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: RFC: i18n: strict translation call-to-catalog mapping

2012-04-06 Thread Oswald Buddenhagen
On Fri, Apr 06, 2012 at 10:45:30AM +0200, Chusslove Illich wrote: > > [: Oswald Buddenhagen :] > > even small inefficiencies add up, so a functionally equivalent but > > more efficient solution is generally preferable. > > You have got to be kidding me. [...] > if

Re: RFC: i18n: strict translation call-to-catalog mapping

2012-04-05 Thread Oswald Buddenhagen
On Thu, Apr 05, 2012 at 12:14:35PM +0200, Chusslove Illich wrote: > > scripty should make reports and bug the respective maintainers when > > strings do not comply with some minimum disambiguation criteria (these > > could be statistically determined). > > Krazy has been doing this for several yea

Re: RFC: i18n: strict translation call-to-catalog mapping

2012-04-04 Thread Oswald Buddenhagen
On Wed, Apr 04, 2012 at 09:25:10PM +0200, Thomas Zander wrote: > On Wednesday 04 April 2012 21.11.22 Chusslove Illich wrote: > > > First, any Qt tr call has a context (typically the class name), am I > > > correct that i18n() still does the same thing? > > > > It doesn't: context is added manually

Re: RFC: i18n: drop KUIT tags in KDE Frameworks 5.0?

2012-03-23 Thread Oswald Buddenhagen
On Fri, Mar 23, 2012 at 04:28:52PM +0100, Chusslove Illich wrote: > It occured to me that I could examine usage-over-time statistics, since KDE > 4.0. Here is the percentage of strings in core (SC) modules containing KUIT > markup, [...] > > 2012-01-010.60% > i would find this number way mo

Re: resolving i18n merge conflicts, is there a policy fot i18n commits?

2012-03-16 Thread Oswald Buddenhagen
On Wed, Mar 14, 2012 at 08:53:07AM +0100, Thomas Lübking wrote: > Am 14.03.2012, 08:40 Uhr, schrieb Oswald Buddenhagen : > > >On Tue, Mar 13, 2012 at 11:45:56PM +0100, Thomas Lübking wrote: > >>Is there any policy on i18n commits/conflicts, ie. like only 4.8 is up to >

Re: resolving i18n merge conflicts, is there a policy fot i18n commits?

2012-03-14 Thread Oswald Buddenhagen
On Tue, Mar 13, 2012 at 11:45:56PM +0100, Thomas Lübking wrote: > Is there any policy on i18n commits/conflicts, ie. like only 4.8 is up to > date (seems to me?) so one can safely > git merge -Xtheirs origin/KDE/4.8 > what exactly are you merging?

Re: Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-11 Thread Oswald Buddenhagen
On March 9, 2012, 11:31 a.m., George Kiagiadakis wrote: > > When there are no objections, I suggest to apply this to master to get more > > testing. Crash reporting does not work right now, so there is nothing that > > could break. > > > > If possible, this should also be committed to 4.7 bran

Re: Review Request: Prevent KConfigGroup::revertToDefault from marking the kconfig as dirty if there's nothing to do

2011-11-17 Thread Oswald Buddenhagen
ldn't tell now). and of course i don't like your inefficient little hack. what did you expect? ;-P when we are clear on the wanted semantics and you cannot figure out how to do it right i can help you, but i'll have to start almost from scratch, too. - Oswald Buddenhagen O

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-23 Thread Oswald Buddenhagen
> On Oct. 23, 2011, 4:22 p.m., Ralf Jung wrote: > > Any news? Can I ship this (simplified) version of the original request? in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than that. - Oswald ---

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Oswald Buddenhagen
On Thu, Oct 13, 2011 at 06:27:45PM -0400, Steven Sroka wrote: > >On 13 October 2011 16:53, Ralf Jung wrote: > >> No tabs, 4 spaces instead. > >> > >> http://techbase.kde.org/Policies/Kdelibs_Coding_Style > > Almost the complete main.cpp is using tabs currently (except for > > KCMUserAccount::decod

Re: Security Audit Request for Screenlocker Branch

2011-10-13 Thread Oswald Buddenhagen
gt; covered by the compositor (but that's a tech. detail about "broken" > screensavers) by initially wiping the scene and then only painting the > locker/greeter > right, i only thought about initial blanking. so the effect would explicitly black out all translucent areas o

Re: Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Oswald Buddenhagen
On Wed, Oct 12, 2011 at 04:47:54PM +0200, Dario Freddi wrote: > 2011/10/12 Martin Gräßlin : > > ok I have been thinking about it and have a new proposal: > > * writing a kded module to only handle the screen locking (grab keyboard and > > mouse) > > TBH, if you really care about not making the thi

Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Oswald Buddenhagen
On Tue, Oct 11, 2011 at 06:30:40PM +0200, Martin Gräßlin wrote: > On Tuesday 11 October 2011 17:34:10 Oswald Buddenhagen wrote: > > on a more serious note, [h]ow do you handle the lock grace time? > > this is actually not affected by the changes. Dim Display and turning off th

Re: Security Audit Request for Screenlocker Branch

2011-10-11 Thread Oswald Buddenhagen
On Tue, Oct 11, 2011 at 03:55:15PM +0200, Thomas Lübking wrote: > Am Tue, 11 Oct 2011 15:33:39 +0200 schrieb Torgny Nyblom : > > Does this mean that I will be focred to use a screensaver with > > password unlock? If so why is that not a vaild usecase? It's what I > > use at home all the time. > >

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-09 Thread Oswald Buddenhagen
whitespace addition and stick to the kdelibs coding style where it would not stick out from the surrounding code. i'm not happy about lumping the addition of the reset button into the same commit. see http://techbase.kde.org/Policies/SVN_Commit_Policy#Commit_complete_changesets f. - Oswald Budden

Re: The future of Power Management - together with Activities

2011-10-06 Thread Oswald Buddenhagen
On Sat, Oct 01, 2011 at 08:33:06PM +0300, Andras Mantia wrote: > What I can say that I use the selection combo between the different > power management schemes from time to time, as I can do the same thing > (e.g developing so not anything like now I develop and then switch to > mail reading/wa

  1   2   >