Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

username and > password. Our problem, on Apple OS X, is that none of Dr K works ATM if your > browser of choice is Safari or Firefox or even Konqueror, because the cookies > are stored somewhere that is not the KCookieJar. Maybe the Qt guys solved > this problem somewhere, e.g. wh

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

get the next backtrace entry > if past last entry > return > re-format the line from "text" > > I would have used something like that in my patch, but I do not know > enough about the format of backtrace data to get t

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > <https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481> > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > N

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

get the next backtrace entry > if past last entry > return > re-format the line from "text" > > I would have used something like that in my patch, but I do not know > enough about the format of backtrace data to get t

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > <https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481> > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > N

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

get the next backtrace entry > if past last entry > return > re-format the line from "text" > > I would have used something like that in my patch, but I do not know > enough about the format of backtrace data to get t

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow o

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > <https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481> > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > N

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? Nope. It can be set if the user has XQuartz installed and running, but that sho

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

f time on this review! > > With the Randa sprint coming up soon (and hopefully lots of KDE apps > porting being done), I would suggest that the Porting Notes get re-read in > their entirety by the authors and updated soon, to catch this and any other > missing bits, if that

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 286 > > > > > > #ifndef > > Ian Wadham wrote: > No, #ifdef. The lines following 286 apply to Apple OS

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

ssh -X from > another machine, then start one app (which wasn't running in the main > session). > What happens then is that another kdeinit4 starts, in that separate > session (which has a separate dbus session). So it should all be separate > from the main sessi

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 28, 2014, 2:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been tested

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

ot the OS (ie. if you're running X11 on Darwin) > > > > Proper check would likely be Q_WS_MAC (though ultimately Q_WS > > disappeared with Qt5 anyway) > > RJVB Bertin wrote: > A bit of a moot point given how Qt4 no longer builds for X11 (since 4.4 I

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

ot the OS (ie. if you're running X11 on Darwin) > > > > Proper check would likely be Q_WS_MAC (though ultimately Q_WS > > disappeared with Qt5 anyway) > > RJVB Bertin wrote: > A bit of a moot point given how Qt4 no longer builds for X11 (since 4.4 I

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

ot the OS (ie. if you're running X11 on Darwin) > > > > Proper check would likely be Q_WS_MAC (though ultimately Q_WS > > disappeared with Qt5 anyway) > > RJVB Bertin wrote: > A bit of a moot point given how Qt4 no longer builds for X11 (since 4.4 I

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

On July 14, 2014, 8:15 p.m., Marko Käning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119243/ > ---

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1)

privilege problem DrKonqi runs into? Also, it'd probably be useful to modify the RR titles to include the name of the component(s) they include patches for ... - RJVB Bertin On July 27, 2014, 5:25 a.m., Ian Wadham wrote: > > ---

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

to search. Apple > and MacPorts have their own ways of squirelling things away. > > RJVB Bertin wrote: > That would have to be in $KDEDIR/share/config/kdeglobals I guess > > Ian Wadham wrote: > No, it is not there. UnifiedTitleAndToolBarOnMac seems to be an inte

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119243/ > --- > > (Updated July 14, 2014, 6:15 p.m.) > > > Review request for KDE Software on Mac OS X,

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62184 --- On July 14, 2014, 6:15 p.m., Marko Käning wrote: > > ---

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

reply, visit: > https://git.reviewboard.kde.org/r/119243/ > --- > > (Updated July 14, 2014, 6:15 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs, Christoph Feck, Ian > Wadham, and RJVB Bertin. > > > Bugs: 337356 >