Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kdeui/util/kcrash.cpp, line 316 > > > > > > is libdispatch OSX only or is it also used on FreeBSD? > > > > The question (more to Michael ;-) is wh

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 15, 2014, 1:03 p.m.) Review request for KDE Software on Ma

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote: > > I cannot see how "static void setTextWithCorrectMenuRole()" could work in > > all languages. > > > > Does not the "text" parameter come translated into the user's language, not > > necessarily English? So how can the ".contains" checks work

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote: > > I cannot see how "static void setTextWithCorrectMenuRole()" could work in > > all languages. > > > > Does not the "text" parameter come translated into the user's language, not > > necessarily English? So how can the ".contains" checks work

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 188 > > > > > > given KAction, KMenu and KMenuBar are all deprecated in KF5, is this > > actually of any upstream relevan

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 174 > > > > > > this is *utterly* wrong - you're manipulating a QAction reference just > > because it (at this very time!)

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 174 > > > > > > this is *utterly* wrong - you're manipulating a QAction reference just > > because it (at this very time!)

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

On Tuesday September 16 2014 11:31:30 Ian Wadham wrote: > The socket name is generated in 3 or 4 places, I am not sure how many. All of > these must "line up" if KCrash, kdeinit4, klauncher, kded4 and kwrapper are > to run as and when required and interact correctly on Apple OS X. And I am > no

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 17, 2014, 7:48 p.m.) Review request for KDE Software on Ma

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you rat

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/notifications/kstatusnotifieritem.cpp, lines 728-730 > > > > > > What is this used for? > > If it is not used, please remove it, otherwise just in

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you rat

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- Review request for KDE Software on Mac OS X and kde-workspace. Repository

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 19, 2014, 8:40 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 581 > > > > > > Xlib call? > > > > Why do you "need" krdb at all? > > (gtk+ & Qt should align to OSX anyway and

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 19, 2014, 8:40 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 581 > > > > > > Xlib call? > > > > Why do you "need" krdb at all? > > (gtk+ & Qt should align to OSX anyway and

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 19, 2014, 10:43 p.m.) Review request for KDE Software on M

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote: > > overall I rather tend to -1 for these changes. I consider changing the > > build system in a long term release as way too risky considering that the > > core development doesn't use this iteration any more. Any unintended > > breakage

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, lines 544-548 > > > > > > this looks like an inintended change > > René J.V. Bertin wrote: > No, I often do this when condit

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 12:05 a.m.) Review request for KDE Software on M

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > You added APPLE to the if() but not always to the matching endif()... True. But that's optional, no? - René J.V. --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > You added APPLE to the if() but not always to the matching endif()... > > René J.V. Bertin wrote: > True. But that's optional, no? On Saturday September 20 2014, Rolf Eike Beer wrote regarding "Re: Review Request 120287: [OS X] mak

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67024 --- While we're discussing krdb's function on non-X11 systems: I

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces I looked into those yesterday, and cannot find tabs on my end. No idea where they

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline Ah, the famous German rigor ... is this really an issue, shouldn't that empty line have been t

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:25 a.m., René J.V. Bertin wrote: > > While we're discussing krdb's function on non-X11 systems: > > > > I seem to recall that the colour theme selector kcm had an effect like it > > has under X11: applying the new theme to running applications instantly. I > > can no lo

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find t

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 12:51 p.m.) Review request for KDE Software on M

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 12:54 p.m.) Review request for KDE Software on M

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 12:53 p.m.) Review request for KDE Software on M

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find t

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find t

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 2:29 p.m., Martin Gräßlin wrote: > > kcontrol/CMakeLists.txt, lines 45-48 > > > > > > so what's the point of the if now? > > > > We have: > > * Windows > > * Apple > > * L

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 2:52 p.m.) Review request for KDE Software on Ma

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Sept. 21, 2014, 6:40 p.m.) Review request for KDE Software on Ma

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 21, 2014, 1:53 p.m., Gilles Caulier wrote: > > Martin, > > > > Since this file is openn, you can considerate this entry as obsolete : > > > > https://git.reviewboard.kde.org/r/112991/ Gilles, you seemed to have issues with the standard 'macintosh' Qt theme for digikam's GUI. What's

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120319/ --- Review request for Kate, KDE Software on Mac OS X and kdelibs. Repository

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 22, 2014, 6:17 p.m.) Review request for KDE Software on Ma

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > I assume you did not want to include those debug messages in > > qguiplatformplugin_kde.cpp? Oooops, no ... > On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 249 > >

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 249 > > > > > > just as a note: kinfocenter shold(tm) work on macos. at least there is > > a source file called info_osx.cpp > > Re

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

> On Sept. 23, 2014, 5:01 p.m., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue with inertial scrolling on X11 as well > > https://b

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 24, 2014, 5 p.m.) Review request for KDE Software on Mac O

Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- Review request for KDE Software on Mac OS X, KDE Runtime and kdelibs. Rep

Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- Review request for KDE Base Apps, KDE Software on Mac OS X and kdelibs. R

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 24, 2014, 7:23 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote: > > Please watch coding style and please also have a look at the frameworks > > variant. It still needs porting to MacOS *hint,hint* and that would be > > very, very appreciated. I recently sent a mail to frameworks-devel > > concerning mov

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) I agree totally, but for that - I'd have to understand exactly wha

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Sept. 25, 2014, 3:58 p.m.) Review request for KDE Software on Ma

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Sept. 25, 2014, 4 p.m.) Review request for KDE Base Apps, KDE So

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:02 p.m.) Review request for KDE Software on Ma

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 25, 2014, 4:03 p.m.) Review request for KDE Software on Ma

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195/ --- (Updated Sept. 25, 2014, 4:06 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 4:58 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 4:10 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, line 28 > > > > > > it's obvious that the include is needed, otherwise one wouldn't add it. > > I think that comment is not adding

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 5:22 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 25, 2014, 6:14 p.m.) Review request for KDE Software on Ma

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

> On Sept. 25, 2014, 5:58 p.m., Martin Gräßlin wrote: > > kglobalaccel/main.cpp, lines 48-55 > > > > > > now there are two deleted lines... My bad, I could so hardly believe that one might want 2 empty lines ther

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120354: [OS X] turn kglobalaccel into an "agent", removing it from Dock and application switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/ --- (Updated Sept. 26, 2014, 12:13 p.m.) Status -- This change has been

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

> On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: > > Aside Thiagos concern, what actually causes the menubar/docker item stuff? > > > > Quoting QApplication (4.8): > > > On X11, the window system is initialized if GUIenabled is true. If > > > GUIenabled is false, the application does not c

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Sept. 26, 2014, 7:28 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/#review67495 --- changing this patch to prevent just the call to invalidateBuff

  1   2   3   4   >