Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread TOM Harrison via Review Board
h. Diffs - kcms/hardware/joystick/joywidget.cpp 6007d867 Diff: https://git.reviewboard.kde.org/r/130245/diff/1/ Testing --- Thanks, TOM Harrison

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-20 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-18 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-17 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
WidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow? > > TOM Harrison wrote: > no, It still NULL after that. > > I think because "btnx keyboard" is not a real joystic

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 ------- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > >

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
p 6007d867 Diff: https://git.reviewboard.kde.org/r/130245/diff/1/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-08-20 Thread TOM Harrison
: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
the diff are always error. I have upload successfully with the newest fixed patch - TOM Harrison On July 29, 2014, 3:24 p.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
(updated) --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
(updated) --- I will fix it soon. something wrong with the patch. Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
/ Testing --- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? > > Sebastian Kügler wrote: > Yes, don't use tabs at all for code indentation, use 4 spaces. It should > look consistent w

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
view62779 --- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) &

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
--- Thanks, TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review59300 --- On June 3, 2014, 5:58 a.m., TOM Harrison wrote: > > ---

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
> On None, TOM Harrison wrote: > > Ship It! wrong click:( - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#re

Re: Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
--- Thanks, TOM Harrison

Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
/118180/diff/ Testing --- Thanks, TOM Harrison