Re: ELF Dissector in kdereview

2019-10-30 Thread Jonathan Riddell
Yay it's green! https://build.neon.kde.org/view/3%20unstable%20%E2%98%A3%20git%20master/job/bionic_unstable_neon-packaging_elf-dissector/ On Wed, 30 Oct 2019 at 17:30, Volker Krause wrote: > This one probably even affects all 32bit builds with Capstone available, > not > just ARM. I've pushed a

Re: ELF Dissector in kdereview

2019-10-30 Thread Jonathan Riddell
On Wed, 30 Oct 2019 at 10:02, Jonathan Riddell wrote: > That seems to have worked, it's moved onto the next 32-bit error > > > https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissector_bin_armhf/8/console > > src/lib/disassmbler/disassembler.cpp:228:65: error: cannot convert ‘ui

Re: ELF Dissector in kdereview

2019-10-29 Thread Volker Krause
I haven't recently tested it on 32bit ARM, I pushed a possible fix using a similar approach that has been applied for x86 already. If that doesn't help I need to find a 32bit ARM setup again here to properly debug it. Regards, Volker On Tuesday, 29 October 2019 11:29:44 CET Jonathan Riddell wro

Re: ELF Dissector in kdereview

2019-10-29 Thread Jonathan Riddell
I'm getting a build failure for this on 32-bit arm https://build.neon.kde.org/job/bionic_unstable_neon-packaging_elf-dissector_bin_armhf/7/console disassembler.cpp:149:34: error: ‘print_insn_little_arm’ was not declared in this scope Is it expected to build on this architecture? It builds fine

Re: ELF Dissector in kdereview

2019-10-27 Thread Volker Krause
Thanks again for the feedback, this has now been moved to extragear/sdk. On Saturday, 28 September 2019 13:01:11 CET Volker Krause wrote: > Hi, > > ELF Dissector has been moved to kdereview for the usual review process. > > https://phabricator.kde.org/source/elf-dissector/ > > ELF Dissector is

Re: ELF Dissector in kdereview

2019-10-20 Thread Christophe Giboudeaux
Hello, Minor issue with the license file. COPYING.LIB contains the LGPL 2.1 license text while elf-dissector is LGPL-2.0-or-later COPYING has a few differences compared to https://www.gnu.org/licenses/old-licenses/gpl-2.0-standalone.html. Does it come from treemap?

Re: ELF Dissector in kdereview

2019-10-19 Thread Volker Krause
On Thursday, 17 October 2019 23:31:32 CEST Christophe Giboudeaux wrote: > Hello, > > Minor issue with the license file. COPYING.LIB contains the LGPL 2.1 license > text while elf-dissector is LGPL-2.0-or-later > > COPYING has a few differences compared to > https://www.gnu.org/licenses/old-licens

Re: ELF Dissector in kdereview

2019-10-16 Thread Volker Krause
On Saturday, 12 October 2019 13:56:12 CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 12. Oktober 2019, 12:46:19 CEST schrieb Volker Krause: > > From the feedback everything should be addressed, apart from the following: > ... > * "hicolor" icons for the app icon are not yet added & installed >

Re: ELF Dissector in kdereview

2019-10-12 Thread Friedrich W. H. Kossebau
Am Samstag, 12. Oktober 2019, 12:46:19 CEST schrieb Volker Krause: > From the feedback everything should be addressed, apart from the following: ... * "hicolor" icons for the app icon are not yet added & installed (proposal: copy over the breeze ones for now, like done for e.g. heaptrack) Cheers

Re: ELF Dissector in kdereview

2019-10-12 Thread Volker Krause
Thanks for the feedback so far! This has reached the two week mark, if there are no objections I'd move this to extragear/sdk next week. >From the feedback everything should be addressed, apart from the following: - blog: will be done for the release, last one on that subject is https:// volkerk

Re: ELF Dissector in kdereview

2019-10-01 Thread Volker Krause
On Tuesday, 1 October 2019 14:06:57 CEST Jonathan Riddell wrote: > The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the > application is LGPL. This makes the whole application copyable under only > the terms of the GPL. It would be good to have COPYING moved to > COPYING.LIB and

Re: ELF Dissector in kdereview

2019-10-01 Thread Volker Krause
On Tuesday, 1 October 2019 17:28:03 CEST Thiago Macieira wrote: > On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > > -isystem > > /usr/include/capstone/.. > > [...] > > > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > > directory > > That -isystem is

Re: ELF Dissector in kdereview

2019-10-01 Thread Michael Reeves
On Tue, Oct 1, 2019, 7:24 AM Elv1313 . wrote: > Hello, > > This tool looks very useful. I am wondering if the Qt 5.11 requirement > isn't a bit overkill given only 2 lines of code require it (git grep > "horizontalAdvance"; > See kdiff3 for the old name of this method. That will work at least to

Re: ELF Dissector in kdereview

2019-10-01 Thread Elv1313 .
> I couldn't compile it, I get The hack for this is to replace all `-isystem` by `-I` in /usr/lib/x86_64-linux-gnu/qt5/mkspecs/ using `sed -i`. However, right, it didn't compile for me either. On Tue, 1 Oct 2019 at 05:07, Jonathan Riddell wrote: > The file src/3rdparty/treemap/treemap.cpp is GP

Re: ELF Dissector in kdereview

2019-10-01 Thread Thiago Macieira
On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > -isystem > /usr/include/capstone/.. [...] > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > directory That -isystem is the mistake. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org

Re: ELF Dissector in kdereview

2019-10-01 Thread Jonathan Riddell
The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the application is LGPL. This makes the whole application copyable under only the terms of the GPL. It would be good to have COPYING moved to COPYING.LIB and a GPL text put in COPYING. src/ui/org.kde.elf-dissector.appdata.xml shou

Re: ELF Dissector in kdereview

2019-10-01 Thread Elv1313 .
Hello, This tool looks very useful. I am wondering if the Qt 5.11 requirement isn't a bit overkill given only 2 lines of code require it (git grep "horizontalAdvance"; using the boundingRect can do something close enough) and this version of Qt isn't very common in major LTS distributions. With th

Re: ELF Dissector in kdereview

2019-09-30 Thread Dominik Haumann
Hi Volker, may I suggest that you also blog about this at some point in time? :-) I know this is additional work (sorry), but it helps a lot visibility wise. This blog can then be posted at reddit/r/linux et al... Best regards Dominik On Sat, Sep 28, 2019 at 1:03 PM Volker Krause wrote: > Hi,

Re: ELF Dissector in kdereview

2019-09-30 Thread Volker Krause
Thanks for the feedback :) On Sunday, 29 September 2019 12:51:03 CEST Albert Astals Cid wrote: > El dissabte, 28 de setembre de 2019, a les 13:01:11 CEST, Volker Krause va escriure: > > Hi, > > > > ELF Dissector has been moved to kdereview for the usual review process. > > It doesn't build for

Re: ELF Dissector in kdereview

2019-09-29 Thread Albert Astals Cid
El dissabte, 28 de setembre de 2019, a les 13:01:11 CEST, Volker Krause va escriure: > Hi, > > ELF Dissector has been moved to kdereview for the usual review process. > It doesn't build for me, i need -#include +#include Because my include is in /usr/include/capstone/capstone.h and pk

ELF Dissector in kdereview

2019-09-28 Thread Volker Krause
Hi, ELF Dissector has been moved to kdereview for the usual review process. https://phabricator.kde.org/source/elf-dissector/ ELF Dissector is a static analysis tool for ELF libraries and executables, for doing things like inspecting forward and backward dependencies (on a library or symbol le