Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-30 Thread Matthias Fuchs
On 2010-11-29 00:08:22, Albert Astals Cid wrote: Why did you change the if/else logic? Also you added another kError when there was an existing one already. Also as commented on IRC maybe it would make sense to emit a signal to warn whoever might be interested that an error

Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-30 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- (Updated 2010-11-30 20:57:03.986026) Review request for kdelibs and David

Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-28 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- Review request for kdelibs and David Faure. Summary --- Adds method to

Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-28 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/#review9021 --- one tiny thing: calling it setDialogsAllowed would be clearer

Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-28 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- (Updated 2010-11-28 21:00:30.131444) Review request for kdelibs and David