Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-09-05 Thread Vadim Zhukov
04.09.2012 1:08 пользователь "Michael Pyne" написал: > > This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ > > I think I've figured out the issue with the missing files. The review request is indeed based against master, which isn't a big problem.

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-09-03 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18473 --- I think I've figured out the issue with the missing files. The

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-28 Thread Michael Pyne
> On Aug. 26, 2012, 9:35 p.m., Michael Pyne wrote: > > I've looked over everything and didn't see anything I didn't like. I'd like > > to apply and and compile and run what little test cases do exist, but > > git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake > > don't e

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-27 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- (Updated Aug. 27, 2012, 6:54 p.m.) Review request for kdelibs and Michael

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-27 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- (Updated Aug. 27, 2012, 5:10 p.m.) Review request for kdelibs and Michael

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-27 Thread Vadim Zhukov
> On Aug. 27, 2012, 3:57 p.m., Alexander Neundorf wrote: > > Why do you want to do this ? > > > > Beside that, you are using CMakePushCheckState.cmake, which is part of > > cmake only since version 2.8.6. > > trunk still requires cmake 2.6.4, so this is not allowed, use > > MacroPushrequiredVa

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-27 Thread Vadim Zhukov
> On Aug. 26, 2012, 9:35 p.m., Michael Pyne wrote: > > I've looked over everything and didn't see anything I didn't like. I'd like > > to apply and and compile and run what little test cases do exist, but > > git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake > > don't e

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-27 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18113 --- Why do you want to do this ? Beside that, you are using CMakeP

Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-26 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- Review request for kdelibs and Michael Pyne. Description --- This pat

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18055 --- I've looked over everything and didn't see anything I didn't li