Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-11-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/#review8055 --- This review has been submitted with commit

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-24 Thread Ralf Jung
On Oct. 23, 2011, 4:22 p.m., Ralf Jung wrote: Any news? Can I ship this (simplified) version of the original request? Oswald Buddenhagen wrote: in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than that.

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-23 Thread Oswald Buddenhagen
On Oct. 23, 2011, 4:22 p.m., Ralf Jung wrote: Any news? Can I ship this (simplified) version of the original request? in qt review terms, you get a +1 from me. this code is pretty much unmaintained, so it's unlikely that you'll get more feedback than that. - Oswald

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-14 Thread Ralf Jung
Hi, No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style Almost the complete main.cpp is using tabs currently (except for KCMUserAccount::decodeImgDrop, which uses 2 spaces) so I used it for the two lines I added. Is that okay, or am I supposed to use 4 spaces

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/ --- (Updated Oct. 12, 2011, 4:55 p.m.) Review request for KDE Base Apps.

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Steven Sroka
No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style On 12 October 2011 12:55, Ralf Jung ralfjun...@gmx.de wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/ Review request for KDE Base Apps. By Ralf

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Steven Sroka
On 13 October 2011 16:53, Ralf Jung ralfjun...@gmx.de wrote: Hi, No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style Almost the complete main.cpp is using tabs currently (except for KCMUserAccount::decodeImgDrop, which uses 2 spaces) so I used it for the two

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-13 Thread Oswald Buddenhagen
On Thu, Oct 13, 2011 at 06:27:45PM -0400, Steven Sroka wrote: On 13 October 2011 16:53, Ralf Jung ralfjun...@gmx.de wrote: No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style Almost the complete main.cpp is using tabs currently (except for

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-09 Thread Ralf Jung
On Oct. 8, 2011, 10:48 p.m., Gary L. Greene Jr wrote: As someone that works with NFS home directory systems with autofs much of the time, I find the use of an icon in the users home directory (especially on default configurations that tend to display many users on KDM) a very bad

Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-07 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/ --- Review request for KDE Base Apps. Description --- Currently, the