Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 11:47 p.m., Chao Feng wrote: > > Screenshot: chinese after change > > > > > > Others looks good, I still think here it looks strange. Increase to 7 > > characters? Increase to 7 characters will only make 8 the number of characters in the

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25205 --- Screenshot: chinese after change

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 11:47 p.m., Chao Feng wrote: > > Screenshot: chinese after change > > > > > > Others looks good, I still think here it looks strange. Increase to 7 > > characters? > > Yichao Yu wrote: > Increase to 7 characters will only make 8 the n

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 8:48 p.m.) Review request for kde-workspace, Ben C

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 6:12 p.m., Thomas Lübking wrote: > > systemsettings/icons/IconMode.cpp, line 182 > > > > > > should this not rely on the icon size rather than on the fontmetrics > > (only)? > > The point

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 6:13 p.m., Thomas Lübking wrote: > > Screenshot: spanish after change > > > > > > Is "gest..." elided before the patch as well? (got no es locales > > installed) Yes.. I choose es as example here since I know es string is usually longer t

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 8:47 p.m.) Review request for kde-workspace, Ben C

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 6:09 p.m.) Review request for kde-workspace, Ben C

Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, a

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25179 --- Screenshot: spanish after change

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25177 --- systemsettings/icons/FileItemDelegate.cpp