Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-14 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/ --- (Updated Oct. 13, 2011, 5:59 p.m.) Review request for kdelibs, Andreas Har

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/#review7302 --- This review has been submitted with commit 3be117c3007aadde359d

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/#review7299 --- Ship it! No objections from me either. I confused the iteratat

R: Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-13 Thread aiacovi...@libero.it
>> Testing >> --- >> >> -Patched code compiles >> -Hacked a web server and made tests against following keep-alive header >> variants: >> "Keep-Alive: timeout=5, max=99" >> "Keep-Alive: Timeout=5, max=99" (uppercase 'T') >> "Keep-Alive: Timeout=5 , max=99"(extra space before comma) >

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-13 Thread Andrea Iacovitti
> On Oct. 12, 2011, 5:55 a.m., Dawit Alemayehu wrote: > > kioslave/http/http.cpp, line 3107 > > > > > > This seems unnecessary to me since the parser produces a lower case > > token to begin with. hmm... i did mo

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-12 Thread Andreas Hartmetz
> On Oct. 12, 2011, 10:58 p.m., Andreas Hartmetz wrote: > > kioslave/http/http.cpp, line 3107 > > > > > > I guess the parser just lowercases the key ("keep-alive"), not the > > values. Lowercasing the keys is okay

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-12 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/#review7283 --- Ship it! kioslave/http/http.cpp

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/#review7251 --- kioslave/http/http.cpp

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-11 Thread Rolf Eike Beer
> Testing > --- > > -Patched code compiles > -Hacked a web server and made tests against following keep-alive header > variants: > "Keep-Alive: timeout=5, max=99" > "Keep-Alive: Timeout=5, max=99" (uppercase 'T') > "Keep-Alive: Timeout=5 , max=99"(extra space before comma) I don't k

Review Request: kio_http: fix keepalive timeout parsing

2011-10-11 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/ --- Review request for kdelibs, Andreas Hartmetz and Dawit Alemayehu. Descript