Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- Review request for KDE Runtime and KDE Frameworks. Description --- Th

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39205 --- kioslave/CMakeLists.txt

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39463 --- I have several changes coming to this ioslave. Mainly I am goin

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: > > I have several changes coming to this ioslave. Mainly I am going to > > implement the copyFrom and copyTo optimizations like I did for the sftp > > ioslave and add support for upload/download resumptions. The changes are > > going to co

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: > > I have several changes coming to this ioslave. Mainly I am going to > > implement the copyFrom and copyTo optimizations like I did for the sftp > > ioslave and add support for upload/download resumptions. The changes are > > going to co

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review44515 --- It's been stalled for almost three months now, any chance to se

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? No, it should most certainly not be disgarded. It was even working when i posted this post up for review. Dawit, how are you doing in

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? > > Mark Gaiser wrote: > No, it should most certainly not be disgarded. It was even working when i > posted this post up for revie

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? > > Mark Gaiser wrote: > No, it should most certainly not be disgarded. It was even working when i > posted this post up for revie

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 1, 2013, 9:32 p.m.) Review request for KDE Runtime and KDE F

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

Bump. Can anyone look at this? On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112463/ > Review request for KDE Runtime and KDE Frameworks. > By Mark Gaiser. > > *Updated Dec. 1, 2013, 9:3

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45140 --- kioslave/smb/kio_smb.cpp

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 5, 2013, 11:44 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112463/ > Review request for KDE Runtime and KDE Frameworks. > By Mark Gaiser. > > *Updated Dec. 5, 2013, 11:44 p.m.* >

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45467 --- If there are further objections/feedback, please share them. If

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45466 --- kioslave/smb/CMakeLists.txt

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: > > kioslave/smb/kio_smb_internal.cpp, line 68 > > > > > > Does it really need QDir::separator()? It seems to me like everything > > should be '/'. "could"

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: > > kioslave/smb/kio_smb_auth.cpp, line 76 > > > > > > A > > > > xD > > Maybe we can just remove this one? > > Mark Gaiser wrote: >

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m., M

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45522 --- This review has been submitted with commit 728309ac2a80cab8feb

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 11, 2013, 1:45 a.m.) Status -- This change has been mar