Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-16 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/ --- (Updated Jan. 16, 2014, 6:06 p.m.) Status -- This change has been di

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Hrvoje Senjan
> On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote: > > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5? > > Thomas Lübking wrote: > On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote: > > Yes it would. There can be only one kglobalaccel. If its f

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Hrvoje Senjan
> On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote: > > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5? > > Thomas Lübking wrote: > On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote: > > Yes it would. There can be only one kglobalaccel. If its f

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Thomas Lübking
> On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote: > > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5? On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote: > Yes it would. There can be only one kglobalaccel. If its from kde4 or kde4 > shouldn't matter s

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Michael Jansen
> > > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5? > > - Martin Gräßlin > Yes it would. There can be only one kglobalaccel. If its from kde4 or kde4 shouldn't matter so it HAS to keep dbus compatibility.

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/#review47339 --- Wouldn't that break KDElibs4 applications talking to kglobalac

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/#review47338 --- given that the framework installs into KF5GlobalAccel and has

Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/ --- Review request for kde-workspace and Martin Klapetek. Repository: kde-wor