Review Request 115408: Right align mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- Review request for kdelibs. Repository: kdelibs Description --- Th

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- tried to center align it? - Thomas Lübking On Jan. 30, 2014

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as the icon of the icon button. I tried b

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated Jan. 31, 2014, 8:47 p.m.) Review request for kdelibs. Reposito

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48738 --- kio/kfile/kpropertiesdialog.cpp

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Feb. 1, 2014, 10:41 a.m., Kai Uwe Broulik wrote: > > kio/kfile/kpropertiesdialog.cpp, line 892 > > > > > > It also helped a lot if the icon size adjusted to pixel density of the > > screen / font dpi I am

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Feb. 1, 2014, 10:41 a.m., Kai Uwe Broulik wrote: > > kio/kfile/kpropertiesdialog.cpp, line 892 > > > > > > It also helped a lot if the icon size adjusted to pixel density of the > > screen / font dpi > > k

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated Feb. 7, 2014, 7:07 p.m.) Review request for kdelibs and Frank Re