Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- Review request for kde-workspace and Plasma. Repository: plasma-framework

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56577 --- src/declarativeimports/core/windowthumbnail.cpp

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 25, 2014, 11:44 p.m., Thomas Lübking wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > try before this call. Okay, just thought I'd exit early in that case and not bothe

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 25, 2014, 9:44 p.m., Thomas Lübking wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > try before this call. > > Alexander Richardson wrote: > Okay, just thought I'd

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 26, 2014, 12:51 a.m.) Review request for kde-workspace and

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56587 --- I'd rather not want to see us hide this crash. There is an und

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56707 --- did you notice any pattern which triggers the crash? That coul

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 28, 2014, 10:24 a.m., Martin Gräßlin wrote: > > did you notice any pattern which triggers the crash? That could help me to > > reproduce and find the root cause. I found the condition myself: 1. show thumbnail 2. let it hide again 3. show thumbnail for same task when switching to a

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 26, 2014, 8:22 a.m., Martin Gräßlin wrote: > > I'd rather not want to see us hide this crash. There is an underlying > > problem which needs a more proper fix. I recently hit this problem myself > > on one on my systems and a crash one can reproduce is as good as fixed ;-) fix for u

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 30, 2014, 2:21 p.m.) Status -- This change has been d