Re: Review Request 118180: slideshow BUG patch fix

2014-08-20 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63401 --- Reviewboard wasn't showing the patch, not sure why. We can't

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been

Re: Review Request 118180: slideshow BUG patch fix

2014-07-29 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Christoph Feck
On June 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. TOM Harrison wrote: that just a wrong click :) TOM Harrison wrote: thanks for reminding for the

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. TOM Harrison wrote: that just a wrong click :) TOM Harrison wrote: thanks for reminding for the

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --- libs/plasmagenericshell/backgrounddialog.cpp

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: what kind of issue? tab and space different ? - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Sebastian Kügler
On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote: TOM Harrison wrote: what kind of issue? tab and space different ? Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. - Sebastian

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: TOM Harrison wrote: what kind of issue? tab and space different ? Sebastian Kügler wrote: Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. OK, I

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62784 --- modulo the indentation, it should be ok - Marco Martin On

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 21, 2014, 1:12 p.m.) Review request for kde-workspace and

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62810 --- seems the patch doesn't apply anymore, at least reviewboard

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review59300 --- Please add Plasma developers to the group of reviewers. Btw,

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
On None, TOM Harrison wrote: Ship It! wrong click:( - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review58086

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
On June 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. that just a wrong click :) - TOM --- This is an

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 5, 2014, 10:32 a.m.) Review request for kde-workspace and

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
On June 5, 2014, 10:12 a.m., Christoph Feck wrote: Please add Plasma developers to the group of reviewers. Btw, you cannot give Ship It to yourself, others have to approve it. TOM Harrison wrote: that just a wrong click :) thanks for reminding for the missing reviewers. - TOM

Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- Review request for kde-workspace. Bugs:

Re: Review Request 118180: slideshow BUG patch fix

2014-06-02 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 3, 2014, 5:58 a.m.) Review request for kde-workspace.