Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review68692 --- I think this misses the "remember url as defaultStartDir and u

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- (Updated Oct. 19, 2014, 9:18 a.m.) Status -- This change has been ma

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review68690 --- Ship it! Sorry for the delay -- too many review requests

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-08-01 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- (Updated Aug. 1, 2014, 9:39 nachm.) Review request for kdelibs. Bugs: 9

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-15 Thread Simon Bachmann
> On Juli 15, 2014, 1:15 vorm., David Faure wrote: > > kio/kfile/kurlrequester.cpp, line 277 > > > > > > The notion of the "current path" in a GUI program (started graphically) > > makes little sense to me, but

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-14 Thread David Faure
> On July 9, 2014, 8:40 a.m., David Faure wrote: > > Looks good, but I'd feel safer if the unittest > > (kio/tests/kurlrequestertest.cpp) was: > > 1) checked for no regressions, and > > 2) extended to cover the case of relative paths, and other things this > > patch is fixing. > > Simon Bachma

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review62361 --- kio/kfile/kurlrequester.cpp

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-14 Thread Simon Bachmann
> On Juli 9, 2014, 10:40 vorm., David Faure wrote: > > Looks good, but I'd feel safer if the unittest > > (kio/tests/kurlrequestertest.cpp) was: > > 1) checked for no regressions, and > > 2) extended to cover the case of relative paths, and other things this > > patch is fixing. I need some he

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review61955 --- Looks good, but I'd feel safer if the unittest (kio/tests/kur

Review Request 119014: KUrlRequester: fixing handling of start directory

2014-06-29 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- Review request for kdelibs. Bugs: 92237 http://bugs.kde.org/show_bug.