---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Feb. 8, 2017, 12:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/#review102459
---
this is a kdelibs4 patch, not relevant anymore
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/#review71081
---
Is this not yet committed to KDE?
- Marko Käning
On Sept.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 25, 2014, 4:03 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 24, 2014, 5 p.m.)
Review request for KDE Software on Mac
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 15, 2014, 12:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 17, 2014, 7:48 p.m.)
Review request for KDE Software on
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/#review66764
---
Ship it!
Two general notes:
- please respect the kdelibs
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote:
Two general notes:
- please respect the kdelibs coding style, for example removing the extra
spaces in instructions
- please remove the extra kDebug
Oops, I accidentally checked Ship it!, while this is totally not the case
(rather, as
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/notifications/kstatusnotifieritem.cpp, lines 728-730
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312870#file312870line728
What is this used for?
If it is not used, please remove it, otherwise just include it
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 15, 2014, 12:19 nachm., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 188
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line188
given KAction, KMenu and KMenuBar are all deprecated in KF5, is this
actually of any upstream relevance?
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 174
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312033#file312033line174
this is *utterly* wrong - you're manipulating a QAction reference just
because it (at this very time!) hints it
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 15, 2014, 1:03 p.m.)
Review request for KDE Software on
On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote:
I cannot see how static void setTextWithCorrectMenuRole() could work in
all languages.
Does not the text parameter come translated into the user's language, not
necessarily English? So how can the .contains checks work with all
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/#review66546
---
In general coding style is systematically wrong ( if (a, not
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 188
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line188
given KAction, KMenu and KMenuBar are all deprecated in KF5, is this
actually of any upstream relevance?
I
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/widgets/kmenu.cpp, line 174
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312033#file312033line174
this is *utterly* wrong - you're manipulating a QAction reference just
because it (at this very time!) hints it
On Sept. 15, 2014, 12:19 nachm., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 164
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line164
would this eg. work with kwrite (Configure Editor...)? - or other
kpart driven things?
René J.V. Bertin wrote:
32 matches
Mail list logo