Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-19 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 19, 2014, 12:04 p.m.) Status -- This change has been

Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure,

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70516 --- Looks good to me. +1 Can you look into doing this in KF5

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70517 --- There's no master branch of kdelibs - Albert Astals Cid On

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:29 p.m.) Review request for kdelibs, Alex

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
On Nov. 17, 2014, 3:26 p.m., Aleix Pol Gonzalez wrote: Looks good to me. +1 Can you look into doing this in KF5 (ECM) as well? It's not applicable since we don't define `_BSD_SOURCE` at all there. It might even work to just remove this in KDE4 as well, but I don't want to have to test

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70519 --- Looks solid to me :-) +1 - Matthias Klumpp On Nov. 17,

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70520 --- This silences the following compile warnings with newer GCC

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:48 p.m.) Review request for kdelibs, Alex

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:48 p.m.) Review request for kdelibs, Alex

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70532 --- Ship it! Yep, after reading the feature_test_macros(7)