---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 19, 2014, 12:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70516
---
Looks good to me. +1
Can you look into doing this in KF5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70517
---
There's no master branch of kdelibs
- Albert Astals Cid
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:29 p.m.)
Review request for kdelibs, Alex
On Nov. 17, 2014, 3:26 p.m., Aleix Pol Gonzalez wrote:
Looks good to me. +1
Can you look into doing this in KF5 (ECM) as well?
It's not applicable since we don't define `_BSD_SOURCE` at all there. It might
even work to just remove this in KDE4 as well, but I don't want to have to test
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70519
---
Looks solid to me :-)
+1
- Matthias Klumpp
On Nov. 17,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70520
---
This silences the following compile warnings with newer GCC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:48 p.m.)
Review request for kdelibs, Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:48 p.m.)
Review request for kdelibs, Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70532
---
Ship it!
Yep, after reading the feature_test_macros(7)
11 matches
Mail list logo