Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? > > Thomas Lübking wrote: > +1, notably since http://

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? > > Thomas Lübking wrote: > +1, notably since http://

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 10, 2015, 3:31 a.m., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? > > Thomas Lübking wrote: > +1, notably since http://no

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? +1, notably since http://nonexistenfile won't be very hel

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75736 --- IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/ --- (Updated Feb. 9, 2015, 12:48 p.m.) Status -- This change has been ma

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 8, 2015, 9:31 a.m., Emmanuel Pescosta wrote: > > dolphin/src/main.cpp, line 109 > > > > > > The validation isn't needed anymore, because QUrl::fromUserInput always > > returns a valid url. (see QUrl do

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75655 --- dolphin/src/main.cpp

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 8, 2015, 2:01 p.m., Emmanuel Pescosta wrote: > > dolphin/src/main.cpp, line 109 > > > > > > The validation isn't needed anymore, because QUrl::fromUserInput always > > returns a valid url. (see QUrl do

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75583 --- Ship it! Thanks for the patch! :) dolphin/src/main.cpp

Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/ --- Review request for KDE Base Apps. Bugs: 343906 http://bugs.kde.org/sh