Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated June 5, 2016, 2:52 p.m.) Status -- This change has been mar

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review96149 --- Ship it! Do you have commit rights? - Martin Gräßlin On

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 20, 2016, 9:22 a.m.) Review request for kde-workspace and Pl

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95639 --- autotests/kfiledialog_unittest.cpp (lines 220 - 223)

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 18, 2016, 11:07 a.m.) Review request for kde-workspace and P

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. > > Jonathan Ma

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. > > Martin Gräßlin wrote: > ah now I see. You adjusted the test application, but not the autotest. Now I see that

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote: > > The test does not verify the problem. I just pulled the patch, undid your > > change, but the test passed nevertheless. ah now I see. You adjusted the test application, but not the autotest. - Martin ---

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95535 --- The test does not verify the problem. I just pulled the patch

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote: > > The change looks sensible to me, but I would appreciate a test case for it. > > There are already some tests for the file dialog, so it should be easy to > > extend. There is no autotest, but have updated tests/qfiledialogtest with option

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 17, 2016, 3:20 p.m.) Review request for kde-workspace and Pl

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95533 --- Ship it! This would fix https://bugs.kde.org/show_bug.cgi?

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95532 --- The change looks sensible to me, but I would appreciate a tes

Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- Review request for kde-workspace and Plasma. Bugs: 360666 https://bug