Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

2016-11-22 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129518/ --- (Updated Nov. 22, 2016, 3:20 a.m.) Status -- This change has been

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

2016-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129518/#review101036 --- Ship it! Indeed, you are completely right, sorry. I

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

2016-11-21 Thread Jonathan Marten
> On Nov. 21, 2016, 12:44 p.m., David Faure wrote: > > settings/konqhtml/generalopts.cpp, line 277 > > > > > > That is actually not fully correct anymore, any process making a trader > > query should get

Re: Review Request 129518: Konqueror: restore "Default web browser engine" setting

2016-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129518/#review101013 --- Fix it, then Ship it! Thanks!

Review Request 129518: Konqueror: restore "Default web browser engine" setting

2016-11-21 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129518/ --- Review request for KDE Base Apps and David Faure. Repository: konqueror