Review Request 115716: Ensure to not perform Xlib code if not on platform xcb in klauncher

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115716/ --- Review request for KDE Frameworks. Repository: kinit Description

X11 usage in kdeinit/kinit.cpp

2014-02-13 Thread Martin Gräßlin
Hi, on my quest to ensure that we can run all applications with -platform wayland if compiled with X11 support I stumbled over kinit/kdeinit/kinit.cpp which gets compiled into the kdeinit5 binary. To quote the code: // Can't use QGuiApplication::platformName() here, there is no app instance

Re: Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

2014-02-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/#review49701 --- Ship it! Ship It! - Marco Martin On Feb. 13, 2014, 6:53

Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-13 Thread Alex Merry
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , supporting vendor prefixes are not only a good idea, but is strongly encouraged. ... it is recommended that providers of desktop-files ensure that all desktop-file

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace,

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/#review49705 --- This review has been submitted with commit

Re: Review Request 115704: Comment out kio OpenSSL dependency checks

2014-02-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115704/ --- (Updated Feb. 13, 2014, 10:19 a.m.) Status -- This change has been

Review Request 115719: Move kio zlib dependency

2014-02-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115719/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115721/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/ --- Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-13 Thread Martin Gräßlin
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 13, 2014, 2:03 p.m.) Status -- This change has been

Review Request 115724: Drop version check for Qt at least being 4.7

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115724/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49709 --- Ship it! That seems like a reasonable compromise to me. I

Review Request 115725: Switch from yapgvb to Graphviz Python bindings

2014-02-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115725/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox

Re: Review Request 115683: Install app desktop files to share/applications, not in a kde5 subdir

2014-02-13 Thread Rex Dieter
On Feb. 13, 2014, 4:28 a.m., Rex Dieter wrote: fyi, http://standards.freedesktop.org/menu-spec/menu-spec-latest.html , supporting vendor prefixes are not only a good idea, but is strongly encouraged. ... it is recommended that providers of desktop-files ensure that all desktop-file

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 8:56 p.m.) Review request for Documentation, KDE

Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49738 --- Ship it! Just please consider the note below, then ship it!

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Christoph Feck
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: Making the type movable does not make QList store it directly, how did you check this? http://qt-project.org/doc/qt-5/qlist.html says: Internally, QListT is represented as an array of pointers to items of type T. If T is

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49747 --- src/core/kprotocolmanager.cpp

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49752 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review49751 --- This review has been submitted with commit

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/ --- (Updated Feb. 13, 2014, 10:37 p.m.) Status -- This change has been

Re: [error] Snapshot for krunner extracted successfully, but failed to complete initrepo.sh

2014-02-13 Thread Michael Pyne
On Thu, February 13, 2014 02:29:21 Shivam Makkar wrote: Hi I'm not able to build framework 5 due to some update error in Krunner, is there any manual method to build it ? You can pass --no-snapshots to the kdesrc-build command line to disable the use of a snapshot. kdesrc-build will then

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49758 --- Ship it! Ship It! - Christoph Feck On Feb. 13, 2014,

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/ --- (Updated Feb. 13, 2014, 11:17 p.m.) Status -- This change has been

Re: Review Request 115740: Fix build of KIconThemes on windows

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115740/#review49759 --- This review has been submitted with commit

Review Request 115741: Fix MSVC of kinit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/ --- Review request for KDE Frameworks. Repository: kinit Description

Re: Review Request 115741: Fix MSVC of kinit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/ --- (Updated Feb. 14, 2014, 12:22 a.m.) Review request for KDE Frameworks.

Review Request 115742: KParts: Allow compilation on windows

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/ --- Review request for KDE Frameworks and kdewin. Repository: kparts

Re: Review Request 115743: Use QFunctionPointer instead of void*

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/ --- (Updated Feb. 14, 2014, 1:02 a.m.) Review request for KDE Frameworks.

Review Request 115743: Use QFunctionPointer instead of void*

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115743/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review49761 --- Looks good to me, but it is a rather large diff, so I think

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review49762 --- cmake/FindSharedMimeInfo.cmake

Review Request 115744: The WIN32 part of this if statement doesn't seem to work - drop it

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/ --- Review request for Documentation, KDE Frameworks, kdewin, and Luigi

Review Request 115745: kservice: Allow compiling with MSVC

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115745/ --- Review request for KDE Frameworks and kdewin. Repository: kservice

Re: Review Request 115488: Improve docs for kde modules

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115488/#review49763 --- Ship it! Ship It! - Alexander Richardson On Feb. 4, 2014,

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote: src/core/kprotocolmanager.cpp, line 690 https://git.reviewboard.kde.org/r/115723/diff/1/?file=243874#file243874line690 Maybe move the Q_OS_MAC up as the first check, then there is no need for !defined(Q_OS_DARWIN) I

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

2014-02-13 Thread Frank Reininghaus
On Feb. 13, 2014, 9:31 p.m., Christoph Feck wrote: Making the type movable does not make QList store it directly, how did you check this? http://qt-project.org/doc/qt-5/qlist.html says: Internally, QListT is represented as an array of pointers to items of type T. If T is

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Sven Brauch
Hello! On Tuesday 11 February 2014 21:32:29 Alexander Semke wrote: couple of days ago LabPlot-project [1] decided to move to KDE and to become a part of KDE Edu and to collaborate closer with people involved in other projects on KDE Edu [2]. After almost four years of development we had the

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: El Dimarts, 11 de febrer de 2014, a les 11:55:01, Vishesh Handa va escriure: Hello people I've been developing Milou for quite some time now and I think it would be best to move it into extragear so that a release can

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:57:56 PM Albert Astals Cid wrote: Also you can optimize qDeleteAll(m_mapping.values()); to qDeleteAll(m_mapping); Thanks. Fixed -- Vishesh Handa

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace,

Re: Moving Milou to Extragear

2014-02-13 Thread Burkhard Lück
Am Donnerstag, 13. Februar 2014, 10:38:34 schrieb Vishesh Handa: On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: I'd also say that your catalog isn't getting loaded (i.e. your catalog name is wrong). Is it? Messages.sh #! /usr/bin/env bash $XGETTEXT `find .

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Vishesh Handa
Hey I've just taken a cursory glance. Some things that I noticed - 1. The recommended mailing list is sourceforge - Do you want to move to KDE? I'm not sure if this is required by the manifesto or not. We do enforce the usage of kde-infrastructure 2. AUTHORS - Do you really need to obfuscate

Re: Moving Milou to Extragear

2014-02-13 Thread Lukáš Tinkl
Dne 13.2.2014 11:28, Burkhard Lück napsal(a): Am Donnerstag, 13. Februar 2014, 10:38:34 schrieb Vishesh Handa: On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: I'd also say that your catalog isn't getting loaded (i.e. your catalog name is wrong). Is it? Messages.sh #!

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/#review49710 --- This review has been submitted with commit

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/ --- (Updated Feb. 13, 2014, 2:31 p.m.) Status -- This change has been

Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115726/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Review Request 115728: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115728/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Re: Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115726/ --- (Updated Feb. 13, 2014, 5:13 p.m.) Review request for KDE Runtime,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Albert Astals Cid
El Dijous, 13 de febrer de 2014, a les 08:21:48, Alexander Semke va escriure: Hi, Do you really need that embedded liborigin? The development of this code was originally initiated in LabPlot and got later contributions from other projects. A library was created. It is/was used for the

Re: Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact

2014-02-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114907/#review49745 --- ping? - Albert Astals Cid On Jan. 9, 2014, 10:22 p.m.,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Yuri Chornoivan
написане Thu, 13 Feb 2014 01:05:39 +0200, Albert Astals Cid aa...@kde.org: El Dimarts, 11 de febrer de 2014, a les 21:32:29, Alexander Semke va escriure: Hi all, couple of days ago LabPlot-project [1] decided to move to KDE and to become a part of KDE Edu and to collaborate closer with

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Alexander Semke
Hi, Do you really need that embedded liborigin? The development of this code was originally initiated in LabPlot and got later contributions from other projects. A library was created. It is/was used for the import of Origin files. At the moment we don't import anything but ascii files.

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Alexander Semke
Hi, A few things I noticed: - why not put the compile flags from the ./compile script in CMakeLists.txt? I'll move the flags to CMakeLists.txt. - I added a file data source, then a worksheet and an xy plot and it crashed [1] Huch. I cannot reproduce this. Does this error happens on your

Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/#review49755 --- Ship it! Makes a lot of sense. Pedantic Comments: fix the

Re: Review Request 115728: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115728/#review49756 --- Ship it! Ship It! - David Edmundson On Feb. 13, 2014,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Sven Brauch
Hi, On Thursday 13 February 2014 22:04:32 Alexander Semke wrote: Huch. I cannot reproduce this. Does this error happens on your system independent of the plot type (box plot etc.) you're trying to create? Sorry for the noise, I apparently didn't install the XMLGUI files properly. Thus the

Building project with QtCreator

2014-02-13 Thread Cruceru Calin
Hi, I managed to set up my KDE workplace using the kdesrc_build script in the end. There are still a couple of modules which reported some errors, but the most important ones as mentioned in the HOWTOs installed successfully. Now, I'm trying to build a small project with QtCreator to verify

RE: Building project with QtCreator

2014-02-13 Thread Cruceru Calin
Hi again, I managed to solve the problem in my previous e-mail. It was caused by the fact that I have installed both qt5 and qt4. In fact, this also caused many other errors from what I was told. The problem was that my implicit qmake was the version 3 and the qt version 5. I tried then to

Re: RE: Building project with QtCreator

2014-02-13 Thread aishen
I never succeeded compiling kdesrc_build to run... I think not enaugh practical examples, for me it's pity because I would like to use it with kf5 as I have to do it manually. Le 13/02/2014 15:26, Cruceru Calin a écrit : Hi again, I managed to solve the problem in my previous e-mail. It was

Friendly reminder: we need GSoC ideas *now*!

2014-02-13 Thread Teo Mrnjavac
The GSoC 2014 organization application deadline is tomorrow. Lydia and I have taken the liberty of applying on behalf of KDE, but our GSoC ideas list [1] is still shorter than last year. The amount of slots we get depends on the quantity and quality of our project ideas, so it's absolutely

Keyboard shortcut enhancement.

2014-02-13 Thread p . kubik . pl
It may be that I didn't fully understand the idea behind hotkeys in KDE, but I found some issues that might require tweaking. The mechanism behind that feature is quite strict. There are always some mod keys + ONE other keys (such as letters). There is no way to create a shortcut with two

Re: Keyboard shortcut enhancement.

2014-02-13 Thread Christoph Feck
On Friday 14 February 2014 01:07:10 p.kubik...@gmail.com wrote: The mechanism behind that feature is quite strict. There are always some mod keys + ONE other keys (such as letters). There is no way to create a shortcut with two other keys. I just tried it in Kate, and assigned Ctrl+Y, Ctrl+X

Re: Keyboard shortcut enhancement.

2014-02-13 Thread Thomas Lübking
On Freitag, 14. Februar 2014 01:22:19 CEST, Christoph Feck wrote: On Friday 14 February 2014 01:07:10 p.kubik...@gmail.com wrote: The mechanism behind that feature is quite strict. There are always some mod keys + ONE other keys (such as letters). There is no way to create a shortcut with two

Re: Keyboard shortcut enhancement.

2014-02-13 Thread Michael Jansen
On Friday 14 February 2014 01:44:05 Thomas Lübking wrote: On Freitag, 14. Februar 2014 01:22:19 CEST, Christoph Feck wrote: On Friday 14 February 2014 01:07:10 p.kubik...@gmail.com wrote: The mechanism behind that feature is quite strict. There are always some mod keys + ONE other keys

Re: Re: Keyboard shortcut enhancement.

2014-02-13 Thread Martin Gräßlin
On Friday 14 February 2014 04:19:04 Michael Jansen wrote: I am btw not really sure khotkeys should still be part of kde5. its broken, never really reached kde4 anyway and both lubos and i don't work on it anymore. And it failed to attract anyone else. Thanks for letting us know. I ported it

Re: Re: Keyboard shortcut enhancement.

2014-02-13 Thread Ben Cooksley
On Fri, Feb 14, 2014 at 7:39 PM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 14 February 2014 04:19:04 Michael Jansen wrote: I am btw not really sure khotkeys should still be part of kde5. its broken, never really reached kde4 anyway and both lubos and i don't work on it anymore. And it

Re: Re: Keyboard shortcut enhancement.

2014-02-13 Thread Andreas Pakulat
Hi, On Fri, Feb 14, 2014 at 7:46 AM, Ben Cooksley bcooks...@kde.org wrote: On Fri, Feb 14, 2014 at 7:39 PM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 14 February 2014 04:19:04 Michael Jansen wrote: I am btw not really sure khotkeys should still be part of kde5. its broken,