Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread Kevin Ottens
On Thursday 03 July 2014 19:50:35 laurent Montel wrote: Hi, During kdepim porting I saw that it was not possible to add a ActionButton as QButtonBox is protected. = we can do it if we create a derived class. But it’s not a very easy method for just add a button. I would like to add a new

Re: kdelibs4support FindGettext

2014-07-04 Thread Alex Merry
On 03/07/14 22:06, Jonathan Riddell wrote: kdelibs4support ships an old copy of FindGettext.cmake. This is incompatible with the version shipping in cmake and causes some compile failures. Can I remove it? The interfaces of both files look like they should be the same. Do you have any info

Re: kdelibs4support FindGettext

2014-07-04 Thread Jonathan Riddell
On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote: On 03/07/14 22:06, Jonathan Riddell wrote: kdelibs4support ships an old copy of FindGettext.cmake. This is incompatible with the version shipping in cmake and causes some compile failures. Can I remove it? The interfaces of

Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: kdelibs4support FindGettext

2014-07-04 Thread Alex Merry
On 04/07/14 10:07, Jonathan Riddell wrote: On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote: On 03/07/14 22:06, Jonathan Riddell wrote: kdelibs4support ships an old copy of FindGettext.cmake. This is incompatible with the version shipping in cmake and causes some compile

Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/ --- Review request for Build System, KDE Frameworks and Jonathan Riddell.

Re: kdelibs4support FindGettext

2014-07-04 Thread Alex Merry
On 04/07/14 10:41, Alex Merry wrote: On 04/07/14 10:07, Jonathan Riddell wrote: On Fri, Jul 04, 2014 at 10:01:46AM +0100, Alex Merry wrote: On 03/07/14 22:06, Jonathan Riddell wrote: kdelibs4support ships an old copy of FindGettext.cmake. This is incompatible with the version shipping in

Jenkins build became unstable: ktexteditor_master_qt5 #449

2014-07-04 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/449/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61597 --- I confirm this patch fixes the death lock. - Aleix Pol

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread Kevin Ottens
On Friday 04 July 2014 09:17:04 laurent Montel wrote: Le vendredi 4 juillet 2014 08:13:58 Kevin Ottens a écrit : On Thursday 03 July 2014 19:50:35 laurent Montel wrote: Hi, During kdepim porting I saw that it was not possible to add a ActionButton as QButtonBox is protected. = we

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-04 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61601 --- cmake/modules/FindGettext.cmake

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/ --- (Updated July 4, 2014, 1:05 p.m.) Review request for KDE Frameworks and

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread Christoph Feck
On Thursday 03 July 2014 19:50:35 laurent Montel wrote: Hi, During kdepim porting I saw that it was not possible to add a ActionButton as QButtonBox is protected. = we can do it if we create a derived class. But it’s not a very easy method for just add a button. I would like to add a new

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread laurent Montel
Le vendredi 4 juillet 2014 16:46:24 Christoph Feck a écrit : On Thursday 03 July 2014 19:50:35 laurent Montel wrote: Hi, During kdepim porting I saw that it was not possible to add a ActionButton as QButtonBox is protected. = we can do it if we create a derived class. But it’s not a

KIO: thread safety commit broke Get hot new stuff

2014-07-04 Thread Marco Martin
HI all, I recently noticed that the two GHNS windows in Plasma 5 very recently freeze the whole process as soon the dialog opens I tried to bisect things and the problem is definitely in the commit 8cb050ea61dfb195fee0293c7c0eb87cb0a90654 in the KIO framework KIO thread-safety: protect

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61611 --- I can confirm it fixes it here as well - Marco Martin On

Re: KIO: thread safety commit broke Get hot new stuff

2014-07-04 Thread Alex Merry
On 04/07/14 17:40, Marco Martin wrote: HI all, I recently noticed that the two GHNS windows in Plasma 5 very recently freeze the whole process as soon the dialog opens I tried to bisect things and the problem is definitely in the commit 8cb050ea61dfb195fee0293c7c0eb87cb0a90654 in the

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61614 --- recursive mutexes are more expensive. Can you try this patch

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread David Faure
On July 4, 2014, 7:22 p.m., David Faure wrote: recursive mutexes are more expensive. Can you try this patch instead? http://www.davidfaure.fr/2014/kprotocolmanager.cpp.diff Actually, nothing beats a unittest :) Added, fix pushed.

Re: [Kde-hardware-devel] OSX/MacPorts KDE CI System: Build failed for framework solid

2014-07-04 Thread David Faure
On Thursday 03 July 2014 23:30:14 Marko Käning wrote: So, please, apply this patch to solid's git repo and re-package the KF 5.0.0 release accordingly. Done (v5.0.0-rc2 tag) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread David Faure
On July 4, 2014, 7:22 p.m., David Faure wrote: recursive mutexes are more expensive. Can you try this patch instead? http://www.davidfaure.fr/2014/kprotocolmanager.cpp.diff David Faure wrote: Actually, nothing beats a unittest :) Added, fix pushed.

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/ --- (Updated July 4, 2014, 9:58 p.m.) Status -- This change has been

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Vishesh Handa
On July 4, 2014, 7:22 p.m., David Faure wrote: recursive mutexes are more expensive. Can you try this patch instead? http://www.davidfaure.fr/2014/kprotocolmanager.cpp.diff David Faure wrote: Actually, nothing beats a unittest :) Added, fix pushed.

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Milian Wolff
On July 4, 2014, 7:22 p.m., David Faure wrote: recursive mutexes are more expensive. Can you try this patch instead? http://www.davidfaure.fr/2014/kprotocolmanager.cpp.diff David Faure wrote: Actually, nothing beats a unittest :) Added, fix pushed.

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread David Faure
On July 4, 2014, 7:22 p.m., David Faure wrote: recursive mutexes are more expensive. Can you try this patch instead? http://www.davidfaure.fr/2014/kprotocolmanager.cpp.diff David Faure wrote: Actually, nothing beats a unittest :) Added, fix pushed.

Re: Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-07-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119021/#review61622 --- This review has been submitted with commit

Re: Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-07-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119021/ --- (Updated July 4, 2014, 9:17 p.m.) Status -- This change has been

Re: Jungle and Plasma Media Center

2014-07-04 Thread Shantanu Tushar Jha
On Fri, Jul 4, 2014 at 12:00 AM, Vishesh Handa m...@vhanda.in wrote: Hey Shaantanu Jungle is more of a personal itch that we (Alex Fiestas and I) wanted to scratch. It's currently in its very very early phases, and is not ready for consumption by anyone. Also, the code is not up to my

Re: Jungle and Plasma Media Center

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 1:05 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: On Fri, Jul 4, 2014 at 12:00 AM, Vishesh Handa m...@vhanda.in wrote: Hey Shaantanu Jungle is more of a personal itch that we (Alex Fiestas and I) wanted to scratch. It's currently in its very very early phases,

Re: Jungle and Plasma Media Center

2014-07-04 Thread Shantanu Tushar Jha
On Fri, Jul 4, 2014 at 6:09 PM, Vishesh Handa m...@vhanda.in wrote: On Fri, Jul 4, 2014 at 1:05 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: On Fri, Jul 4, 2014 at 12:00 AM, Vishesh Handa m...@vhanda.in wrote: Hey Shaantanu Jungle is more of a personal itch that we (Alex Fiestas and

Re: Jungle and Plasma Media Center

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 2:52 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: Ah they can very well exist (even though PMC isn't really just a video player), as you have mentioned in a comment on the blog post. However, as I said, the whole point of a media center is lost if the user has to

kwin_x11 decoration plugin Oxygen not found

2014-07-04 Thread Leslie Zhai
Hi martin and KDE developers, I built the KF5 and KWin from git repos hosting on https://projects.kde.org but when I run kwin_x11 --replace it failed to work so I simply pasted some of the output shown as below: QXcbConnection: XCB error: 3 (BadWindow), sequence: 168, resource id: 31457305,

Re: Jungle and Plasma Media Center

2014-07-04 Thread Shantanu Tushar Jha
On Fri, Jul 4, 2014 at 6:29 PM, Vishesh Handa m...@vhanda.in wrote: On Fri, Jul 4, 2014 at 2:52 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: Ah they can very well exist (even though PMC isn't really just a video player), as you have mentioned in a comment on the blog post. However, as

Re: Jungle and Plasma Media Center

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 4:02 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: In the ideal case, you'd just switch to a Movies and TV Shows mode for a categorized display of movies and tv shows. For videos, you switch to a list of videos, sorted by a property (most likely date). Oh. I

Re: Jungle and Plasma Media Center

2014-07-04 Thread Shantanu Tushar Jha
Ah, that would've been confusing :P Anyway, I understand that Jungle is in very early stages right now and you guys are experimenting with the UI to see what fits best. My intention was just to make sure that we can work together to make the KDE multimedia offering more unified and easy to use.

Re: Jungle and Plasma Media Center

2014-07-04 Thread Aleix Pol
On Fri, Jul 4, 2014 at 1:05 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: On Fri, Jul 4, 2014 at 12:00 AM, Vishesh Handa m...@vhanda.in wrote: Hey Shaantanu Jungle is more of a personal itch that we (Alex Fiestas and I) wanted to scratch. It's currently in its very very early phases,

Re: Jungle and Plasma Media Center

2014-07-04 Thread Shantanu Tushar Jha
On Sat, Jul 5, 2014 at 5:39 AM, Aleix Pol aleix...@kde.org wrote: On Fri, Jul 4, 2014 at 1:05 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: On Fri, Jul 4, 2014 at 12:00 AM, Vishesh Handa m...@vhanda.in wrote: Hey Shaantanu Jungle is more of a personal itch that we (Alex Fiestas and