Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 --- We have never needed this until now because we can recognize

Re: Review Request 119876: KIO: add KIO::EmptyTrashJob* KIO::emptyTrash().

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ --- (Updated Aug. 21, 2014, 7:41 a.m.) Review request for KDE Frameworks.

Re: How to promote less mature Frameworks?

2014-08-21 Thread Kevin Krammer
On Wednesday, 2014-08-20, 12:14:31, Aleix Pol wrote: It would be very interesting to have somebody working on kdepimlibs around. I keep hearing that they will be available soon, but I still ignore whether the people doing the work want the kdepimlibs to become KDE Frameworks (they didn't want

Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64970 --- https://git.reviewboard.kde.org/r/119882/ - Jonathan Riddell

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/#review64971 --- Ship it! Regarding rotating the complete button, I doubt

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
On Aug. 21, 2014, 10:42 a.m., Christoph Feck wrote: Regarding rotating the complete button, I doubt that it will look good. You will also rotate lightning/shadows, direction of gradients etc. yes, right ... in fact, what my own code does (after double checking), is call

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64976 --- KConfig has multiple libraries but only 1

Re: Review Request 119879: call style()-drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/ --- (Updated Aug. 21, 2014, 1:02 p.m.) Status -- This change has been

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Status -- This change has been

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Review request for KDE Frameworks,

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
On Aug. 21, 2014, 7:19 a.m., David Faure wrote: We have never needed this until now because we can recognize such files by their name... So while I'm not opposed to this, I wonder, why not use if (u.fileName() == .directory) in KDesktopFileActions (RR 119869) -- which will also make

Review Request 119884: Add cursor shape property to MouseEventListener

2014-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119884/ --- Review request for KDE Frameworks. Bugs: 337062

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64989 --- Ship it! OK, so normally we would just have one cmake file

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/ --- (Updated Aug. 21, 2014, 4:19 p.m.) Status -- This change has been

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/#review64997 --- Ship it! src/widgets/kdesktopfileactions.cpp

Re: OSX/CI system: prison fails to build on branch master

2014-08-21 Thread Marko Käning
Prison now successfully builds on OSX, thanks to Raymond’s fix from August 19th! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

OSX/CI: kdepimlibs fails to build on branch frameworks

2014-08-21 Thread Marko Käning
Now that prison successfully builds I was able to proceed somewhat with kdepimlibs, but for some reason its build fails due to akonadi: --- Generating moc_specialmailcollectionsdiscoveryjob.cpp Generating moc_specialmailcollectionsrequestjob.cpp [ 12%] [ 12%] Built target KF5AkonadiMime_automoc

Re: Review Request 119876: KIO: add KIO::EmptyTrashJob* KIO::emptyTrash().

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ --- (Updated Aug. 21, 2014, 10:30 p.m.) Status -- This change has been

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-21 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 5:43 matin) Review request for KDE Frameworks,

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 --- We have never needed this until now because we can recognize

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Milian Wolff
On Aug. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: Why is this per repo? This should be in a place all repos get the nice stuff without having to do work. A static Makefile and a configure.sh seem like very bad ideas to me. Why do you need those over cmake? Mathieu Tarral

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Milian Wolff
On Aug. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: Why is this per repo? This should be in a place all repos get the nice stuff without having to do work. A static Makefile and a configure.sh seem like very bad ideas to me. Why do you need those over cmake? Mathieu Tarral

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Review request for KDE Frameworks,

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Status -- This change has been

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
On Aug. 21, 2014, 7:19 a.m., David Faure wrote: We have never needed this until now because we can recognize such files by their name... So while I'm not opposed to this, I wonder, why not use if (u.fileName() == .directory) in KDesktopFileActions (RR 119869) -- which will also make

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Albert Astals Cid
On ago. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: Why is this per repo? This should be in a place all repos get the nice stuff without having to do work. A static Makefile and a configure.sh seem like very bad ideas to me. Why do you need those over cmake? Mathieu Tarral

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/#review64997 --- Ship it! src/widgets/kdesktopfileactions.cpp

Review Request 119890: [Ark] Implement Add to archive option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/ --- Review request for KDE Base Apps and KDE Utils. Bugs: 338414

Review Request 119892: [Dolphin] Implement Add to archive option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/ --- Review request for KDE Base Apps and KDE Utils. Bugs: 338414

Re: Review Request 119892: [Dolphin] Implement Add to archive option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review64999 --- lib/konq/konq_operations.cpp

Re: Review Request 119678: add a target named project_doc for each project in the tree, to generate developer documention

2014-08-21 Thread Mathieu Tarral
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678/ --- (Updated août 21, 2014, 10:50 après-midi) Status -- This change has

Re: OpenGL ES on project neon

2014-08-21 Thread Thomas Lübking
On Donnerstag, 21. August 2014 07:24:33 CEST, Martin Gräßlin wrote: btw, is there a way to run qdbus correctly from SSH? If I run it inside X11 konsole, I get all the stuff, if I run it from SSH, even with xhost and DISPLAY set, I don't get anything about kde: Sorry, no idea how to do that.

Re: Hackaton in Timișoara Romania

2014-08-21 Thread Ovidiu-Florin Bogdan
I forgot to add: The mentors will be required to sustain a small presentation regarding the project they will maintain (to familiarize the hackers with it) and eighter by themselfs, or help me with mine, sustain a presentation presenting KDE, and the KDE development workflow. -- Ovidiu-Florin