Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

2015-05-11 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/ --- (Updated May 11, 2015, 6:49 a.m.) Review request for Baloo. Changes

Re: Review Request 123707: Set session manager discard command

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80198 --- isLocalFile() makes everyone think of QUrl::isLocalFile(),

Re: Review Request 123706: Add session management for KMainWindow

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 7:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-11 Thread David Faure
On May 10, 2015, 10:43 p.m., David Faure wrote: src/core/kfileitem.cpp, line 1115 https://git.reviewboard.kde.org/r/123654/diff/1/?file=366630#file366630line1115 I had the same thought as Milian... but I wonder why I wrote that comment. m_strText is the displayName, m_strName is

Re: Review Request 123707: Set session manager discard command

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 11, 2015, 7:52 a.m.) Status -- This change has been

Re: Review Request 123706: Add session management for KMainWindow

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80202 --- Ship it! src/kmainwindow.cpp (line 154)

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80203 --- Ship it! Ship It! - David Faure On May 11, 2015, 7:56

Review Request 123720: Fix autotests

2015-05-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80201 --- Ship it! Good solution, I like it! - David Faure On May

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 7:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 7:50 a.m.) Review request for KDE Frameworks and

Re: Review Request 123706: Add session management for KMainWindow

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 8:20 a.m.) Review request for KDE Frameworks and

Re: Versioning of Frameworks

2015-05-11 Thread Christian Mollekopf
On Mon, May 11, 2015, at 12:31 AM, David Faure wrote: On Monday 11 May 2015 00:13:27 Christian Mollekopf wrote: Are you volunteering, or just making demands for others to do work for you? I'm volunteering to do the maintenance and release engineering for the libraries that matter

Re: Review Request 123595: Relax KUser test to allow for a nogroup group.

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/ --- (Updated May 11, 2015, 8:02 a.m.) Review request for KDE Frameworks and

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

2015-05-11 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/ --- (Updated May 11, 2015, 8:28 a.m.) Status -- This change has been

Re: Moving a Bug to Proper Product

2015-05-11 Thread Thomas Lübking
On Montag, 11. Mai 2015 00:18:19 CEST, Jacky Alcine wrote: Bug 346481 refers to a general level bug that potentially affects all applications rendered by KWin That's not related to KWin at all but a known issue of the breeze icon set. The designers oppose outlines as well as other (inner)

Re: [Kde-hardware-devel] Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-05-11 Thread Kai Uwe Broulik
On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote: daemon/backends/upower/powerdevilupowerbackend.cpp, line 175 https://git.reviewboard.kde.org/r/123475/diff/2/?file=362775#file362775line175 Somehow that code path is never executed making init stuck when XRandR is not

Re: changelog for 5.10

2015-05-11 Thread Sebastian Kügler
On Monday, May 11, 2015 00:48:37 David Faure wrote: On Saturday 09 May 2015 13:00:54 Sebastian Kügler wrote: On Saturday, May 09, 2015 13:06:57 David Faure wrote: On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: For the notification aspect of it, I think. The text is up

Re: Review Request 123720: Fix autotests

2015-05-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/ --- (Updated May 11, 2015, 12:36 p.m.) Status -- This change has been

Re: Review Request 123720: Fix autotests

2015-05-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/#review80216 --- Ship it! Ship It! - David Edmundson On May 11, 2015, 7:58

KSystemlog status

2015-05-11 Thread Ragnar Thomsen
I have completed porting ksystemlog to KF5 in the frameworks branch. It no longer depends on KDELibs4Support. The functionality should be similar to the old ksystemlog, with the following exceptions: *KFileDialog - QFileDialog: It appears wildcard selection is not possible with QFileDialog. This

Re: Review Request 123706: Add session management for KMainWindow

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80218 --- Ship it! Ship It! - David Faure On May 11, 2015, 8:20

Re: Review Request 123720: Fix autotests

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/#review80217 --- Ship it! Ship It! - David Faure On May 11, 2015, 7:58

Re: Versioning of Frameworks

2015-05-11 Thread David Faure
On Monday 11 May 2015 11:57:02 Christian Mollekopf wrote: But that doesn't necessarily mean they can't be part of the same distribution mechanism. If you simply take a snapshot of all frameworks every month, then it shouldn't matter if they changed or not. If no change has been made, the

Re: KSystemlog status

2015-05-11 Thread Luigi Toscano
Ragnar Thomsen ha scritto: I have completed porting ksystemlog to KF5 in the frameworks branch. It no longer depends on KDELibs4Support.+ [...] Finally, I will attempt to add a journald backend to ksystemlog. I have already developed a small tool (journalktl:

Re: KSystemlog status

2015-05-11 Thread Ragnar Thomsen
On Mon, May 11, 2015 at 3:52 PM, Luigi Toscano luigi.tosc...@tiscali.it wrote: That's great, but isn't there a GSoC entry for this? I talked to d_ed about the GSoC project and we decided the student will work on adding support for journald in ksystemlog. Ragnar Visit

Re: Versioning of Frameworks

2015-05-11 Thread Christian Mollekopf
On Mon, May 11, 2015, at 02:42 PM, David Faure wrote: On Monday 11 May 2015 11:57:02 Christian Mollekopf wrote: But that doesn't necessarily mean they can't be part of the same distribution mechanism. If you simply take a snapshot of all frameworks every month, then it shouldn't matter

Re: Review Request 123721: Update virtual functions with Q_DECL_OVERRIDE

2015-05-11 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123721/ --- (Updated May 11, 2015, 3:27 p.m.) Review request for Baloo and Vishesh

Re: Review Request 123721: Update virtual functions with Q_DECL_OVERRIDE

2015-05-11 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123721/#review80223 --- Ship it! Looks good. John, do you plan on sticking around

Re: Review Request 123721: Update virtual functions with Q_DECL_OVERRIDE

2015-05-11 Thread John Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123721/ --- (Updated May 11, 2015, 3:31 p.m.) Status -- This change has been

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-11 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80225 --- +1 - Mark Gaiser On mei 11, 2015, 4:55 p.m., Michael

Re: Review Request 123706: Add session management for KMainWindow

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 8:38 p.m.) Status -- This change has been

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 8:37 p.m.) Status -- This change has been

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80228 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 11, 2015,

Want to start!

2015-05-11 Thread Claudio Maradonna
Hi guys! I'm a new user that wants to help the community in this big project. I'm young and i have no fear about the complexity of the project, but i prefer for this beginning a guide. Where i can help with some bug fixes or other little implementations? Thanks for all and good work! Visit

Re: Want to start!

2015-05-11 Thread Aleix Pol
On Tue, May 12, 2015 at 12:28 AM, Claudio Maradonna penguy...@stronzi.org wrote: Hi guys! I'm a new user that wants to help the community in this big project. I'm young and i have no fear about the complexity of the project, but i prefer for this beginning a guide. Where i can help with

Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-11 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople