Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 7, 2015, 9:25 a.m., David Faure wrote: > > BTW why create a KTar on top of a KCompressionDevice? KTar is able to > > handle compression automatically all by itself... and that's exactly the > > case where it will use a tempfile for the uncompressed data, making seeking > > work.

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Projects using the plasma-framework for inspiration

Hi, I'm porting Amarok to KF5. I'm basically done with the pure C++/Qt part. There is a folder that used to be powered by Plasma::Applet [1]. I have now to port this to plasma-framework. Could you redirect me to a project which use them so that it can inspire me? I have no idea of how to

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- (Updated Nov. 21, 2015, 6:57 p.m.) Review request for KDE Software on

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- (Updated Nov. 21, 2015, 7:57 p.m.) Status -- This change has been

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/#review88671 --- Right, I'm not sure that splitting code into a different file

Re: kde-build-metadata for beta branches

Hello, On Sat, Nov 21, 2015 at 4:24 PM, Jonathan Riddell wrote: > Can I change kde-build-metadata to Plasma/5.5 while the branch is in > stable or will that mess up other uses of kde-build-metadata? AFAIK, yes you can change kde-build-metadata. Given its branched and

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 2 p.m., David Faure wrote: > > Right, I'm not sure that splitting code into a different file really works > > here. To avoid duplication, there would have to be a base class (interface) > > first, with only the platform-specific code in its two subclasses, all the > >

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 12:35 p.m., David Faure wrote: > > src/ioslaves/trash/tests/testtrash.cpp, line 149 > > > > > > Use .at(0) to avoid unnecessary detaching. > > René J.V. Bertin wrote: > I tried that

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/#review88679 --- Ship it! Search/replace typo? Looks good after fixing that.

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 7:04 p.m., David Faure wrote: > > Search/replace typo? Looks good after fixing that. Dang, yes. Evidently the compiler didn't catch that :) - René J.V. --- This is an automatically generated e-mail. To reply,

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 11:35 a.m., David Faure wrote: > > src/ioslaves/trash/tests/testtrash.cpp, line 149 > > > > > > Use .at(0) to avoid unnecessary detaching. > > René J.V. Bertin wrote: > I tried that

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On Saturday November 21 2015 12:59:40 David Faure wrote: >I still don't see why you can't just patch Qt on macports (given that you're >already patching it anyway) rather than having to add something to each and >every link line in KF5, That would mean having 2 different Qt5 installs in

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- (Updated Nov. 21, 2015, 7:23 p.m.) Review request for KDE Software on

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated Nov. 22, 2015, 1:57 a.m.) Review request for KDE Frameworks and

Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 126132: Better bitrate format in filemetadatawidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126132/ --- Review request for Baloo and Vishesh Handa. Repository: baloo-widgets

Review Request 126130: [kholidays] Qt5Core should be required, not Qt5Test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126130/ --- Review request for KDE Frameworks and John Layt. Repository: kholidays

Re: BrPrint3D Project

Thanks for the feedback Olivier! I will correct this inconsistencies in time! =) Att 2015-11-21 19:01 GMT-02:00 Olivier Churlaud : > Hey Lays, > > just a small (aesthetic) advise for the futur of your project: try to stay > consistent in your conventions. > You use

Re: Failure while executing KTar::open while using KCompressionDevice as the device

Hello again. 2015-11-07 6:03 GMT-03:00 David Faure : > On Friday 06 November 2015 08:47:34 Luiz Romário Santana Rios wrote: >> 2015-11-06 4:48 GMT-03:00 David Faure : >> > On Monday 02 November 2015 14:53:40 Luiz Romário Santana Rios wrote: >> >> >> >> I'm trying to

BrPrint3D Project

Hi, guys! The new version of Br-Print GUI (Pandora) is avalable today! After some weeks working on a big project remodeling, I finalized the tests to make this version available. One of the problems I was facing was the fact that I wrote the MainWindow as a God Class and it was doing too much

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 6, 2015, 7:52 a.m., David Faure wrote: > > src/karchive.cpp, line 652 > > > > > > This is not equivalent to seek(d->pos). > > seek(d->pos) goes to the absolute position d->pos, counting from the >

Daily builds packaging (for Kdenlive)

Hello, We have been missing testers for our latest releases, mostly from the fact that people who used to offer daily builds stopped this work. We first advised people to use Neon (Kubuntu-CI) but they complained it updated too many things in their system and didn't want to switch with VMs...

Re: Review Request 126085: Fix filename suggestion changing to something random when changing save-as mimetype.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126085/#review88683 --- Ship it! Ship It! - David Faure On Nov. 16, 2015, 12:05

Re: Projects using the plasma-framework for inspiration

On Sat, Nov 21, 2015 at 5:36 PM, Olivier Churlaud wrote: > Hi, > > I'm porting Amarok to KF5. I'm basically done with the pure C++/Qt part. > There is a folder that used to be powered by Plasma::Applet [1]. I have now > to port this to plasma-framework. Could you redirect me

Re: BrPrint3D Project

Hey Lays, just a small (aesthetic) advise for the futur of your project: try to stay consistent in your conventions. You use CamelCase in some files, Camelized_Snake or snake_case in other, and even some unicase. Pick one a stay with it. It's easier to maintain. You might also have a look

Re: Review Request 125974: Make KTar KCompressionDevice-friendly

> On Nov. 7, 2015, 9:25 a.m., David Faure wrote: > > BTW why create a KTar on top of a KCompressionDevice? KTar is able to > > handle compression automatically all by itself... and that's exactly the > > case where it will use a tempfile for the uncompressed data, making seeking > > work.

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 12:35 p.m., David Faure wrote: > > src/ioslaves/trash/tests/CMakeLists.txt, line 34 > > > > > > you can't commit that > > René J.V. Bertin wrote: > Oops, that one got through, sorry about

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 12:35 p.m., David Faure wrote: > > src/ioslaves/trash/tests/CMakeLists.txt, line 34 > > > > > > you can't commit that Oops, that one got through, sorry about that. > On Nov. 21, 2015, 12:35

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/#review88667 --- src/ioslaves/trash/kcmtrash.cpp (line 227)

kde-build-metadata for beta branches

I've branched Plasma for the 5.5 beta and will make a final release in a couple of weeks. Before I make the final release I want to check in build.kde.org if it has any complaints in builds of the Plasma/5.5 branch. But build.kde.org currently uses kde-build-metadata points only to master and to

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 21, 2015, 3:05 a.m., Aleix Pol Gonzalez wrote: > > src/ioslaves/trash/trashimpl.cpp, line 129 > > > > > > Infrastructure is 1 word I guess that depends on how far you want to decompose, but if you say

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 20, 2015, 10:06 p.m., René J.V. Bertin wrote: > > src/ioslaves/trash/trashimpl.cpp, line 947 > > > > > > These were `kDebug()` statements; I guess they should become > > `qWarning()` now that `kDebug`

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126125/ --- (Updated Nov. 21, 2015, 1:50 p.m.) Review request for KDE Software on