D12696: Use the new uds implementation

lbeltrame added a comment. I wonder if this is related to timeline:/ no longer working properly in the file dialog. (didn't investigate yet). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: lbeltrame, asturmlechner,

Re: Kde CI setup

On Tue, Jun 5, 2018 at 9:37 AM, Michael Reeves wrote: > I am the mantainer for kdiff3. Thanks for the reply. What systems are > currently part of this CI? I want to try and catch any issues before getting > this turned on. It depends on what platforms you want to have enabled. Currently we have

D13442: Implemented displaying of total lines in kate

shubham added a comment. I'm finding it difficult to implement it , can you help? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D13442: Implemented displaying of total lines in kate

shubham added a comment. Can I make "show word count" checkbox as "show word count and total lines"? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel,

D13442: Implemented displaying of total lines in kate

shubham added a comment. I'm unable to apply this patch, dont know why REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns,

D12696: Use the new uds implementation

asturmlechner added a comment. No crash in my case, but this commit makes links with sftp:/ inaccessible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: asturmlechner, martinkostolny, kde-frameworks-devel, bruns, michaelh,

KDE Frameworks 5.47.0 released

09th June 2018. KDE today announces the release of KDE Frameworks 5.47.0. KDE Frameworks are 78 addon libraries to Qt which provide a wide variety of· commonly needed functionality in mature, peer reviewed and well tested· libraries with friendly licensing terms. For an introduction see the·

KDE Frameworks 5.47.0 released

09th June 2018. KDE today announces the release of KDE Frameworks 5.47.0. KDE Frameworks are 78 addon libraries to Qt which provide a wide variety of· commonly needed functionality in mature, peer reviewed and well tested· libraries with friendly licensing terms. For an introduction see the·

D13442: Implemented displaying of total lines in kate

shubham added a comment. Thank you cullman, will try to finish it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns,

D13442: Implemented displaying of total lines in kate

cullmann added a comment. For the config stuff, here is a analog addition of UI parts for the "show word count": https://cgit.kde.org/ktexteditor.git/patch/src/dialogs/katedialogs.cpp?id=594c51bbf61dcf7014a44727519afb4a6b58c074 For the column: just ignore that, we can finish the

D13442: Implemented displaying of total lines in kate

shubham added a comment. And about the column thing, does it have any importance rather than just telling the number of characters in the current line? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham,

D13442: Implemented displaying of total lines in kate

shubham added a comment. Now I understood,since i,m a novice can you tell how can that configuration option be implemented? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel,

D13442: Implemented displaying of total lines in kate

cullmann added a comment. Sorry, I did mix up things, more clear, hopefully: 1. I think one shall have a configuration option to turn the "of ..." part on/off, people might not like it, and as it is always visible, that might be bad 2. One might think about showing "Column x of y",

D13442: Implemented displaying of total lines in kate

shubham added a comment. Cullman I didnt get you, do u want a display for max column, isnt the maximum column same as opposed to line.Is it req? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham,

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

cullmann added a comment. I wonder if that really makes sense, given not all blocks contain ranges at all and they not really correlate with the block size. Does that change really make it much faster or just shift the costs? REPOSITORY R39 KTextEditor REVISION DETAIL

D13442: Implemented displaying of total lines in kate

cullmann added a comment. Actually, it might make sense to show the maximal column, too. But perhaps we should make that configurable. Options are bad on one side, but the space in the statusbar is not that large if you have a smaller windows. Could you add a preference for that? We

D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold

ngraham retitled this revision from "Open Schema toolbar button with normal click rather than click-and-hold" to "Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold". ngraham edited the summary of this revision. ngraham edited the test plan for this

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham updated this revision to Diff 35890. ngraham added a comment. Also make this change for all other toolButtons that open menus REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13026?vs=34604=35890 BRANCH

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham planned changes to this revision. ngraham added a comment. I don't think being `delayed` was a deliberate choice; it's simply the default interaction method for toolbuttons that open menus in Qt (for some odd reason). Every menu toolbutton throughout KDE software that shows its menu

D13442: Implemented displaying of total lines in kate

ngraham added a comment. I was expressing support for the current state, no need for changes from my perspective. :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel,

D13442: Implemented displaying of total lines in kate

shubham added a comment. Should I display it as a fraction or leave it, having mixed reactions REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,

D13442: Implemented displaying of total lines in kate

ngraham added a comment. +1, this seems like a good way to display it to me! I rather like seeing the total number of lines, especially as implemented with this patch, as expressed as a sort of fraction. I think it gives the user a good sense of position. REPOSITORY R39 KTextEditor

D13442: Implemented displaying of total lines in kate

dhaumann added a comment. Personally, I belong to the group that does not care about the total number of lines. To me, this is visual noise. The current line number is relevant for me, since it identifies a unique location in the document. But if you think this is required I will not stop

D13442: Implemented displaying of total lines in kate

shubham updated this revision to Diff 35886. shubham added a comment. hopefully this is the final patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13442?vs=35881=35886 REVISION DETAIL https://phabricator.kde.org/D13442 AFFECTED FILES

D13442: Implemented displaying of total lines in kate

shubham added a comment. Will change that too REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars,

D13442: Implemented displaying of total lines in kate

cullmann added a comment. It makes sense to be consistent. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann,

D13442: Implemented displaying of total lines in kate

shubham added a comment. In D13442#276202 , @brauch wrote: > Since the other two number displays use QLocale().toString(), probaly this should too ... Is it mandatory? REPOSITORY R39 KTextEditor REVISION DETAIL

Re: Kde translation.

Thanks. On Mon, Jun 4, 2018, 5:23 PM Albert Astals Cid wrote: > El dijous, 26 d’abril de 2018, a les 13:59:18 CEST, Michael Reeves va > escriure: > > How are translations handled as far distribution goes? > > This question is a bit vague. > > Are you asking what we do with the translations? >

Re: Kde CI setup

I am the mantainer for kdiff3. Thanks for the reply. What systems are currently part of this CI? I want to try and catch any issues before getting this turned on. On Mon, Jun 4, 2018, 4:24 PM Thomas Baumgart wrote: > Michael, > > do you work on a KDE project? Is it in the KDE git repository? If

D13442: Implemented displaying of total lines in kate

brauch added a comment. Since the other two number displays use QLocale().toString(), probaly this should too ... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: kwrite-devel, kde-frameworks-devel, michaelh,

D12768: Allow wrapping selection off top/bottom of autocomplete results

dhaumann added a comment. Indeed, question is if wrapping helps: If you see 5 entries, and you see the last one is correct, then moving up would be ok. But if the completion contains >> 10 entries, this will not work. And then, there is still the "End" key on the keyboard as dedicated

D12271: Don't remove trailing whitespace from cursor line

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. See arguments above: If we change it, another one will come over

D12768: Allow wrapping selection off top/bottom of autocomplete results

cullmann added a comment. I think the idea was that it is an easy way out of the completion. I am not sure if wrapping is what one would expect. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: dhaumann, cullmann,

D12768: Allow wrapping selection off top/bottom of autocomplete results

dhaumann added subscribers: cullmann, dhaumann. dhaumann added a comment. I remember that @cullmann intentionally implemented it this way: Going upwards will hide the completion list and not wrap around. @cullmann Any take on this? Either accept, or reject. Also, the unit test need

D12854: Awk: fix regex in a function and update syntax for gawk

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d5c5f4d3c85a: Awk: fix regex in a function and update syntax for gawk (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D12854: Awk: fix regex in a function and update syntax for gawk

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, will integrate. REPOSITORY R216 Syntax Highlighting BRANCH awk REVISION DETAIL https://phabricator.kde.org/D12854 To: jpoelen, #framework_syntax_highlighting,

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

dhaumann added subscribers: mwolff, dhaumann. dhaumann added a comment. @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12897 To:

D13442: Implemented displaying of total lines in kate

shubham updated this revision to Diff 35881. shubham added a comment. This should be fine? REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13442?vs=35872=35881 REVISION DETAIL https://phabricator.kde.org/D13442 AFFECTED FILES

D13026: Open Schema toolbar button with normal click rather than click-and-hold

dhaumann added a comment. The same holds true for other actions such as: Tools > Highlighting, Mode, Indentation, Script. Question here is: Is this delayed thing needed for building the contents on-the-fly (look at the aboutToShow() functions)? REPOSITORY R39 KTextEditor REVISION

D13395: Pony: fix single quote escape and a possible infinite loop with #

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0ec0100e5948: Pony: fix single quote escape and a possible infinite loop with # (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D13395: Pony: fix single quote escape and a possible infinite loop with #

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Works - will integrate. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-pony REVISION DETAIL https://phabricator.kde.org/D13395 To: jpoelen, dhaumann Cc:

D13442: Implemented displaying of total lines in kate

shubham added a comment. As you wish , will implement in the next patch REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D13442: Implemented displaying of total lines in kate

cullmann added a comment. Hi, I can understand that some people want that, but I think in this way, it takes a lot of space. If we want that, could we not just say Line 20 of 100, Column 34? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To:

D13442: Implemented displaying of total lines in kate

shubham edited reviewers, added: brauch; removed: ngraham. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann,

D13442: Implemented displaying of total lines in kate

shubham added reviewers: cullmann, ngraham. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, ngraham Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars,

Re: Closing old Plasma 4 bugs

On vrijdag 8 juni 2018 22:37:56 CEST Nate Graham wrote: > This work is done; all the bugs and feature requests in the plasma4 > product have been closed. Hope all of your inboxes survived the onslaught! Nice! https://bugs.kde.org/weekly-bug-summary.cgi tells me User# Resolved n...@kde.org

D13442: Implemented displaying of total lines in kate

shubham edited reviewers, added: KTextEditor; removed: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars,

D13442: Implemented displaying of total lines in kate

shubham edited reviewers, added: cullmann; removed: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann,

D13442: Implemented displaying of total lines in kate

shubham created this revision. shubham added a reviewer: KTextEditor. shubham created this object with visibility "All Users". shubham added a project: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel,