[no subject]

Hello Everyone! I am an aspiring web developer and I would like to participate in Season of KDE. Can anyone guide me to any Web Development projects I can work on?

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 212 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/212/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 04 Dec 2019 04:31:55 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25727: Expose enum to the metaobject compiler

apol created this revision. apol added a reviewer: jbbgameich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Should Help the PersonActionsModel work on QML REPOSITORY R307 KPeople BRANCH master

D25620: Register ActionType enum with metaobject system

apol added a comment. Hi, thanks for your patience. Can you check if this works? https://phabricator.kde.org/D25727 Can you share a test case that uses it? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc:

D25720: Fix shortcut conflict between Cut and Delete File

ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25721: EBN kdeclarative transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25721 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

apol added a comment. +1 it doesn't seem to me that shift+delete is used elsewhere. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25720 To: ngraham, #frameworks, cfeck Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25719: EBN KActivites transfer protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25719 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25630: Port to json metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R150:423c75cc12c3: Port to json metadata (authored by nicolasfella). REPOSITORY R150 KDE Telepathy KDE Daemon Module CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25630?vs=70698=70869

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. No reconstructing-call-history-via-a-boolean-member, I like this! :-) Thanks for your tests with this solution. INLINE COMMENTS > kdiroperator.cpp:1446 > +emit

D25630: Port to json metadata

akulichalexandr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R150 KDE Telepathy KDE Daemon Module BRANCH json REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks, #kde_telepathy, akulichalexandr Cc: akulichalexandr,

D25723: Replace KIconloader with QIcon::fromTheme

This revision was automatically updated to reflect the committed changes. Closed by commit R152:f25a4e3e989a: Replace KIconloader with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R152 KDE Telepathy Send File CHANGES SINCE LAST UPDATE

D25723: Replace KIconloader with QIcon::fromTheme

akulichalexandr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R152 KDE Telepathy Send File BRANCH ilo REVISION DETAIL https://phabricator.kde.org/D25723 To: nicolasfella, #frameworks, #kde_telepathy, akulichalexandr

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All issues are fixed now for me! It works perfectly! REPOSITORY R241 KIO BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70866. feverfew added a comment. don't send http(s) to kioexec REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70830=70866 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED

D25599: Fix plugin-metadata translations on windows

aacid added a comment. In D25599#571398 , @vonreth wrote: > In D25599#571158 , @aacid wrote: > > > In D25599#570678 , @vonreth wrote: > > > > > Are you

D25723: Replace KIconloader with QIcon::fromTheme

nicolasfella added reviewers: Frameworks, KDE Telepathy. REPOSITORY R152 KDE Telepathy Send File REVISION DETAIL https://phabricator.kde.org/D25723 To: nicolasfella, #frameworks, #kde_telepathy

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Thanks for that very clear and understandable synopsis. I'll let others figure out the best path forward. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: broulik, sitter,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. So before this patch we had the following behaviour: 1. If app is KIO-enabled, pass URLs unchanged. 2. else for each URL, if app claims to support the protocol pass the original URL, otherwise change the URL to the corresponding KIOExec path. This causes

Re: Blacklisting of PIM from the CI system

On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > The complexity of the dependency graph is also a problem for onboarding new > people, and with kdelibs4support gone IMHO the largest technical dept here. > It's being worked on, albeit slowly, currently we are losing ~1 module

Re: Blacklisting of PIM from the CI system

On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > The complexity of the dependency graph is also a problem for onboarding new > people, and with kdelibs4support gone IMHO the largest technical dept here. > It's being worked on, albeit slowly, currently we are losing ~1 module

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

nicolasfella added a comment. Works fine for my rather simple KDE Connect use case +1 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25721: EBN kdeclarative transfer protocol cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transfer protocol from http to https REPOSITORY R296 KDeclarative BRANCH ebn-cleanup (branched from master)

D25720: Fix shortcut conflict between Cut and Delete File

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY [⇧] + [Delete] is bound to both Cut and Delete File, meaning that it can't

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. Well, there are certainly more ugly things out there :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. Why is it ugly? I think the fallback is usually meant to fall back to e.g. a built-in icon pixmap, but doing a chain of `fromTheme` fallbacks is just fine imho. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella,

Re: Blacklisting of PIM from the CI system

On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > > action from being carried

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. It's a bit ugly that fallback is a QIcon, not a QString :/ I will send a patch to Qt REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

Re: Blacklisting of PIM from the CI system

On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > > action from being carried

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella updated this revision to Diff 70853. nicolasfella added a comment. - Fall back to application-octet-stream REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25707?vs=70806=70853 BRANCH rena REVISION DETAIL https://phabricator.kde.org/D25707

D25717: [KSqueezedTextLabel] Add icon for "Copy entire text" action

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25717 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/70/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 03 Dec 2019 19:10:43 + Build duration: 6 min 52 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 193 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/193/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 19:10:43 + Build duration: 3 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/86/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 19:10:43 + Build duration: 3 min 15 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/89/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 19:10:43 + Build duration: 2 min 49 sec and counting BUILD ARTIFACTS

D25409: rst: Add support for standalone hyperlinks

nibags added a comment. The version and kateversion are updated in D25276 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25409 To: adrianchavesfernandez, mosra, nibags Cc: nibags, kwrite-devel, kde-frameworks-devel,

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. >> And, of course, more unit tests like the one in D19824 ... :D > > This was not an automated test. OK, thanks for clarifying that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To:

D25276: reStructuredText: Fix inline literals highlighting preceding characters

nibags closed this revision. REVISION DETAIL https://phabricator.kde.org/D25276 To: adrianchavesfernandez, mosra, dhaumann Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D25276: reStructuredText: Fix inline literals highlighting preceding characters

nibags updated this revision to Diff 70849. nibags added a comment. Update kateversion to 5.0: use of POSIX character classes in regular expressions CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25276?vs=70846=70849 BRANCH arcpatch-D25276 REVISION DETAIL

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven updated this revision to Diff 70848. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25420?vs=70847=70848 BRANCH arcpatch-D25420 REVISION DETAIL https://phabricator.kde.org/D25420 AFFECTED FILES

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. I was wrong, indeed NAME_MAX is what should be used; looking at the code in KAutoSaveFile::open(), and how tempFileName() is actually used: tempFile = staleFilesDir + QChar::fromLatin1('/') + d->tempFileName(); NAME_MAX is what should be used, as

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven updated this revision to Diff 70847. meven added a comment. Consumes KeyPressEvent when activated would not needed, clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25420?vs=70826=70847 BRANCH arcpatch-D25420 REVISION DETAIL

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven added a comment. In D25420#571548 , @ahmadsamir wrote: > In D25420#571483 , @dfaure wrote: > > > So after a double-click, activated() is emitted, the boolean is set, and much later some

D25276: reStructuredText: Fix inline literals highlighting preceding characters

nibags updated this revision to Diff 70846. nibags added a comment. - Update version & branch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25276?vs=69647=70846 BRANCH arcpatch-D25276 REVISION DETAIL https://phabricator.kde.org/D25276 AFFECTED FILES

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/69/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 03 Dec 2019 18:30:18 + Build duration: 5 min 36 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 192 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/192/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 18:30:18 + Build duration: 2 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 88 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/88/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 18:30:18 + Build duration: 3 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 18:30:18 + Build duration: 2 min 29 sec and counting JUnit Tests

D25409: rst: Add support for standalone hyperlinks

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25409 To: adrianchavesfernandez, mosra, nibags Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25409: rst: Add support for standalone hyperlinks

nibags accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D25409 REVISION DETAIL https://phabricator.kde.org/D25409 To: adrianchavesfernandez, mosra, nibags Cc: nibags, kwrite-devel, kde-frameworks-devel,

D25409: rst: Add support for standalone hyperlinks

nibags updated this revision to Diff 70841. nibags added a comment. - Update branch & remove autotests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25409?vs=70011=70841 BRANCH arcpatch-D25409 REVISION DETAIL

D25719: EBN KActivites transfer protocol cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transfer protocol from http to https REPOSITORY R6 KActivities BRANCH ebn-cleanup (branched from master)

D24046: Allow triggering sort from QML

This revision was automatically updated to reflect the committed changes. Closed by commit R307:1e339edef781: Allow triggering sort from QML (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=70833=70838 REVISION DETAIL

D24046: Allow triggering sort from QML

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: mpyne, jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

jbbgameich added a comment. Ping REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. In D25420#571483 , @dfaure wrote: > So after a double-click, activated() is emitted, the boolean is set, and much later some Key_Enter event that should have been emitted, gets eaten? > > Wouldn't an event filter

D24046: Allow triggering sort from QML

nicolasfella updated this revision to Diff 70833. nicolasfella added a comment. Override and forward REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=66370=70833 BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 AFFECTED FILES

D25717: [KSqueezedTextLabel] Add icon for "Copy entire text" action

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is a "Copy" action, after all REPOSITORY R236 KWidgetsAddons REVISION

D25716: [KPropertiesDialog] Show extra fields

broulik updated this revision to Diff 70831. broulik added a comment. - Use `KSqueezedTextLabel` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25716?vs=70829=70831 REVISION DETAIL https://phabricator.kde.org/D25716 AFFECTED FILES

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Okay, that fixed it for the case of opening files in non-KDE apps on my Samba share. Now they open from the FUSE path--all of them! So this is good. However now kioexec downloads http URLs opened from other apps instead of just passing them off to the browser.

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70830. feverfew added a comment. ignore scheme handler REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70823=70830 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. With the latest version of this patch, now every file always gets downloaded through kioexec on my password-protected Samba share; nothing ever gets the kio-fuse path. In fact the share never gets mounted at all when I try to open something on the share in a non-KDE

D25716: [KPropertiesDialog] Show extra fields

broulik created this revision. broulik added reviewers: Frameworks, VDG, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can be additional useful information about the file, such as

D25705: Deprecate KIO::pixmapForUrl

kossebau added inline comments. INLINE COMMENTS > pixmaploader.h:47 > */ > +#if KIOWIDGETS_ENABLE_DEPRECATED_SINCE(5, 65) > + This line should be before the API dox comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc:

I need help fixing krita's flatpak build on binary factory

Krita's flatpak nightly and nightly stable builds are broken, and I don't know why. It's almost as if flatpak-builder tries to parse the yaml file as json: [2019-12-02T22:37:51.554Z] + flatpak-builder --force-clean --delete-build-dirs --arch=x86_64 --ccache --sandbox --user

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

dfaure added a comment. So after a double-click, activated() is emitted, the boolean is set, and much later some Key_Enter event that should have been emitted, gets eaten? Wouldn't an event filter on the QAbstractItemView solve your problem? Then you can catch the Return key before

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven updated this revision to Diff 70826. meven added a comment. Move activated event detection to KDirOperator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25420?vs=70046=70826 BRANCH arcpatch-D25420 REVISION DETAIL https://phabricator.kde.org/D25420

T11542: Remove KHTML

ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven added a comment. In D25420#571165 , @dfaure wrote: > > If KDirOperator is a child widget, and it receives and processes a key event, it can choose to NOT let the event propagate to the parent widget > [by calling accept()

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#571358 , @fvogt wrote: > In D23384#571276 , @ngraham wrote: > > > I'm afraid that even with that change, the issue is still present. I honestly don't think it

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70823. feverfew added a comment. Convert KIO URLs to KIOFuse URL is app is not KIO-enabled. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70799=70823 BRANCH arcpatch-D23384 REVISION DETAIL

D25705: Deprecate KIO::pixmapForUrl

apol added a comment. What do you mean by `Can easily be done otherwise.`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added a comment. I haven't read everything in great detail... but... Quick braindump of musing I did elsewhere: as far as credential hand-over is concerned this is likely a problem that needs a workaround for now as there is no clear cut solution that I am aware of. It may be

D25562: Add some friendly "report bugs here" links

This revision was automatically updated to reflect the committed changes. Closed by commit R304:834e52ee4bd9: Add some friendly report bugs here links (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25562?vs=70733=70822 REVISION DETAIL

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. From what I understood `loadMimeTypeIcon` has this fallback to use "Unknown" icon, see D15451 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik,

D25708: Don't use nullptr to flags

aacid added a comment. To be clear, that works just fine, it's just weird and deprecated on 5.15, but it's not "incorrect" code REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D25708 To: mlaurent, romangg, zzag Cc: aacid, zzag, kde-frameworks-devel, LeGast00n,

Re: KTimeTracker in kdereview

вт, 19 нояб. 2019 г. в 07:20, Alexander Potashev : > KTimeTracker [1] has been moved to kdereview. > > The project is currently in playground-pim, destination would be > extragear-pim. KTimeTracker had been in kdereview for two weeks already. It is enough to assume everything is OK and we can

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 106 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/106/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 10:21:19 + Build duration: 7 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/99/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 10:21:19 + Build duration: 4 min 16 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 228 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/228/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 10:21:19 + Build duration: 4 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 85 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 09:17:59 + Build duration: 13 min and counting BUILD ARTIFACTS

D25678: Document Notifiers setting

This revision was automatically updated to reflect the committed changes. Closed by commit R237:f366253557c6: Document Notifiers setting (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25678?vs=70722=70814 REVISION DETAIL

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/43/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 09:17:59 + Build duration: 6 min 56 sec and counting BUILD ARTIFACTS

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 2 inline comments as done. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 09:17:59 + Build duration: 6 min 22 sec and counting JUnit Tests Name:

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70812. ndavis added a comment. More code formatting REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70802=70812 BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL

D25678: Document Notifiers setting

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25678 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. In D25599#571158 , @aacid wrote: > In D25599#570678 , @vonreth wrote: > > > Are you sure?

D25708: Don't use nullptr to flags

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b3c7074431d0: Dont use nullptr to flags (authored by mlaurent). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25708?vs=70807=70811 REVISION DETAIL

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2,

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

dfaure added a comment. I'm not smarter than you, but I consider this code hacky :-) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel,

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcolorscheme.cpp:289 > struct { > -QBrush fg[8], bg[8], deco[2]; > +QBrush fg[KColorScheme::NForegroundRoles], >

D25708: Don't use nullptr to flags

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > IT seems that it was a error during modernize code by using nullptr Yeah, we had the same issue with running modernize-use-nullptr over kwin's code base. REPOSITORY R127 KWayland