D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:1510 > This should only apply to the `QVERIFY(device != otherDevice);` Why? The goal is to test if the UDS_DEVICE_ID is unique for individual partitions, which won't work unless there are two separate partitions.

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79315. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. - Change unit test name - More QCOMPARE() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79133=79315 BRANCH l-statx (branched

D28295: Introduce KNotificationJobUiDelegate

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in knotificationjobuidelegate.cpp:24 > I don't remember any past discussion about this, but as I discovered in KIO > commit 3d2330968b > , > nested

D28530: newServicePath(): Docs say add prefix but it's actually suffix

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In newServicePath() when a service with the suggestedName already exists a suffix is added. Make the docs

D28521: Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts

ahmadsamir added a comment. Typo in commit message "reallocson". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28521 To: kossebau, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R275:8696ae59a274: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked 4 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:1530 > If you want to avoid doing this you can remove fields asked from statDetails > `KIO::StatBasic | KIO::StatUser | KIO::StatInode` for instance. > And have a more

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79133. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. - Less stat details, in that unit test we're interested in Inode stuff - In the test, return early if we can't find two separate partitions REPOSITORY R241 KIO CHANGES

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use QSortFilterProxyModel::setFilterRegularExpression() instead of setFitlerRegExp(). TEST PLAN make

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in file_unix.cpp:304 > This buf.st_dev is the decimal part in: > $ stat /usr/bin/file | grep Device > Device: 804h/2052d Inode: 9168 Links: 1 > that would be "2052" > > whereas with

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79071. ahmadsamir retitled this revision from "[FileProtocol] change statx stat_dev() to use device major + minor" to "[FileProtocol] change statx stat_dev() to return makedev(major, minor)". ahmadsamir edited the summary of this revision. ahmadsamir

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:1382 > Please add a separate test dedicated for Inode like `statWithInode()` like > `statSymlink` does for instance. > Here you change the purpose of this test : default stat behavior with stat(), > to default +

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir updated this revision to Diff 79044. ahmadsamir marked 2 inline comments as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79031=79044

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir added a comment. I'll address the comments, but one point which I couldn't figure out is that HAVE_STATX isn't available for the unit tests, any examples on how to make it work there too? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir,

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added inline comments. INLINE COMMENTS > fstabhandling.cpp:131 > +return source + ':' + mountpoint; > } > return source; Nitpick: QLatin1Char. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: ahmadsamir,

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY On Linux systems that have statx available, stat_dev() returned stx_dev_major, which could be the same

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added a subscriber: sitter. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e247985be433: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 730a6ddd828fb1fbdf0f3 ,

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. In D28388#638986 , @meven wrote: > In D28388#638722 , @ahmadsamir wrote: > > > ... > > > Open a diff to have a focused conversation. Good point. Thanks. :)

D28271: [KFontChooser] More code cleanup

ahmadsamir updated this revision to Diff 78986. ahmadsamir added a comment. Move family checkbox and listview code next to each other REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28271?vs=78983=78986 BRANCH l-kfontchooser-3 (branched from

D28271: [KFontChooser] More code cleanup

ahmadsamir updated this revision to Diff 78983. ahmadsamir added a comment. - Simplify connect() calls - Move the connect() calls of the various checkboxes, in ShowDifferences mode, after the widgets they enable/disable have been created REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST

D28271: [KFontChooser] More code cleanup

ahmadsamir planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > bport wrote in kfontchooser.cpp:347 > This comment is still valid ? Yes, that's after setting the font family/style/size list views and the size DoubleSpinBox. REPOSITORY R236 KWidgetsAddons

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 78979. ahmadsamir added a comment. Don't use a lambda in connetc() where it's not needed REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=78441=78979 BRANCH l-monospace-checkbox REVISION DETAIL

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. In D28388#637419 , @dfaure wrote: > In D28388#637417 , @ahmadsamir wrote: > > > (Now the other issue, "DEVICE" (from the kproperties patch) is always "8", whether I use

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

This revision was automatically updated to reflect the committed changes. Closed by commit R126:30a713025624: [kioclient] Fix kioclient5 --commands usage messages (authored by ahmadsamir). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY It should use 'kioclient5'. REPOSITORY R126 KDE CLI Utilities

D27455: FileWidgets: Ignore Return events from KDirOperator

ahmadsamir added a comment. I tested this diff, and it seemed to work as expected. REPOSITORY R241 KIO BRANCH arcpatch-D27455 REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27455: FileWidgets: Ignore Return events from KDirOperator

ahmadsamir added inline comments. INLINE COMMENTS > kfilewidget.cpp:1913 > +} else if (watched == d->ops && event->type() == QEvent::KeyPress) { > +if (keyEvent->key() == Qt::Key_Return) { > +// ignore return events from the KDirOperator I would combine the two if's

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir accepted this revision. ahmadsamir added a comment. In D28388#637416 , @dfaure wrote: > kdeinit5 is the one who needs to see that QT_PLUGIN_PATH in order to locate kio_file.so. > > > $ export QT_PLUGIN_PATH=$PWD/bin > $

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. $ export QT_LOGGING_RULES="*kio*=true" $ kdeinit5 from the build dir $ LD_LIBRARY_PATH=./ QT_PLUGIN_PATH=./ kioclient5 openProperties ~/.bashrc still not getting the qDebug() I put in createUDSEntry()... IIUC, qDebug() always worked regardless of the

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. I spent some time trying to to get some output of a qDebug() that I put in createUDSEntry(), but got the total sum of nothing; for future reference, any pointers? (I tried the kpropertiesdialog small patch from D27951 among

D28302: [KNewFileMenu] Add extension to proposed filename

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ad0bbeebc568: [KNewFileMenu] Add extension to proposed filename (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28302?vs=78731=78743 REVISION

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir updated this revision to Diff 78731. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. - Fix unit test - Handle the case that a templatePath is a file with no extension REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f5d5390f32d2: [KOpenWithDialog] Add generic name from .desktop files as a tooltip (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Extend the current setup by adding a tooltip based on the generic name entry from the .desktop files. This

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir updated this revision to Diff 78717. ahmadsamir added a comment. - Change it as suggested by dfaure to use the translated text from Name= entry - Fix typos REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28302?vs=78535=78717 BRANCH

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.cpp:97 > The theoretical answer is yes, this would crash. But note that the user > cannot just close the application by clicking somewhere while a modal dialog > is up. This requires much more subtle

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Using "create new" text or html file, add the extension to the proposed filename, this makes those plain text

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634955 , @sitter wrote: > In D28161#634951 , @ahmadsamir wrote: > > > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here ->

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir updated this revision to Diff 78528. ahmadsamir added a comment. Leave out kdsoap-ws-discovery-client, it's maintained somewhere else... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=78090=78528 BRANCH l-QRE (branched from

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634949 , @sitter wrote: > Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Unit tests are indeed useful... > Please don't

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 78441. ahmadsamir added a comment. Depends on D28271 REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=78440=78441 BRANCH l-monospace-checkbox REVISION DETAIL

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The use case is applications where the user is usually interested in monospaced/fixe-width

D28271: [KFontChooser] More code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Simplfy the layout by removing the splitter, the goal was to allow resizing the font

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28193#633829 , @dfaure wrote: > I don't think this makes any difference, they all share the same underlying private singleton. > So all this does is to use a tiny bit more

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78383. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Verbatim REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78266=78383 BRANCH l-kfontchooser-2 (branched from

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir reclaimed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:f22c1864f5c8: [KFontChooser] General code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78376=78382 REVISION

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28246 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in

D28244: GIT_SILENT minor code formatting

ahmadsamir updated this revision to Diff 78377. ahmadsamir added a comment. tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28244?vs=78374=78377 BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78376. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Fix, arcanist is REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78375. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78299=78375

D28244: GIT_SILENT minor code formatting

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28244

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in kfontchooserdialog.cpp:93 > Shouldn't this be not commented IIUC, if a function is declared static inside the class body (e.g. in the header file), the static keyword can't be repeated when it's defined outside the class body.

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

ahmadsamir added inline comments. INLINE COMMENTS > commandlauncherjobtest.cpp:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David Faure > + same. > commandlauncherjobtest.h:3 > +This file is part of the KDE libraries > +Copyright (c) 2014, 2020 David

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78299. ahmadsamir added a comment. Also enable size spinbox when enabling the size list box REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78295=78299 BRANCH l-kfontchooser (branched from master)

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78295. ahmadsamir added a comment. Make connect() actually work for the QCheckBoxes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78265=78295 BRANCH l-kfontchooser (branched from master)

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78266. ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78192=78266 BRANCH l-kfontchooser-2 (branched from master) REVISION

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78265. ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78190=78265 BRANCH l-kfontchooser (branched from master) REVISION

D27811: [KConfigGui] Check font weight when clearing styleName property

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ec9522ae73ff: [KConfigGui] Check font weight when clearing styleName property (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

This revision was automatically updated to reflect the committed changes. ahmadsamir marked 2 inline comments as done. Closed by commit R236:2e9cace39272: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

ahmadsamir added a comment. In D28184#632547 , @dfaure wrote: > In D28184#632459 , @ahmadsamir wrote: > > > It was failing locally for me too, both when I had /tmp as tmpfs and when I changed it to

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.h:81 > Do @param need to be in order of the arguments? (I'm not sure) They should be, it's more logical. > dfaure wrote in kfontchooserdialog.h:89 > Good call. I

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78251. ahmadsamir added a comment. @param should have the same order as the in the ctor declaration (patterns make life slightly easier) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78249=78251

D28206: Port QList/QSet deprecated methods

This revision was automatically updated to reflect the committed changes. Closed by commit R241:37686fd70359: Port QList/QSet deprecated methods (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28206?vs=78239=78250 REVISION DETAIL

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78249. ahmadsamir marked an inline comment as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Update the screenshot in the docs, Breeze style/colors REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir marked 6 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.h:89 > The usual way in Qt API is that the parent is the last argument, rather than > the first. > > But for this to be convenient, the fontlist argument would

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir updated this revision to Diff 78241. ahmadsamir retitled this revision from "Move/port KFontDialog from KDELibs4Support to KWidgetAddons" to "Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog". ahmadsamir edited the summary of this revision. ahmadsamir

D28206: Port QList/QSet deprecated methods

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-fromlist (branched from master) REVISION DETAIL

D28184: KIO autotests: repair JobTest::moveDestAlreadyExistsAutoRename

ahmadsamir added a comment. It was failing locally for me too, both when I had /tmp as tmpfs and when I changed it to be a regular dir on /; /home is a separate partition on my system. So I didn't understand how the test passed on the CI. FTR, I build KIO on a regular

D28187: KIO DesktopExecParser: simplify code

ahmadsamir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28187 To: dfaure, ahmadsamir, feverfew, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28187: KIO DesktopExecParser: simplify code

ahmadsamir added a comment. Neat. The logic all seems to hold: We have no urls: - if it's a local file, useKioexec is false, and no fuse since "requests" will be empty - if it's not a local file, useKioexec is true, and we try fuse; if there's an error with fuse fallback to

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure, davidedmundson, apol Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in KFontChooser::Private

D28191: [KFontChooser] General code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Use new connect syntax - Prefix increment where appropriate - Replace foreach/iterator-based for

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d644f8f2eb5: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir added a comment. In D28186#631962 , @dfaure wrote: > Nice. > > clang-format can't be configured to add missing braces, Nope, I'd have had to use clang-format (which requires a "compilation server", I read some docs,

D28186: GIT_SILENT kpasswdserver, break long lines for readability; add braces around if

ahmadsamir updated this revision to Diff 78171. ahmadsamir retitled this revision from "GIT_SILENT break long lines for readability; add braces around if" to "GIT_SILENT kpasswdserver, break long lines for readability; add braces around if". ahmadsamir added a comment. Verbatim REPOSITORY

D28186: GIT_SILENT break long lines for readability; add braces around if

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code still compiles. REPOSITORY R241 KIO BRANCH l-kpasswdserver-long-lines (branched from master) REVISION

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28169#631885 , @dfaure wrote: > OK, it's fixed now, after 3 commits :-) > You can drop this change, it's better that CI actually tests the code. [..] Yesterday, I

D28097: GIT_SILENT clang-format kpasswdserver.*

This revision was automatically updated to reflect the committed changes. Closed by commit R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.* (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78157=78158 REVISION DETAIL

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78157. ahmadsamir added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28097?vs=78155=78157 BRANCH l-kpasswdserver-clang-format (branched from master) REVISION DETAIL

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir added a comment. In D28169#631809 , @dfaure wrote: > Ah, we had tried already to make it work uninstalled. > > The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78156. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28169?vs=78152=78156 BRANCH l-krun-ssh-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28169

D28097: GIT_SILENT clang-format kpasswdserver.*

ahmadsamir updated this revision to Diff 78155. ahmadsamir retitled this revision from "GIT_SILENT clang-format kpasswdserver.* plus some manual changes" to "GIT_SILENT clang-format kpasswdserver.*". ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

ahmadsamir updated this revision to Diff 78154. ahmadsamir added a comment. clang-format only, less prone to errors, as the level of stupidity of the tool is locked at the compile time of the tool (unlike manual changes) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78153. ahmadsamir added a comment. Tweak docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28122?vs=78124=78153 BRANCH l-kfontdlg (branched from master) REVISION DETAIL

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78152. ahmadsamir retitled this revision from "[DesktopExecParser] Let the service open protocols is claims to support" to "[krununittest] Skip the test if ktelnetservice5{,.desktop} isn't found". ahmadsamir edited the test plan for this revision.

D28169: [DesktopExecParser] Let the service open protocols is claims to support

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:350 > Doesn't this break the special case in the comment below? > VLC claims to support smb:// but if we have a password, we need to be able to > pass it, so we want to use KIOFuse? > > And then if you

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631254 , @kossebau wrote: > Please also add a note in the documentation when to use new-name-of-KFontDialog and when QFontDialog, i.e. in which use-cases new-name-of-KFontDialog is superior and not

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir updated this revision to Diff 78124. ahmadsamir added a comment. - Rename to KFontChooserDialog to prevent conflict with the one from KDELibs4Support - Document "features" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. See D28169 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28169: [DesktopExecParser] Let the service open protocols is claims to support

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, feverfew, ngraham. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This reverts commit 14b7f2c7ee72b

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. OK, I see why it's failing. KMimeTypeTrader::self()->preferredService() (from schemeService()) can't find ktelnetservice5.desktop in /usr/share/applications/ since KIO isn't installed on the CI system; so skip the test in that case? REPOSITORY R241 KIO

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir added a comment. In D27999#631255 , @dfaure wrote: > This commit breaks krununittest in CI, can you take a look? > >

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

ahmadsamir added a comment. In D28122#631237 , @kossebau wrote: > Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that

<    1   2   3   4   5   6   7   8   9   10   >