D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. Oh, Hannah updated the summary, so an unknown option makes visibility stuff fail? Wow Apple really did a bad fork of clang if that's what's happening. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth, aacid,

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. You sure about that? AFAICS from https://binary-factory.kde.org/view/MacOS/job/Kate_Release_macos/346/console it's just a warning, otherwise, ninja would stop after the first error, and it continues until a linking failure happens REPOSITORY R240 Extra CMake

Re: restore dialog sizes and QTBUG-40584

El divendres, 25 de gener de 2019, a les 9:26:15 CET, Alexander Semke va escriure: > Hi, > > after having read the documentation of KWindowConfig::restoreWindowSize(), I > understood how to properly restore the dialog sizes. I'm in a process of > fixing > this now in LabPlot (20 dialogs or so):

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

El dissabte, 26 de gener de 2019, a les 13:05:23 CET, Bhushan Shah va escriure: > > > > Can we try to get this documented? 1.7GB isn't a lot for lots of people > > with fast internet (if the server serves fast enough). > > https://invent.kde.org/sysadmin/ci-tooling/wikis/CI-On-Local-Machine >

D18369: Create tel: links for phone numbers

aacid added inline comments. INLINE COMMENTS > ktexttohtml.h:66 > +/** > + * Replace phone numbers with tel: links. > + */ @since missing REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D18369 To: vkrause Cc: aacid, svuorela, nicolasfella,

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. Why? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

El dissabte, 26 de gener de 2019, a les 9:13:45 CET, Ben Cooksley va escriure: > On Sat, Jan 26, 2019 at 10:35 AM Albert Astals Cid wrote: > > > > El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va > > escriure: > > > Git commit f6c79ff4787148459

Re: KDE's release script not functional on stable openSUSE

El dijous, 24 de gener de 2019, a les 11:28:59 CET, Jaroslaw Staniek va escriure: > Hi Jonathan, > The releaseme tools require ruby 2.3 while openSUSE 42.3 depends on 2.1. According to https://repology.org/metapackage/ruby/versions you should have a ruby2.4 package available.

Re: Fwd: Kexi_flatpax fix and question

As far as i know: * The infrastructure we have at this point in KDE is more targeted to provide nightlies. * If you want to provide stable flatpak, the current recommended solution is do it via flathub (like we do for several of our apps already). Cheers, Albert El dijous, 24 de gener de

Re: Troubles with icon themes

El dimecres, 23 de gener de 2019, a les 4:48:10 CET, Jonathan Schultz va escriure: > Hello KDE developers, > > I wonder if someone can help me work out what is going on here. > > I have build some KDE applications (konsole and okular) from source using > kdesrc-build, using QT5 version 5.11.3

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va escriure: > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. > Committed on 21/01/2019 at 05:46. > Pushed by bcooksley into branch 'master'. > > Disable execution of tests for plasma-integration. > This is

D18434: exiv2extractor: add support for bmp, gif, webp, tga

aacid added a comment. is it worth adding files to autotests/exiv2extractortest.cpp ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18434 To: kossebau, #baloo, #dolphin Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#398076 , @graesslin wrote: > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers.

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#398343 , @kossebau wrote: > only 3(?) days between proposal and commit was also a very rushy Check your dates better please, it's 9 days > Though then in this very case, my own take is to be pragmatic

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. In D18167#397020 , @graesslin wrote: > This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:7d73c6744f64: Move -Wsuggest-override -Wlogical-op to regular compiler settings (authored by aacid). REPOSITORY

D18345: Fix python binding generation for classes with deleted copy constructors

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a2a404f9f924: Fix python binding generation for classes with deleted copy constructors (authored by aacid). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18345: Fix python binding generation for classes with deleted copy constructors

aacid added subscribers: skelly, cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18345 To: aacid Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18137: delete copy constructor and assignment operator of some public classes

aacid added a comment. The magic to generate sip files was not magic enough https://phabricator.kde.org/D18345 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D18137 To: aacid, mpyne Cc: cgiboudeaux, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

aacid created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. aacid requested review of this revision. TEST PLAN kcoreaddons compiles again REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D11320: Fix QVariantMapList operator >> implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R281:66362ec67b8f: Fix QVariantMapList operator implementation (authored by aleksanderm, committed by aacid). Herald added a subscriber: kde-frameworks-devel. REPOSITORY R281 ModemManagerQt CHANGES

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13416 To: miklosm, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, aacid, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham,

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

aacid added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. I pushed this at https://commits.kde.org/kio-extras/0be80392f01e0ec01174990c430dcd8f1ed35d9e REPOSITORY R320 KIO Extras REVISION DETAIL

D17664: fix for macOS

This revision was automatically updated to reflect the committed changes. Closed by commit R6:74f3eeb69ead: fix for macOS (authored by yurikoles, committed by aacid). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT

D17726: Add helper function to disable redirections (useful for kde-open)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8c3f000b72ed: Add helper function to disable redirections (useful for kde-open) (authored by achauvel, committed by aacid). CHANGED PRIOR TO COMMIT

D16643: Correct the accept flag of the event object on DragMove

aacid added a comment. @bruns waiting for your comment on whether your issues were addressed or not REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: aacid, bruns, dkorth, ngraham, kde-frameworks-devel,

D18237: Fix ResultIterator

aacid set the repository for this revision to R293 Baloo. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

This revision was automatically updated to reflect the committed changes. Closed by commit R263:02b523bad09a: Make KCheckAccelerators less invasive for apps that dont directly link to… (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. Since i have two +1 i'll commit this next saturday unless someone shouts in disagreement REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

aacid updated this revision to Diff 49340. aacid added a comment. Change style to make Anthony happy REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18204?vs=49319=49340 BRANCH arcpatch-D18204 REVISION DETAIL https://phabricator.kde.org/D18204

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

aacid updated this revision to Diff 49319. aacid added a comment. Review comments update REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18204?vs=49308=49319 BRANCH arcpatch-D18204 REVISION DETAIL https://phabricator.kde.org/D18204 AFFECTED FILES

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 337491 TEST PLAN Ran qtcreator and it no longer has the & in Details Added some debug and checked that okular

D18136: kconfig_compiler: delete the assignment operator and copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R237:601faf2ad9d4: kconfig_compiler: delete the assignment operator and copy constructor (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18136?vs=49108=49195#toc REPOSITORY

D18135: KEmailSettings: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R237:78da515c5deb: KEmailSettings: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D18134: KEncodingProber: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R270:d5ffc242950b: KEncodingProber: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY They really help making the code better so it's good to have all applications getting those

D18137: delete copy constructor and assignment operator of some public classes

This revision was automatically updated to reflect the committed changes. Closed by commit R244:44b91ba50d2f: delete copy constructor and assignment operator of some public classes (authored by aacid). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D18137: delete copy constructor and assignment operator of some public classes

aacid added a comment. I did some grepping and didn't find anything obvious (which make sense since it would be crashy) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18137 To: aacid, mpyne Cc: mpyne, kde-frameworks-devel, michaelh, ngraham,

D18138: KRatingPainter: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R236:1449db57aa67: KRatingPainter: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D18138: KRatingPainter: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18137: delete copy constructor and assignment operator of some public classes

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18136: kconfig_compiler: delete the assignment operator and copy constructor

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY of the generated class that has a pointer and raw copy would be bad. Those generated classes are internal and nobody

D18135: KEmailSettings: Delete copy constructor and assignment operator

aacid updated this revision to Diff 49107. aacid added a comment. typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18135?vs=49106=49107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 AFFECTED FILES src/core/kemailsettings.h

D18135: KEmailSettings: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18134: KEncodingProber: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18081: Make translations work

aacid closed this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D18081 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

aacid added a comment. In D10446#389972 , @dhaumann wrote: > Btw, wouldn't this be a good candidate to upstream to Qt itself? You'd have to import all our .desktop files containing all the translations of all languages to all langauges.

D10446: Add KLanguageName

aacid added a comment. Two more small comments from my side, otherwise looks cool :) Thanks for the perseverance! I can't approve it because the review is on my name ^_^ Maybe @apol can give it the ship it? INLINE COMMENTS > klanguagenametest.cpp:80 > +} > +}; > + Do you

D18081: Make translations work

aacid updated this revision to Diff 49034. aacid added a comment. remove unrelated cmake changes REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18081?vs=48932=49034 BRANCH arcpatch-D18081 REVISION DETAIL https://phabricator.kde.org/D18081 AFFECTED

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18079 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D18076 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

aacid added inline comments. INLINE COMMENTS > klanguagename.cpp:30 > +const QStringList parts = QLocale().name().split(QChar('_')); > +return nameForCodeInLocale(code, parts.at(0)); > +} should the second param be code too? I mean if we read the docs we say both are code (ISO 639-1),

D18081: Make translations work

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Do not call i18n from global static variables since qcoreapplication is still not around yet and that makes it fail

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18079 AFFECTED FILES

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's simpler to understand than K_PLUGIN_FACTORY_WITH_JSON that asks you for a factory name but you never know which name

D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D18030 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18029 To: aacid, apol Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18028: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18028 To: aacid, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars

D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D18030 AFFECTED FILES

D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18029 AFFECTED FILES

D18028: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D18028 AFFECTED FILES

D17938: Add support for passing cursor information to KRun.

aacid added a comment. Encode the information in the url? Also this change is binary incompatible, please see the wiki https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd,

D17969: Use a Kolf icon with nice background and shadows

aacid added a comment. In D17969#386575 , @ndavis wrote: > It seems there are not actually any members in the #kde_games group. I think I'll land this now so that it can be included with KF5.54.

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. In D17651#383320 , @vandenoever wrote > Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/ You need to look harder ;) Those yellow bubbles mean tests are

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. You broke the tests with this change. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

Re: i18n po files : Hooks for number of arguments on SVN

El dimecres, 19 de desembre de 2018, a les 10:11:10 CET, Simon Depiets va escriure: > Hello, > I'm facing an issue with translation of kdeconnect_android, their > res/values/strings.xml ressources file contains : > > > File: %1s > (File %2$d of %3$d) : %1$s > > > Understandably (in KDE/QT

D17681: RFC: Cache translated strings in Job::emit functions

aacid added a comment. That 6% goes to 0% i guess? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

aacid added inline comments. INLINE COMMENTS > sitter wrote in kf5_entry.desktop:1 > Really good point. I've had a look and we only extract src/*. In fact, we > only have Messages.sh in src :) > > This is in line with other frameworks where we have desktop file fixtures. > They all only

D15960: Don't check if file is directory based on mime-type

aacid added a comment. @poboiko You broke the build, please fix it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: aacid, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D10446: Add KLanguageName

aacid added inline comments. INLINE COMMENTS > kf5_entry.desktop:1 > +[KCM Locale] > +Name=Catalan This is going to be a problem, scripty is going to come and whipe these .desktop files out and then make the translators translate them again. Wonder if we could rename them to

Re: Review request: plasma-pass

El dilluns, 10 de desembre de 2018, a les 14:49:28 CET, Daniel Vrátil va escriure: > Hi folks, > > back in May I wrote a Plasma applet that serves as a GUI frontend for the > pass > password manager [0]. I blogged about it [1], but then somewhat forgot to > make > a release etc. Recently I

D17620: Make setHelp() public

aacid added a comment. In D17620#378110 , @yurchor wrote: > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. > > Just a side note: the protected method is

D17620: Make setHelp() public

aacid added a comment. You can always just use QMetaObject::invokeMethod it's a bit lame, but slots are never really non-public if you use the metaobject system INLINE COMMENTS > elvisangelaccio wrote in kconfigdialog.h:176 > If I'm not mistaken, moving a function from `protected` to

Re: Kopete and Libjingle

El divendres, 14 de desembre de 2018, a les 17:19:26 CET, Jonathan Riddell va escriure: > > This patch needs tested for Kopete > https://phabricator.kde.org/D13231 > > But I don't know how to test it. Does anyone use jabber and video > conferencing through it with libjingle? > > I signed up

D17500: Restore mobipocket extractor

aacid added a comment. I would really like the module to be in the mobipocket repo, would serve as actual proof the extractors outside the main module work if we have an example of it :) INLINE COMMENTS > FindQMobipocket.cmake:1 > +# - Find QMobipocket > +# Find the Qmobipocket library.

D10446: Add KLanguageName

aacid added a comment. In D10446#376825 , @sitter wrote: > Stacking the functions seems to work fine > > QString KLanguageName::nameForCode(const QString ) > { > const QStringList parts = QLocale().name().split(QChar('_')); >

D10446: Add KLanguageName

aacid added a comment. > @aacid what were the changes you had planned here? As Aleix mentioned the two methods can probably be made to call eachother, or maybe not, but needs to be investigated and an answer given to why not if not possible. REPOSITORY R265 KConfigWidgets REVISION

D17500: Restore mobipocket extractor

aacid added a comment. In D17500#375753 , @astippich wrote: > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( > Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail

D17491: Fix documentation, QValueList isn't a thing anymore

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17491 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17500: Restore mobipocket extractor

aacid added a comment. I'm afraid this could be a bit of a dependency loop since kdegraphics-mobipocket has a thumbnailer that depends on kio which is a tier 3 framework while kfilemetadata is a tier2 framework. Is it possible to move the extractor to kdegraphics-mobipocket instead of

Re: KDE Frameworks web page

El dilluns, 10 de desembre de 2018, a les 14:43:14 CET, Jonathan Riddell va escriure: > Frameworks has no web page and the announcements still point to the > 5.0 announcement for more information. > > So here's a proposal for adding to kde.org/products/ > >

Re: Kleopatra devel

El divendres, 7 de desembre de 2018, a les 17:01:54 CET, Luc Lalonde va escriure: > Hello, > > I would like to help with development with the Kleopatra/GPG4win project. If noone answers here try at the kdepim mailing list https://mail.kde.org/mailman/listinfo/kde-pim Cheers, Albert > >

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

El dimecres, 5 de desembre de 2018, a les 19:38:12 CET, Allan Sandfeld Jensen va escriure: > On Dienstag, 4. Dezember 2018 18:10:44 CET Thiago Macieira wrote: > > On Monday, 3 December 2018 01:30:25 PST René J.V. Bertin wrote: > > > Can't you just configure the CI to use Qt 5.10? I think it's not

Re: [QUESTION] KIO slave-socket shortcut - does it exist?

El dimarts, 4 de desembre de 2018, a les 16:37:34 CET, Smits Katze va escriure: > Background: I want to sandbox KDE apps and need to understand better how > KIO works. > > My current level of understanding is that apps ask klauncher/kdeinit for a > KIO slave if they need one. Then either kdeinit

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

El dimarts, 4 de desembre de 2018, a les 20:13:43 CET, Ben Cooksley va escriure: > On Wed, Dec 5, 2018 at 7:22 AM Albert Astals Cid wrote: > > > > El dimarts, 4 de desembre de 2018, a les 18:10:44 CET, Thiago Macieira va > > escriure: > > > On Monday, 3 Decem

Re: Time formats / LC_TIME challenge for 4-digit year support

El dilluns, 3 de desembre de 2018, a les 14:47:56 CET, Jaroslaw Staniek va escriure: > Hello, > The need: 4-digit year support for short date formats to avoid issues like > "10/11/12" dates. What's wrong with 10/11/12 ? > > This is just my initial conclusion from for the Qt date format issue:

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

El dimarts, 4 de desembre de 2018, a les 18:10:44 CET, Thiago Macieira va escriure: > On Monday, 3 December 2018 01:30:25 PST René J.V. Bertin wrote: > > Can't you just configure the CI to use Qt 5.10? I think it's not good to > > hardcode an "overzealous" (for lack of a better word) Qt version

D16949: Support for TLS 1.3 (part of Qt 5.12)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d48a506d83e1: Support for TLS 1.3 (part of Qt 5.12) (authored by aacid). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16949?vs=45637=46658 REVISION DETAIL

Re: Increasing KF5 cmake requirement to 3.5?

El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid va escriure: > El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va > escriure: > > > -Original Message- > > > I'm going to suggest it to increase it to 3.6, it would

D16949: Support for TLS 1.3 (part of Qt 5.12)

aacid added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16949 To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added a comment. the documentation is mising a @since 5.SOMETHING REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

aacid accepted this revision. aacid added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.h:92 > + * > + * Default arguments @since 5.53 > */ Change "Default arguments @since 5.53" to "name default argument @since 5.53" REPOSITORY

Re: Question about KNewStuff *.knsrc files and manualy installation

El dimecres, 21 de novembre de 2018, a les 17:36:47 CET, Никита Сиргиенко va escriure: > For example, we have KDE Aplication program with knsrc files for > KNS3::DownloadDialog (from KHotNewStuff - KDE Framework). > Acording to documentation ( >

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added inline comments. INLINE COMMENTS > lsartorelli wrote in ktoggleshowmenubaraction.cpp:77 > Do you suggest to add a warning in case of no shortcut? > The only options I am thinking of are > to tell the user add the missing shortcut via system settings, > to tell the user to modify the

D16983: Add 48px firewall-applet* icons

aacid added a comment. These symlinks as they stand are not poinless, they are wrong. Icon sets are not "targeting a particular piece of software", icon sets are system wide and any software can ask for a given icon, so firewall-applet-shields_up symlinking to firewall-config in size 48

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added inline comments. INLINE COMMENTS > ktoggleshowmenubaraction.cpp:77 > +KMessageBox::information(d->window, tr("This will hide the menu bar > completely." > +" You can show it again by > typing

D16983: Add 48px firewall-applet* icons

aacid added a comment. I'm sorry but this makes no sense at all, why is firewall-applet-error now suddenly firewall-config? And why do you say users will never need a 48px verison of it? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16983 To: ndavis,

Re: firewall-applet icons break breeze auto tests

El dissabte, 17 de novembre de 2018, a les 20:43:04 CET, Noah Davis va escriure: > On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va > escriure: > > > On Saturday, November 17

Re: Increasing KF5 cmake requirement to 3.5?

El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va escriure: > > -Original Message- > > I'm going to suggest it to increase it to 3.6, it would still most > probably be a lie > > since i don't think any of use uses such an old (2 years version) either > > We

D16963: Fix running kdoctools-install autotest without kdoctools installed

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Works, I'm not a kdoctools *real* expert so maybe you want to wait for someone else to approve, but i'd say just commit, i mean i don't think it's worse than what we have now and the test

<    9   10   11   12   13   14   15   16   17   18   >