Re: KJournald in KDE-Review

Hi Kai, many thanks for this very detailed review! For the nitpicks, I did a first cleanup. Some of the not low hanging fruits regarding UI and features I added to the backlog items in the Invent project. More details below. Cheers, Andreas On Donnerstag, 3. November 2022 14:58:06 CET Kai Uwe

Re: KJournald in KDE-Review

On Sonntag, 23. Oktober 2022 10:34:36 CET Andreas Cord-Landwehr wrote: > Hi, just a short update: Thank you for the comments! Nearly all of them are > already fixed. For a very few I created invent.k.o issues instead, because > they are mostly a maintainability concern and make sen

Re: KJournald in KDE-Review

Hi, just a short update: Thank you for the comments! Nearly all of them are already fixed. For a very few I created invent.k.o issues instead, because they are mostly a maintainability concern and make sense to fix together with planned features (e.g. removal of fixed colors when refactoring

Re: KJournald in KDE-Review

On Mittwoch, 12. Oktober 2022 03:56:03 CEST Aleix Pol wrote: [...] > Then I'd recommend to only make it public API when the time comes. :) > > +1 to making it optional instead, if it makes your life any better. > That said, when we've needed this kind of flexibility in the past, we > have often

Re: KJournald in KDE-Review

On Montag, 10. Oktober 2022 15:34:30 CEST Aleix Pol wrote: > On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr [...] > > Even though KJournald is currently contained in the "libraries" playground > > module, I would like to get it included in the "utilities"

KJournald in KDE-Review

Hi, after a few releases over the past year, I would like to get KJournald included in KDE application releases. This project is about providing both an QItemModel abstraction library for the C-style journald API and providing an efficient graphical browser for journald logs. Sysadmins moved

Re: Complex License in KI18n and KConfig Frameworks

Hi Ayush, thank you for bringing this topic up to the mailing list. From the choice of licenses, IMHO it comes to either use a permissive license that is compatible with as much source code as possible (that would be probably either MIT or BSD-2-Clause) or using a smallest common denominator

Re: Extending the license policy to include ODbL-1.0

On Mittwoch, 15. September 2021 17:34:00 CEST Harald Sitter wrote: > +1 +1 also from me! I think this license fits well into our approved license landscape and should not make any issues regarding code/data portability between the different KDE projects. Cheers, Andreas

Re: Package License Metadata for Tooling

use the metadata from the yaml files 4. integrate updated metadata files into Yocto tooling to get rid of manual maintenance :) Cheers, Andreas * == unmuted themselves at least once :) On Dienstag, 22. Juni 2021 08:29:11 CEST Andreas Cord-Landwehr wrote: > Hi, yesterday morning Helio and

Package License Metadata for Tooling

Hi, yesterday morning Helio and me had an interesting discussion about metadata for license check tooling. There are a few different use cases: - Helio needs those for his FOSS license tooling - I would really like to improve the generation of Yocto license metadata, which we currently have to

Re: KDE Frameworks 6 - Virtual Sprint setup

On Sonntag, 31. Januar 2021 16:04:32 CET Christoph Cullmann wrote: > On 2021-01-30 12:14, Volker Krause wrote: > > On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > >> Hello, > >> I've been talking with David Faure about setting up a Sprint focused > >> on KF6 > >> work. Some of the

Re: KDE Frameworks 6 - Virtual Sprint setup

On Sonntag, 31. Januar 2021 16:04:32 CET Christoph Cullmann wrote: > On 2021-01-30 12:14, Volker Krause wrote: > > On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > >> Hello, > >> I've been talking with David Faure about setting up a Sprint focused > >> on KF6 > >> work. Some of the

Re: CI testing with local files

On Donnerstag, 28. Januar 2021 10:20:54 CET Konstantin Kharlamov wrote: > On Wed, 2021-01-27 at 17:36 -0500, Michael Reeves wrote: > > Is there way to reading and writing small files in the CI? I'm in the > > process of writing auto tests for kdiff3. > > Your tests could create a directory inside

Re: CI testing with local files

On Donnerstag, 28. Januar 2021 10:20:54 CET Konstantin Kharlamov wrote: > On Wed, 2021-01-27 at 17:36 -0500, Michael Reeves wrote: > > Is there way to reading and writing small files in the CI? I'm in the > > process of writing auto tests for kdiff3. > > Your tests could create a directory inside

Re: Clarification on licenses and use of MPLv2 in GPLv3+ software

Hi Johnny, I read it exactly the same way. So this looks completely fine to me. Yet, I would suggest to have a look at REUSE compatible license statements, which make it much easier to see which files are under which license. Even if one should not refer to oneself for reference, here is a

Re: Question about copyright notices

On Freitag, 25. September 2020 21:53:49 CEST Matthieu Gallien wrote: [...] > What would be the way to build a consensus on this subject inside KDE ? Hi, we dissolved the licensing mailing list some time ago in favor to move such discussions on the community list. However, copyright year bumps

Re: Question about copyright notices

On Montag, 21. September 2020 22:32:37 CEST Matthieu Gallien wrote: > Is there some consensus as to what is best for code hosted by the KDE > community ? Hi, that is a good question! I cannot recall that we discussed this during the last decade. Anyways, there is not a documented consensus

Re: Extend metainfo.yaml files with License Information

On Dienstag, 18. August 2020 12:34:42 CEST Harald Sitter wrote: [...] > > Ouch, yes, the obvious choice, no idea why I did not see that by myself :) > > Yes, SPDX expressions should be the obvious way to go IMO. For the > > questions: - for libraries, I agree that the target name should be > >

Re: Extend metainfo.yaml files with License Information

Thanks! I will answer inline: On Montag, 17. August 2020 17:47:40 CEST Harald Sitter wrote: [...] > > **First question:** Shall we only list ONE or ALL licenses, same for the > > license information overview that should be on api.kde.org? > > The primary use would be api.kde.org, no? A third

Extend metainfo.yaml files with License Information

Hi, I am currently looking into extending our metainfo.yaml files to provide information about the outbound licenses of the artefacts that are provided by a framework. Here a few examples: Attica: Provides libattica, which is legally OK to be used as LGPL-2.1 or LGPL-3.0 (and of course also as

License Clarification for eps.cpp and eps_p.h (KImageFormats)

Hi Dirk, 22 years ago, you committed some files to the KDE repositories. Thanks again for this :) Now, I am looking into the license statements of two of your files:

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr abandoned this revision. cordlandwehr added a comment. move merge request to Gitlab REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: CMake source files without license

[...] > SPDX-License-Identifier: BSD-3-Clause > sounds like a great idea for default default CMakeLists.txt header Hi, actually we already have that statement in our KDE licensing policy [1] since several years that CMake files shall be licensed under BSD. The policy defaults to BSD-2-Clause

License Clarification in KPackage

Hi Sebas, hi Aaron, while converting the license headers in KPackage to SPDX expressions I found one file that has an unclear license statement and names both LGPL and GPL. As all other files in the repository are LGPL-2.0-or-later, I suspect that you meant it also to have that license...

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr added a comment. Another ping... This merge request is lying around already quite some time (sorry for being so big) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr added a comment. Ping :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R249:10971279a3e7: Ki18n: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75592=78740

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert copyright headers to SPDX expressions and add license texts as required by REUSE specification.

D27741: KCodecs: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. cordlandwehr marked an inline comment as done. Closed by commit R270:25365771652b: KCodecs: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D27738: KCoreAddons: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R244:93480398b551: KCoreAddons: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr marked 4 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Regarding the removal of the COPYING.LIB file, I would prefer to wait and remove all of them in all repositories in one run. It will be a trivial script to review. My main argument is that I did not yet remove them in other pull requests, so for consistency I

D27741: KCodecs: Convert license statements to SPDX expressions

cordlandwehr marked an inline comment as done. cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in Big5Freq.tab:3 > You added "Netscape Communications Corporation" on other files but not this > one. (IMO, you shouldn't, Netscape is explicitly mentioned only in >

D27738: KCoreAddons: Convert license statements to SPDX expressions

cordlandwehr marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: KCoreAddons: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 78217. cordlandwehr added a comment. Remove explicit SPDX identifier for included code REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27738?vs=76681=78217 BRANCH sdpx REVISION DETAIL

D27429: ThreadWeaver: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R279:9a3095522026: ThreadWeaver: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cordlandwehr updated this revision to Diff 78215. cordlandwehr added a comment. Revert change REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27429?vs=75756=78215 BRANCH spdxHeaders REVISION DETAIL https://phabricator.kde.org/D27429 AFFECTED

D27601: KConfig: Convert to SPDX license statements

cordlandwehr closed this revision. cordlandwehr added a comment. arc land was not automatically detected, landed with commit: https://cgit.kde.org/kconfig.git/commit/?id=43d4f1276b3afe259907add9b458f15252514fa4 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27601

D27601: KConfig: Convert to SPDX license statements

cordlandwehr updated this revision to Diff 78213. cordlandwehr added a comment. Merge branch 'master' into spdx REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27601?vs=76675=78213 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601

D27428: KItemViews: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R276:e0f581ec220c: KItemViews: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE

D27742: Solid: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R245:de5a0c3435e8: Solid: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27742?vs=76691=78210

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Ping :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr added a comment. Gently "ping", does anybody has a little bit of time to review this? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28056: KWindowSystem: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R278:d67cc57cf067: KWindowSystem: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D28058: KWayland: Convert license headers to SPDX

This revision was automatically updated to reflect the committed changes. Closed by commit R127:09147becf9b1: KWayland: Convert license headers to SPDX (authored by cordlandwehr). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28058?vs=77657=0 REVISION

D28058: KWayland: Convert license headers to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28058 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28058: KWayland: Convert license headers to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as required by REUSE specification.

D28056: KWindowSystem: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28056 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28056: KWindowSystem: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files according to REUSE specification.

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R282:fa9ef0d84898: NetworkManager-Qt: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D27932 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added a reviewer: jgrulich. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as

D27769: modemmanager-qt: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R281:8ad494d957ca: modemmanager-qt: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D27769: modemmanager-qt: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added a reviewer: jgrulich. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as

D27769: modemmanager-qt: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D27769 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: KCodecs: Convert license statements to SPDX expressions

cordlandwehr retitled this revision from "Convert license statements to SPDX expressions" to "KCodecs: Convert license statements to SPDX expressions". REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack,

D27738: KCoreAddons: Convert license statements to SPDX expressions

cordlandwehr retitled this revision from "Convert license statements to SPDX expressions" to "KCoreAddons: Convert license statements to SPDX expressions". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n,

D27742: Solid: Convert license headers to SPDX expressions

cordlandwehr retitled this revision from "Convert license headers to SPDX expressions" to "Solid: Convert license headers to SPDX expressions". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27742: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as required by REUSE specification.

D27742: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX expressions and add license files as required by REUSE specification.

D27738: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX expressions and add license files as required by REUSE specification.

D27640: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH templatesusespdxlicensestyle REVISION DETAIL https://phabricator.kde.org/D27640 To: kossebau, #plasma, cordlandwehr Cc: kde-frameworks-devel, LeGast00n,

D27243: KQuickCharts: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R1049:b294f7fb337e: KQuickCharts: Convert license headers to SPDX statements (authored by cordlandwehr). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. So, how to move forward with this change? The two open discussion points are: - How to handle COPYING files? --> IMO this is a general question that I want to address in a global change when we updated all the license headers. For this I created a task to

D27601: KConfig: Convert to SPDX license statements

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Reverted license change for the XSD file. Right now I do not see any equivalent in the SPDX registry. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr Cc: ognarb,

D27601: KConfig: Convert to SPDX license statements

cordlandwehr updated this revision to Diff 76675. cordlandwehr added a comment. Reverting DTD license change REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27601?vs=76403=76675 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601 AFFECTED

D27640: templates: Convert license statements to SPDX headers

cordlandwehr added a comment. Looks good to me and I agree that it is a good idea to consistently license everything as LGPL-2.1-or-later. My only question is, how is the X-KDE-PluginInfo-License value is evaluated? Are we free to write any value? Or do we have to extend some mechanism? I

D27363: KHolidays: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R175:1bc908a8cfea: KHolidays: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D27601: KConfig: Convert to SPDX license statements

cordlandwehr updated this revision to Diff 76403. cordlandwehr added a comment. Better handling of explenatory texts REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27601?vs=76224=76403 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601

D27601: KConfig: Convert to SPDX license statements

cordlandwehr marked 3 inline comments as done. cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in kcfg.xsd:20 > What makes you think it's BSD? Actually, I though quite a time about this and at the end did a comparison of the permissions specifically provided by this

D27602: KDbusAddons: Convert license statement to SPDX

This revision was automatically updated to reflect the committed changes. Closed by commit R271:a222808f86cd: KDbusAddons: Convert license statement to SPDX (authored by cordlandwehr). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27602?vs=76225=76401

D27603: KDNSSD: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R272:563fc1416d90: KDNSSD: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27603?vs=76226=76400

D27586: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. cordlandwehr added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kossebau wrote in main.cpp:31 > Hmpf, that slipped me. The regular expression overdoing its job :) > I guess that will be hit in more KAboutData instances.

D27603: KDNSSD: Convert license headers to SPDX statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX statements and add license files as required by SPDX specification

D27603: KDNSSD: Convert license headers to SPDX statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D27603 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27602: KDbusAddons: Convert license statement to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license files as required by REUSE. REPOSITORY R271

D27602: KDbusAddons: Convert license statement to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27602 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX statements and add license files as required by REUSE specification.

D27586: templates: Convert license statements to SPDX headers

cordlandwehr requested changes to this revision. cordlandwehr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:31 > KAboutLicense::GPL, > -i18n("Copyright %{CURRENT_YEAR} %{AUTHOR}")); > +i18n("SPDX-FileCopyrightText:

D27587: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. cordlandwehr added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R39 KTextEditor BRANCH spdxlicensefortemplate REVISION DETAIL https://phabricator.kde.org/D27587 To: kossebau, #kate, cordlandwehr Cc: kwrite-devel,

D27588: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH spdxlicensefortemplate REVISION DETAIL https://phabricator.kde.org/D27588 To: kossebau, cordlandwehr, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Did additional code digging in the Plan repository and I think that all stated copyright claims are valid. INLINE COMMENTS > cgiboudeaux wrote in holidayparserdriverplan.cpp:6-13 > The original text lacks clarity.

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 2 inline comments as done. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 76151. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Add missing SPDX identifier REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75737=76151 BRANCH spdx REVISION DETAIL

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. In D27245#614915 , @kossebau wrote: > What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy `LICENSES/LGPL-2.1-only.txt`? > Or are both

Re: New Framework Review: KDAV

On Sonntag, 16. Februar 2020 10:29:42 CET Volker Krause wrote: > On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > > Hi, sorry for this very late mail, missed the call for reviews... > > > > Would it be possible to do some license clarificatio

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D27429 To: cordlandwehr Cc: kde-frameworks-devel, mirko, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Add license files are required by REUSE and add license files as reuqired by REUSE. Please note the

D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification.

D27428: KItemViews: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: New Framework Review: KDAV

Hi, sorry for this very late mail, missed the call for reviews... Would it be possible to do some license clarifications before moving kdav into the frameworks section? In mostly all files it is not clear if the LGPL or the GPL is meant (stating "GNU Library General Public License" and

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75737. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Make snippet copyright statement more verbose REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75736=75737 BRANCH

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 5 inline comments as done. cordlandwehr added a comment. Updated several statements, but still need clarification if named people are copyright holders or contributors without copyright claim. INLINE COMMENTS > cgiboudeaux wrote in holidayscannerplan.cpp:1297-1301 > and

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 75736. cordlandwehr added a comment. Clarified several statements - Recovered origin of weekNumber method and its original license - Unified verbose license statements - Clarified snippet licensing REPOSITORY R175 KHolidays CHANGES SINCE

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only license text: https://github.com/fsfe/reuse-tool/issues/178 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: cgiboudeaux,

  1   2   3   >