Re: Should we stop distributing source tarballs?

On Friday, 5 April 2024 12:04:28 CEST, Albert Vaca Cintora wrote: It seems a lot of people feel conservative in favor of tarballs, so maybe I aimed too far. At least I think the discussion brought some interesting points that we can explore further. Some I identified: - The tarballs should

Re: Should we stop distributing source tarballs?

On Thursday, 4 April 2024 13:26:57 CEST, Sune Vuorela wrote: On 2024-04-04, Ben Cooksley wrote: I do also think it is nice if we get someone else to verify that the tarball we ship actually matches the tag. I think some people in distributions have already started looking into verifying that.

Re: Should we stop distributing source tarballs?

On Thursday, 4 April 2024 13:07:42 CEST, Ben Cooksley wrote: [snip] As an additional aside - we don't currently GPG sign our Git tags, so there is nothing validating that the person who made the release is actually the person whose name is on it. With GPG signatures we can at least validate who

Re: AppStream Metadata with our releases

On Tuesday, 26 March 2024 17:39:25 CET, Volker Krause wrote: On Dienstag, 26. März 2024 08:59:29 CET Heiko Becker wrote: On Monday, 25 March 2024 23:23:01 CET, Albert Astals Cid wrote: ... Sorry about that! I try to keep both branches in sync usually, if there is anything I can do/do

Re: AppStream Metadata with our releases

On Monday, 25 March 2024 23:23:01 CET, Albert Astals Cid wrote: El dissabte, 23 de març de 2024, a les 21:06:46 (CET), Julius Künzel va escriure: 22.03.2024 17:22:33 Albert Astals Cid : ... It is some extra work (not a lot, but some). You're asking for the workflow of creating to be releases

Re: KDE Gear projects with failing CI (release/24.02) (20 February 2024)

On Tuesday, 20 February 2024 22:30:56 CET, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good News: 11 failing repositories from previous report got

Re: KDE Gear projects with failing CI (release/24.02) (20 February 2024)

On Tuesday, 20 February 2024 22:30:56 CET, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good News: 11 failing repositories from previous report got

Re: KDE Gear projects with failing CI (release/24.02) (6 February 2024)

On Tuesday, 6 February 2024 22:24:22 CET, Albert Astals Cid wrote: Bad news: 3 repositories are still failing and 11 new repositories started failing kdialog - NEW * https://invent.kde.org/utilities/kdialog/-/pipelines/601189 * flatpak fails in icon-not-found kmag - NEW *

KDE Gear 24.02 bug fix releases and next Gear releases

Hi everyone, the question of the next Gear release (after 24.02) came up in #kde-devel yesterday evening. Due to this, it also occured to me that we haven't scheduled any bug fix releases for 24.02 itself. Which is a bit connected to the first question, because I guess we don't want too many

Re: QML: a packagers nightmare. Assistance please.

On Wednesday, 8 November 2023 12:48:32 CET, David Redondo wrote: So the situation right now is that plasma-workspace build depends on KWin and KWin has a runtime dependency on plasma-workspace. I think it's not a full cycle since installing plasma-workspace does not need anything from KWin

Suggestion to drop kopete from KDE Gear

Hello, I wanted to keep kopete at least buildable against recent version of its dependencies by removing some obsolete parts. But it occured to me that if I were to continue with that, there wouldn't be much left. It suffers from the same problems with dead or (at least dying) protocols I

Re: KDE Gear projects with failing CI (master)

On Tuesday, 4 July 2023 22:47:12 CEST, Albert Astals Cid wrote: Please work on fixing them, otherwise i will eventually remove the failing CI jobs, it is very important that CI is passing for multiple reasons. = MISC FAILURES (4 repos) = kontrast: *

Re: version numbers towards kf6

On Monday, 26 June 2023 17:32:18 CEST, Jos van den Oever wrote: On 26/06/2023 17.27, Heiko Becker wrote: On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote: ... So that the user can see that they are running a snapshot and not an official release and to make it easy to report

Re: version numbers towards kf6

On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote: On 26/06/2023 13.15, Heiko Becker wrote: On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote: The new versions of frameworks, plasma and gear presumably all start with '6'. Following Fedora versioning for snapshots [0

Re: version numbers towards kf6

On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote: The new versions of frameworks, plasma and gear presumably all start with '6'. Following Fedora versioning for snapshots [0] gives this: 6^20230627git5328c27e3 Like Jonathan said, versioning of snapshots is a downstream thing.

Re: Proposal to deprecate KFloppy

On Friday, 28 April 2023 15:16:29 CEST, Nate Graham wrote: Does it work for *anyone* with a modern distro? If not, then I think archiving it makes sense. Time marches on. :) If it does work for *someone* with a modern distro then at the very least the UI needs to detect when it will be broken

Usage of KF5/KF6 in targets and CMake config files outside of Frameworks

Hi, while looking at a MR for libkcddb (part of Gear) I wondered if the transition from Qt5/KF5 to Qt6/KF6 could be used to get rid of the KF5/6 prefix in target names and CMake config files for libraries that aren't acutally part of Frameworks. It always seemed a bit illogical and possibly

Usage of KF5/KF6 in targets and CMake config files outside of Frameworks

Hi, while looking at a MR for libkcddb (part of Gear) I wondered if the transition from Qt5/KF5 to Qt6/KF6 could be used to get rid of the KF5/6 prefix in target names and CMake config files for libraries that aren't acutally part of Frameworks. It always seemed a bit illogical and possibly

Re: Bringing Cantata under the KDE umbrella?

On Tuesday, 21 February 2023 16:23:54 CET, Sandro Knauß wrote: I really would love to see Cantata to be in KDE. At least try if it gets some momentum. But still you are doing the Qt6 port, so without any new features just in maintenance mode I see value in it. features like cached lyrics,

Re: Bringing Cantata under the KDE umbrella?

On Tuesday, 21 February 2023 07:04:03 CET, Harald Sitter wrote: On Mon, Feb 20, 2023 at 1:18 PM Aleix Pol wrote: On Mon, Feb 20, 2023 at 12:28 AM Heiko Becker wrote: ... +1. That said, what we could do is incubate into playground and see if we can assemble the required "Healthy

Re: Bringing Cantata under the KDE umbrella?

On Sunday, 19 February 2023 23:36:22 CET, Albert Astals Cid wrote: My only 2 concerns are: * Is anyone going to work on it? I guess you? * Can we have an agreement by the original author so we can take over the trademark? I got an answer from him: "You are more than welcome for fork

Re: Bringing Cantata under the KDE umbrella?

On Monday, 20 February 2023 13:18:02 CET, Aleix Pol wrote: On Mon, Feb 20, 2023 at 12:28 AM Heiko Becker wrote: Part of the incubation process is to gather what's the team working on it. https://community.kde.org/Incubator/Projects/DescriptionTemplate It feels wrong to incubate a project

Re: Bringing Cantata under the KDE umbrella?

On Sunday, 19 February 2023 23:36:22 CET, Albert Astals Cid wrote: El diumenge, 19 de febrer de 2023, a les 16:29:24 (CET), Heiko Becker va escriure: Cantata is a Qt based MPD client, which was archived by its original author [1]. I started some porting to Qt6 but I wondered (and was asked

Bringing Cantata under the KDE umbrella?

Hi, Cantata is a Qt based MPD client, which was archived by its original author [1]. I started some porting to Qt6 but I wondered (and was asked in #kde-devel today) if it would make sense to move it to KDE's infrastructure? Despite being archived, it still works quite nicely. And while

Re: Request to relicense all CC0-1.0 code to MIT (or similar permissive license)

On Sunday, 22 January 2023 18:01:35 CET, Albert Astals Cid wrote: El diumenge, 22 de gener de 2023, a les 14:12:32 (CET), Neal Gompa va escriure: During a review for flatpak-kcm for inclusion in Fedora, I discovered that KDE currently licenses its CI scripts under the CC0 (SPDX: CC0-1.0)

Re: New releases for bugfixes

On Thursday, 8 September 2022 13:59:43 CEST, Ahmad Samir wrote: From the git-archive manual page: «git archive behaves differently when given a tree ID versus when given a commit ID or tag ID. In the first case the current time is used as the modification time of each file in the archive. In

Re: Missing product versions in Bugzilla

On Sunday, 24 July 2022 01:15:09 CEST, Nate Graham wrote: IIRC, the release team takes care of updating product-versions of apps on Bugzilla using a script. CCing them. Yes, we do. At least for projects passing their version number to project() in CMakeLists.txt [1] and if the project name

Re: Request to bump QT_MIN_VERSION to 5.15.2 for whole Plasma

Hello, On Sunday, 26 June 2022 13:52:23 CEST, Ömer Fadıl USTA wrote: Right now plasma projects' minimum depends on KF >5.90 and after KF5.86 its REQUIRED_QT_VERSION is 5.15.2 thus keeping QT_MIN_VERSION as 5.15.0 is meaningless and it also causes problems such as in this merge :

Re: The KDE Patchset Collection has been rebased on top of Qt 5.15.3

On Sunday, 6 March 2022 19:32:57 CET, Neal Gompa wrote: This whole thing has been a terrible mess and it's extremely frustrating. It's caused problems for the development of the last couple of Fedora releases, too. Can we scale back the language please? I get that you're not happy, but

KDE Gear 21.12 release branches created

Please make sure you commit anything you want to end up in the 21.12 releases to them. We're already past the dependency freeze, so no new dependencies or increasing of dependency versions in the stable branches. The feature freeze, tagging and release of the beta (21.11.80) is in four

Re: Is Krename buglist ABANDONED?

Hi, On Thursday, 29 July 2021 00:01:15 CEST, Rafael Linux User wrote: Someone wrote this is fhe right e-mail to ask about it and to take some actions about the issue. https://bugs.kde.org/show_bug.cgi?id=439293 it's just that time is a scarce resource and while krename works fine for my

KDE 21.08 dependency freeze in

Dependency freeze for KDE Gear 21.08 is in six days (July 8, 23:59 UTC), please make sure to update all the needed dependencies before that date. Next interesting dates: July 15: 21.08 Freeze and Beta (21.07.80) tag & release ... August 12: 21.08.0 Release More at:

Re: KDE's Official Standlaone application packages are missing translations for some basic buttons

On Wednesday, 16 June 2021 11:55:32 CEST, Luigi Toscano wrote: Generally speaking: 1) It only affects DIALOGUES' basic buttons like "OK", "Cancel", "Help" and so on. 2) It affects all languages. 3) It happens only on KDE's official, standalone builds. Packages provided by Linux distros are

21.04 release service schedule

Hello everyone, the release team agreed on a schedule for the upcoming release service 21.04: https://community.kde.org/Schedules/release_service/21.04_Release_Schedule Dependency freeze is in 5 weeks and feature freeze one after that. Get your stuff ready! Cheers, Heiko

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

heikobecker added a comment. In D29303#677015 , @dfaure wrote: > So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. How do we move this or https://phabricator.kde.org/D29136 forward? @ilic As a maintainer, do you have an opinion? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc:

D29136: Use non-deprecated KDEInstallDir

heikobecker reclaimed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

heikobecker abandoned this revision. heikobecker added a comment. Abandoned in favour of https://phabricator.kde.org/D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. Fixes the problem I had with marble, which prompted the creation of https://phabricator.kde.org/D29136. Passing the destination as an parameter seems indeed like a better way, so +1 from me. REPOSITORY R249 KI18n REVISION DETAIL

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. In D29136#660270 , @kossebau wrote: > using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps

D29136: Use non-deprecated KDEInstallDir

heikobecker updated this revision to Diff 81035. heikobecker added a comment. Added missing parentheses REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29136?vs=81033=81035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29136 AFFECTED FILES

D29136: Use non-deprecated KDEInstallDir

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I noticed that when installeding marble, which sets KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a

D28108: Handle busybox's sed like GNU sed

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0855a40a1131: Handle busyboxs sed like GNU sed (authored by heikobecker). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28108?vs=77864=77880 REVISION DETAIL

D28108: Handle busybox's sed like GNU sed

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise it uses the POSIX-style and fails with "sed: : No such file

D25795: Rename kf5quickcharts_example to kquickcharts_example

heikobecker closed this revision. heikobecker added a comment. In D25795#612749 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker added a comment. In D25794#612748 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have and I already committed it:

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker closed this revision. REVISION DETAIL https://phabricator.kde.org/D25794 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

heikobecker created this revision. heikobecker added reviewers: Frameworks, ahiemstra. heikobecker requested review of this revision. REVISION SUMMARY Matching the project name. TEST PLAN exmaple is installed under the new name, runs fine BRANCH master REVISION DETAIL

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker created this revision. heikobecker added reviewers: Frameworks, ahiemstra. heikobecker requested review of this revision. REVISION SUMMARY Allows the test to run without a display server. TEST PLAN Builds, test still passes BRANCH master REVISION DETAIL

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

On Friday, 25 October 2019 21:15:19 CEST, Friedrich W. H. Kossebau wrote: Am Donnerstag, 24. Oktober 2019, 18:52:34 CEST schrieb laurent Montel: Who told you that it will keep broken ? If we show that it doesn't build we will fix it. I don't see the problem. ... The problem I see is

D21695: Add FindTaglib.cmake

heikobecker added a comment. I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which

D21695: Add FindTaglib.cmake

heikobecker created this revision. heikobecker added reviewers: kde-buildsystem, kde-frameworks-devel. Herald added projects: Frameworks, Build System. heikobecker requested review of this revision. REVISION SUMMARY The old one from KDELibs4 times is used by several projects from Frameworks,

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. > no, it is only used in kio internally by klauncher to start io slaves. at least kinit disagrees: src/klauncher/klauncher.cpp:1021 arg_list.prepend(QLatin1String("kioslave")); REPOSITORY R241 KIO REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. In D17650#379396 , @habacker wrote: > I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ? I'd argue that the problem is with

D17479: Fix build without phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17479?vs=47283=47288 REVISION DETAIL

D17479: Fix build without phonon

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY f6d55baf5aa88eaab6b2f96c025064f081d13cea

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. I can confirm that the crash doesn't occur anymore. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker,

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added a comment. In D15251#322168 , @kossebau wrote: > ...as well as request to finally enable BUILD_QCH on CI, so this is covered. I wondered why that's not the case. I, for one, would welcome it. REPOSITORY R249 KI18n

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15251?vs=40932=41194 REVISION

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added reviewers: kossebau, habacker. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D15251 To: heikobecker, kossebau, habacker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY After 507415c54bd111fbb35716bd9809119d990f9a16

D14008: Use QTEST_GUILESS_MAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by heikobecker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14008?vs=37463=39143 REVISION DETAIL

D14008: Use QTEST_GUILESS_MAIN

heikobecker added a comment. Ping? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D14008 To: heikobecker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

This revision was automatically updated to reflect the committed changes. Closed by commit R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit more detail (authored by heikobecker). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. heikobecker requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION

D14008: Use QTEST_GUILESS_MAIN

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Allowing the tests to pass without a running X server. REPOSITORY R235

D12872: ScalableTest, add "scalable" plasma-browser-integration

heikobecker added a comment. +1 Btw, this is BUG: 393999 REPOSITORY R266 Breeze Icons BRANCH scalable_pbi (branched from master) REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: heikobecker,

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty dir when no po files exist (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker marked an inline comment as done. heikobecker added a comment. Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime. INLINE COMMENTS > ltoscano wrote in KF5I18NMacros.cmake.in:138-139 > I guess that those two lines are the

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I saw this happen with kdecoration from git since

D12216: Don't need to run previous iterations commands again

heikobecker added a comment. In D12216#247225 , @apol wrote: > I'm unsure if it's worth re-spinning ki18n. It's already out, so it would need a .1, but it may be worth it as it appears builds are hanging otherwise. REPOSITORY R249

D12225: Also make installation of translated docs optional

This revision was automatically updated to reflect the committed changes. Closed by commit R317:03d503362514: Also make installation of translated docs optional (authored by heikobecker). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12225?vs=32186=32273

D12225: Also make installation of translated docs optional

heikobecker created this revision. heikobecker added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY 76f3f5b541eea8128297e68bd80278e7f525c1aa

D10340: Clean up old, unreachable code

This revision was automatically updated to reflect the committed changes. Closed by commit R306:7387d21c4516: Clean up old, unreachable code (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10340?vs=26647=27537 REVISION DETAIL

D10339: Drop obsolete version checks

This revision was automatically updated to reflect the committed changes. Closed by commit R306:faf16778ea6b: Drop obsolete version checks (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10339?vs=26646=26660 REVISION DETAIL

D10340: Clean up old, unreachable code

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Nepomuk is never searched for, so the removed code wasn't used in a long time. Furthermore Nepomuk

D10339: Drop obsolete version checks

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Frameworks already require Qt 5.7.0. REPOSITORY R306 KParts BRANCH master REVISION DETAIL

Re: krename in kdereview

On 12/03/17 23:39, Albert Astals Cid wrote: >> It's a batch renamer started outside of KDE and its infrastructure but >> it was kind of abandoned and I got the ok the from the original author >> to move it to git.kde.org. >> >> The code can be found at kde:krename. >> >> [..] > > Maybe you want

D8672: Fix build with LibreSSL

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit R239:00cae452ac61: Fix build with LibreSSL (authored by heikobecker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D8672: Fix build with LibreSSL

heikobecker marked an inline comment as done. heikobecker added inline comments. INLINE COMMENTS > dfaure wrote in ksslcertificate.cpp:1225 > This seems to be missing parenthesis... > > KSSL_HAVE_SSL && ( ... || ... ) Thanks, added. REPOSITORY R239 KDELibs4Support REVISION DETAIL

D8672: Fix build with LibreSSL

heikobecker marked an inline comment as done. heikobecker added inline comments. INLINE COMMENTS > dfaure wrote in kopenssl.cpp:1047 > this syntax will lead to a preprocessor warning when LIBRESSL_VERSION_NUMBER > isn't defined. > Did you mean `|| defined(...)` ? Yeah, that's indeed better...

D8672: Fix build with LibreSSL

heikobecker updated this revision to Diff 23301. heikobecker added a comment. Added define(..) REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8672?vs=21939=23301 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8672 AFFECTED FILES

krename in kdereview

Hello, thanks to the KDE Sysadmins krename was moved to kdereview today. It's a batch renamer started outside of KDE and its infrastructure but it was kind of abandoned and I got the ok the from the original author to move it to git.kde.org. The code can be found at kde:krename. The intended

D8672: Fix build with LibreSSL

heikobecker added a reviewer: FreeBSD. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D8672 To: heikobecker, #frameworks, #freebsd

D8672: Fix build with LibreSSL

heikobecker added a comment. Ping? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D8672 To: heikobecker, #frameworks

D8672: Fix build with LibreSSL

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Unfortunately LibreSSL sets OPENSSL_VERSION_NUMBER to 0x2000L and doesn't support the OpenSSL 1.1 API. TEST PLAN Builds with LibreSSL

D7478: Escape hyphen in rest.xml regular expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ad077e4045e6: Escape hyphen in rest.xml regular expressions (authored by heikobecker). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18602. heikobecker added a comment. Increased version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18584=18602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 AFFECTED

D7478: Escape hyphen in rest.xml regular expressions

heikobecker added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? Wasn't aware of the bug report, but yes. Will add a BUG: reference before pushing if this is accepted. REPOSITORY

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18584. heikobecker added a comment. Removed accidentally included change. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18583=18584 BRANCH master REVISION DETAIL

D7478: Escape hyphen in rest.xml regular expressions

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The unescaped hyphen caused a build failure with pcre2-10.30 due to a broken regex: 'syntax-highlighting/data/syntax/rest.xml" line 27

D7239: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R169:478b31fd1b92: Drop unused dependency (authored by heikobecker). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7239?vs=17984=18528 REVISION DETAIL

D7239: Drop unused dependency

heikobecker added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

n to match the surrounding lines. Diffs - kdeui/CMakeLists.txt d6ec8b47e9af686441ab5ab761be9ff424cbb556 Diff: https://git.reviewboard.kde.org/r/130193/diff/ Testing --- Builds fine with cmake-3.9.0. Thanks, Heiko Becker

Review Request 130193: [cmake]: De-duplicate "else" to fix build with cmake-3.9

556 Diff: https://git.reviewboard.kde.org/r/130193/diff/ Testing --- Builds fine with cmake-3.9.0. Thanks, Heiko Becker

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

heikobecker added a comment. Ping? Not sure what to do with this, still would like to hear something from @skelly. Or should I just go ahead and use ClangConfig.cmake (meaning dropping the version requirement, I don't have any older clang versions around to easily test it.) REPOSITORY

D4051: kcm_useraccount is dead, long live user_manager

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8f81a80f5dd9: kcm_useraccount is dead, long live user_manager (authored by heikobecker). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4051?vs=9935=14061

D4051: kcm_useraccount is dead, long live user_manager

heikobecker added a comment. Ping? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D4051 To: heikobecker, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

heikobecker added a comment. In https://phabricator.kde.org/D5413#102273, @dfaure wrote: > Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing? > Not sure if that works for KF5 components. No, OPTIONAL

  1   2   3   >