D19534: [i18n] compile without foreach

mlaurent closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R289 KNotifications

D19534: [i18n] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R249:e6833a6aa37e: [i18n] compile without foreach (authored by mlaurent). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19534?vs=53179=53198 REVISION DETAIL

D19534: [i18n] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R249 KI18n BRANCH

D19503: Improve code: Remove temp container just to iterate

This revision was automatically updated to reflect the committed changes. Closed by commit R283:d044788ac38d: Improve code: Remove temp container just to iterate (authored by mlaurent). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19503?vs=53098=53116

D19503: Improve code: Remove temp container just to iterate

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove temp container TEST PLAN autotest ok REPOSITORY R283 KAuth BRANCH

D19298: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R283:cd7490e85008: Make it compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19298?vs=52526=53097#toc REPOSITORY R283 KAuth CHANGES SINCE LAST

D19442: [Kfilemetada] Make it compile without foreach

mlaurent added a comment. Arg it was commited by error I reverted it REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19442 To: mlaurent, dfaure, apol, bruns Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, spoorun,

D19442: [Kfilemetada] Make it compile without foreach

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R286:fcb1ec08bde9: [Kfilemetada] Make it compile without foreach (authored by mlaurent). REPOSITORY R286 KFileMetaData

D19494: [kconfigwidgets] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R265:386ea3a786f5: [kconfigwidgets] make it compile without foreach (authored by mlaurent). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19494?vs=53071=53081

D19494: [kconfigwidgets] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R265 KConfigWidgets

D19437: [knewstuff] Remove qt5.13 deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f7fbcc13f518: [knewstuff] Remove qt5.13 deprecated method (authored by mlaurent). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19437?vs=53049=53053 REVISION

D19299: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R244:e4474e7bc1a6: Make it compile without foreach (authored by mlaurent). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19299?vs=53048=53052 REVISION DETAIL

D19437: [knewstuff] Remove qt5.13 deprecated method

mlaurent updated this revision to Diff 53049. mlaurent added a comment. Use exitstatus REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19437?vs=52879=53049 BRANCH remove_deprecated_qt5.13 (branched from master) REVISION DETAIL

D19299: Make it compile without foreach

mlaurent added a comment. for faceicontest it's phabricator which doesn"t like no UTF8 file I converted to utf8 with iconv but it still don't like it... {code} @@ -1,5 +1,5 @@ /* - * Copyright (C) 2014 Nicol341s Alvarez + * Copyright (C) 2014 Nicolás Alvarez -

D19299: Make it compile without foreach

mlaurent updated this revision to Diff 53048. mlaurent added a comment. Fix as requested by david REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19299?vs=52527=53048 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19299: Make it compile without foreach

mlaurent marked an inline comment as done. mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in kpluginmetadata.cpp:233 > needs a const local var, no? people was const. So I thought that it was not necessary. But I created it. REPOSITORY R244 KCoreAddons REVISION DETAIL

D19318: compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R274:b072248cc681: compile without foreach (authored by mlaurent). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19318?vs=52560=53042 REVISION DETAIL

D19319: make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R291:4ac2a1c5eeba: make it compile without foreach (authored by mlaurent). REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19319?vs=52699=53041 REVISION DETAIL

D19326: [Kconfig] Compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R237:38b51667b5ba: [Kconfig] Compile without foreach (authored by mlaurent). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19326?vs=52808=53040 REVISION DETAIL

D19336: [kguiaddons] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R273:3014213a4c94: [kguiaddons] make it compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19336?vs=52606=53039#toc REPOSITORY R273 KGuiAddons

D19455: [knotification] compile without deprecated methods

This revision was automatically updated to reflect the committed changes. Closed by commit R289:6a9ba38e3ea9: [knotification] compile without deprecated methods (authored by mlaurent). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19455?vs=52925=53038

D19436: [kservice] compile without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R309:45337a4c28c3: [kservice] compile without deprecated method (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=53011=53018 REVISION

D19436: [kservice] compile without deprecated method

mlaurent updated this revision to Diff 53011. mlaurent added a comment. Use toSecsSinceEpoch REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=52878=53011 BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL

Re: Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

Hi, I will investigate today. Regards Le vendredi 1 mars 2019, 20:09:54 CET Ben Cooksley a écrit : > Hi Laurent, > > > Thanks for taking a look - unfortunately it looks like this is still > failing? > > > Cheers, > Ben

D19455: [knotification] compile without deprecated methods

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R289

D19442: [Kfilemetada] Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN Autotest ok REPOSITORY R286

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

This revision was automatically updated to reflect the committed changes. Closed by commit R298:0217d5038550: Make it compile with QT_NO_CAST_FROM_ASCII (authored by mlaurent). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19430?vs=52860=52896

D19437: [knewstuff] Remove qt5.13 deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method TEST PLAN autotest ok REPOSITORY R304 KNewStuff

D19436: [kservice] compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R309

D19317: compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R287:f1c6c15b061b: compile without foreach (authored by mlaurent). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19317?vs=52700=52863 REVISION DETAIL

D19418: Make it compiles without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19431: [kitemviews] make it compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated methods TEST PLAN autotest ok REPOSITORY R276

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile QT_NO_CAST_FROM_ASCII TEST PLAN autotests ok REPOSITORY R298

D19418: Make it compiles without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN all autotest ok REPOSITORY R242

D19326: [Kconfig] Compile without foreach

mlaurent edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

mlaurent updated this revision to Diff 52808. mlaurent added a comment. Fixed code as requested by David REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19326?vs=52579=52808 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19396: [kxmlgui] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19396?vs=52794=52802 REVISION DETAIL

D19395: [KJobWidget] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R288:07d140f5a206: [KJobWidget] remove deprecated method (authored by mlaurent). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52793=52801 REVISION

D19396: [kxmlgui] remove deprecated method

mlaurent updated this revision to Diff 52794. mlaurent added a comment. Disable deprecated method until qt5.12 REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19396?vs=52767=52794 BRANCH remove_deprecated_method (branched from master) REVISION DETAIL

D19395: [KJobWidget] remove deprecated method

mlaurent updated this revision to Diff 52793. mlaurent added a comment. Disable deprecated method until 5.12 as requested REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52765=52793 BRANCH remove_deprecated_method (branched from master)

D19395: [KJobWidget] remove deprecated method

mlaurent marked an inline comment as done. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19395 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19396: [kxmlgui] remove deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R263 KXmlGui BRANCH

D19395: [KJobWidget] remove deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R288 KJobWidgets BRANCH

D19387: Remove deprecated QSignalMapper

This revision was automatically updated to reflect the committed changes. Closed by commit R235:8856dfad857b: Remove deprecated QSignalMapper (authored by mlaurent). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19387?vs=52722=52735 REVISION DETAIL

D19387: Remove deprecated QSignalMapper

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QSignalMapper is deprecated in Qt5 REPOSITORY R235 Attica BRANCH

D19317: compile without foreach

mlaurent updated this revision to Diff 52700. mlaurent added a comment. Use auto as requested REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19317?vs=52559=52700 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19317: compile without foreach

mlaurent added inline comments. INLINE COMMENTS > apol wrote in pic.cpp:391 > Probably could do a splitRef here it seems that we can't use it. As it will return a list of QStringRef and we want to use "simplified() on a QStringRef which doesn't exist REPOSITORY R287 KImageFormats REVISION

D19319: make it compile without foreach

mlaurent updated this revision to Diff 52699. mlaurent added a comment. Remove not necessary change REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19319?vs=52561=52699 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19335: [kdoctools] make it compile without foreach

mlaurent added a comment. oops indeed. I landed it and forgot to git pull :) I will close it now :) REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19335: [kdoctools] make it compile without foreach

mlaurent abandoned this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19326: [Kconfig] Compile without foreach

mlaurent retitled this revision from "Compile without foreach" to "[Kconfig] Compile without foreach". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19336: [kguiaddons] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R273 KGuiAddons BRANCH

D19335: [kdoctools] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19326: Compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R237 KConfig BRANCH

D19319: make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R291 KPty BRANCH compile_without_foreach

D19318: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R274 KIdleTime BRANCH

D19317: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R287 KImageFormats BRANCH

D19299: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R244 KCoreAddons BRANCH

D19298: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R283 KAuth BRANCH compile_without_foreach

D19285: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R292:6d3e49e94e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19285?vs=52468=52473 REVISION DETAIL

D19278: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R279:33bd17052e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19278?vs=52452=52474 REVISION DETAIL

D19271: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R238:3fbec01f6f7c: Make it compiles without foreach (authored by mlaurent). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19271?vs=52435=52472 REVISION DETAIL

D19285: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R292 KUnitConversion BRANCH

D19278: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R279 ThreadWeaver BRANCH

D19271: Make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19251: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R243:ff2240350387: Make it compiles without foreach (authored by mlaurent). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19251?vs=52377=52426 REVISION DETAIL

D19251: Make it compiles without foreach

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in krcc.cpp:147 > move to temp var to avoid detaching? dir is const. Will it detach ? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19251 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh,

D19251: Make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REPOSITORY R243 KArchive BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19248: Make it compiles without foreach

mlaurent added a reviewer: dfaure. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D19248 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19248: Make it compiles without foreach

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Allow to compile it without foreach REPOSITORY R270 KCodecs BRANCH compile_without_foreach (branched from

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. Now it's ok for me :) Thanks REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D18873: add baloo engine debugging category

mlaurent added a comment. ecm_qt_declare_logging_category(kio_timeline_SRCS HEADER kio_timeline_debug.h IDENTIFIER Baloo::KIO_TIMELINE DEFAULT_SEVERITY Warning

D18873: add baloo engine debugging category

mlaurent added a comment. DEFAULT_SEVERITY [WARNING] is false too as you don't force it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D18873: add baloo engine debugging category

mlaurent added a comment. Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" CATEGORY_NAME "org.kde.baloo.engine")" it's not Baloo::ENGINE but ENGINE so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category( REPOSITORY R293 Baloo REVISION DETAIL

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Ok so you need to commit this one first and making second patch dependancy against it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

D18873: add baloo engine debugging category

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine

D18638: Avoid using trimmed method

This revision was automatically updated to reflect the committed changes. Closed by commit R246:ef9c9253e5b4: Avoid using trimmed method (authored by mlaurent). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18638?vs=50631=50710 REVISION DETAIL

D18638: Avoid using trimmed method

mlaurent added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18638 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18638: Avoid using trimmed method

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY We don't want to use trimmed() but we want to avoid to call sonnet code for empty text REPOSITORY R246 Sonnet

D18424: Instantiate QApplication before KCrash/KCatalog

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko, mlaurent Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16966: Fix typo in i18n message (cmdline option description)

mlaurent added a comment. no commited yet ?:) REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17065: Fix mem leak found with asan

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8fb6431784e2: Fix mem leak found with asan (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17065?vs=45928=45935 REVISION DETAIL

D17065: Fix mem leak found with asan

mlaurent added a comment. Indeed a very good training "debugging and profiling" I fixed some potential other mem leak in kinfocenter/ark/libksysguard yesterday. Very useful indeed. REPOSITORY R241 KIO BRANCH fix_mem_leak (branched from master) REVISION DETAIL

D17065: Fix mem leak found with asan

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17065 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17065: Fix mem leak found with asan

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Fix mem when I used dolphin #0 0x7fa8cd24d900 in operator new(unsigned long)

D16966: Fix typo in i18n message (cmdline option description)

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent added a comment. For me seems good +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent added inline comments. INLINE COMMENTS > emateli wrote in batchrenamedialog.h:69 > You mean to initialize them to nullptr on the header file or using a > constructor initialization list? Also see what problem? in header file. REPOSITORY R241 KIO REVISION DETAIL

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenamedialog.cpp:40 > +#include > +#include > +#include remove QtWidget > batchrenamedialog.cpp:41 > +#include > +#include > + remove QtGui

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:65 > + rename/batchrenamedialog.cpp > +rename/batchrenamedialogmodel_p.cpp > +rename/batchrenametypes_p.cpp fix indent >

D16306: [Codecs] Remove unneeded const_cast

mlaurent added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16306 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH mtp_next (branched from master) REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent,

D16001: ktextedit: lazy load the QTextToSpeech object

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH lazy-qtexttospeech (branched from master) REVISION DETAIL https://phabricator.kde.org/D16001 To: pino, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mtpstorage.cpp:176 > +case LIBMTP_FILETYPE_UNDEF_AUDIO: > +return QStringLiteral(""); > +case LIBMTP_FILETYPE_WMV: QString() directly no

D15778: Log wallet open failure errors

mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = > KWallet::Backend::openRCToString(rc); > +

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

This revision was automatically updated to reflect the committed changes. Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags (authored by mlaurent). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent added a comment. Ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

<    1   2   3   4   5   6   7   8   9   >