D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17592. mlaurent added a comment. Remove empty line Move in good place. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7062?vs=17574=17592 REVISION DETAIL https://phabricator.kde.org/D7062 AFFECTED FILES src/kde.widgets To: mlaurent,

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, elvisangelaccio Cc: elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17574. mlaurent added a comment. Fix typo + Group as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7062?vs=17542=17574 REVISION DETAIL https://phabricator.kde.org/D7062 AFFECTED FILES src/kde.widgets To: mlaurent, dfaure,

D7011: Extract KPasswordLineEdit class

2017-08-02 Thread Laurent Montel
mlaurent added a comment. https://phabricator.kde.org/D7062 (designer plugin) REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We need a plugin for showing it in designer TEST PLAN launch designer with knewpasswordwidget from kwidgetaddons REPOSITORY R298

D7011: Extract KPasswordLineEdit class

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17541. mlaurent added a comment. I created a designer plugin for it, I will put url here after create review I add property for echo mode Now we can see lineedit in designer (created from a plugin) CHANGES SINCE LAST UPDATE

D7011: Extract KPasswordLineEdit class

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17535. mlaurent added a comment. Use a correct license (I copied a header from david class so I think it's ok now) as in kwidgetaddons there is lgpl2 lgpl2.1 lgpl3 lgpl... I didn't change ui file a QWidget otherwise we can't see qlineedit in

D7011: Extract KPasswordLineEdit class

2017-08-01 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > kossebau wrote in knewpasswordwidget.ui:88 > rather extends QWidget now? unsure what exactly the consequences are The consequence is that we don't see it in designer :) So why not but it's better to show a lineedit no ? > kossebau wrote in

D7011: Extract KPasswordLineEdit class

2017-08-01 Thread Laurent Montel
mlaurent updated this revision to Diff 17533. mlaurent added a comment. Fix copyright CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7011?vs=17471=17533 REVISION DETAIL https://phabricator.kde.org/D7011 AFFECTED FILES autotests/CMakeLists.txt

D7011: Extract KPasswordLineEdit class

2017-08-01 Thread Laurent Montel
mlaurent retitled this revision from "Extract lineedit password" to "Extract KPasswordLineEdit class". REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks

D7011: Extract lineedit password

2017-08-01 Thread Laurent Montel
mlaurent updated this revision to Diff 17470. mlaurent added a comment. Create a real class for private class as requested + fix signal etc. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7011?vs=17469=17470 REVISION DETAIL https://phabricator.kde.org/D7011 AFFECTED FILES

D7011: Extract lineedit password

2017-07-31 Thread Laurent Montel
mlaurent updated this revision to Diff 17469. mlaurent added a comment. I renamed class/test apps/autotests as requested I fixed autotest with new autotest from master I fixed all comment on this review etc. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7011?vs=17420=17469

D7011: Extract lineedit password

2017-07-31 Thread Laurent Montel
mlaurent marked 7 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks

D7011: Extract lineedit password

2017-07-31 Thread Laurent Montel
mlaurent marked 5 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks

D7011: Extract lineedit password

2017-07-31 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > cfeck wrote in knewpasswordwidgettest.cpp:63 > Does using setPassword() not work for these tests? Nope as setPassword not authorize to see icon (it's a security when we setPassword from apps you don't want to see it) > cfeck wrote in

D7011: Extract lineedit password

2017-07-31 Thread Laurent Montel
mlaurent updated this revision to Diff 17420. mlaurent added a comment. I renamed class name. I ported KNewPasswordWidget . CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7011?vs=17413=17420 REVISION DETAIL https://phabricator.kde.org/D7011 AFFECTED FILES

D7011: Extract lineedit password

2017-07-30 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Now we can use lineedit password outside kpassworddialog. It's useful in kdepim for example. TEST PLAN I added autotest and test apps.

Re: Zanshin is in kdereview

2017-07-03 Thread laurent Montel
n kdepim knew about it. Hi, Kevin and me discussed about it long time ago when zanshin was ported to kf5. So indeed a kdepim guy (me) knows it :) Regards > Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group compan

Re: Jenkins-kde-ci: syntax-highlighting master stable-kf5-qt5 » Linux, gcc - Build # 83 - Unstable!

2017-03-01 Thread laurent Montel
(98%)CONDITIONAL 337/520 (65%)> > > src.indexer > > > > FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 53/71 > > (75%)CONDITIONAL 73/92 (79%) > > > > src.lib > > &g

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

2016-12-29 Thread Laurent Montel
> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > >

Re: Please cleanup your scratch and clone repositories

2016-11-26 Thread laurent Montel
Hi, Done. I cleaned up my reporitories Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software

Re: Please cleanup your scratch and clone repositories

2016-11-26 Thread laurent Montel
Hi, Done. I cleaned up my reporitories Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software

Re: Please cleanup your scratch and clone repositories

2016-11-26 Thread laurent Montel
Hi, Done. I cleaned up my reporitories Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software

Re: Review Request 128992: Drop obsolete version check

2016-11-25 Thread Laurent Montel
- Laurent Montel On Sept. 21, 2016, 5:36 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129495: Add FreeBSD to metainfo.yaml.

2016-11-21 Thread Laurent Montel
- Laurent Montel On Nov. 20, 2016, 4:22 p.m., Tobias Berner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129499: Add FreeBSD to metainfo.yaml.

2016-11-21 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129499/#review101045 --- Ship it! Ok if it works on freebsd:) - Laurent Montel

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-10 Thread laurent Montel
kubrick > lskat > palapeli But nobody merged or finished porting. I made first step but for sure I didn't have time to finish it. +1 remove them in 17.12 if nobody finishs porting. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-10 Thread laurent Montel
kubrick > lskat > palapeli But nobody merged or finished porting. I made first step but for sure I didn't have time to finish it. +1 remove them in 17.12 if nobody finishs porting. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB

Re: Review Request 128993: Drop obsolete version checks

2016-09-21 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128993/#review99405 --- Ship it! Ship It! - Laurent Montel On Sept. 21, 2016

Re: Autocorrection in framework

2016-09-04 Thread laurent Montel
ner --> cc'ing Martin > > Sandsmark. > I'm not opposed to putting it into Sonnet, but I don't have time to do it > myself right now. It's not the problem. I will make it after some review. Good to know that we can put here :) Regards. -- Laurent Montel | laurent.mon...@kdab.c

Re: Autocorrection in framework

2016-09-01 Thread laurent Montel
Le jeudi 1 septembre 2016, 00:58:28 CEST Albert Astals Cd a écrit : > El dimecres, 31 d’agost de 2016, a les 22:33:29 CEST, Burkhard Lück va > > escriure: > > Am Mittwoch, 31. August 2016, 08:48:58 CEST schrieb Kai Uwe Broulik: > > > Hi, > > > > > > Sonnet maybe? > > > > Quoting Albert Astals

Autocorrection in framework

2016-08-31 Thread laurent Montel
Hi, We have caligra and kmail which use autocorrection. I want to add autocorrection in framework to reduce duplicate code. But I don't have idea in which framework to add it. Do you have an idea ? Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB

Re: Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

2016-07-22 Thread Laurent Montel
:) - Laurent Montel On July 12, 2016, 7:57 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

2016-05-15 Thread Laurent Montel
() to qCDebug ? After fixing it ship it :) Regards. - Laurent Montel On May 15, 2016, 4:55 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [Kde-pim] Qt 4 Builds

2016-03-28 Thread laurent Montel
Le lundi 28 mars 2016, 00:50:20 CEST Kevin Kofler a écrit : > laurent Montel wrote: > > Oh?:) > > Fedora continue to support some programs which are not supported from > > several years before kdepim5 ? > > Fedora would not have to do that if you were not removi

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread laurent Montel
Le dimanche 27 mars 2016, 15:31:47 CEST Martin Koller a écrit : > On Sunday 27 March 2016 09:21:01 laurent Montel wrote: > > Le dimanche 27 mars 2016, 10:57:18 CEST Ben Cooksley a écrit : > > > Hi all, > > > > > > As part of the CI overhaul, we've

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread laurent Montel
Le dimanche 27 mars 2016, 16:08:09 CEST Luigi Toscano a écrit : > laurent Montel ha scritto: > > Le dimanche 27 mars 2016, 14:02:26 CEST Luigi Toscano a écrit : > >> laurent Montel ha scritto: > >>> Le dimanche 27 mars 2016, 11:58:07 CEST Kevin Kofler a écrit

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread laurent Montel
Le dimanche 27 mars 2016, 11:58:07 CEST Kevin Kofler a écrit : > laurent Montel wrote: > > We will not create more release from kdepim4, no distro uses it even > > debian :) > > Fedora will ship (it's currently under review) a kdepim4 package containing > KNode

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread laurent Montel
rg > https://mail.kde.org/mailman/listinfo/kde-pim > KDE PIM home page at http://pim.kde.org/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-02 Thread Laurent Montel
iteral(...) src/core/faviconscache.cpp (line 66) <https://git.reviewboard.kde.org/r/126963/#comment62729> QLatin1Char('/') etc. src/gui/faviconrequestjob.h (line 78) <https://git.reviewboard.kde.org/r/126963/#comment62730> Q_NULLPTR - Laurent Montel On fév. 2, 2016,

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread laurent Montel
Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > > In this direc

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-28 Thread laurent Montel
n for the combobox icon, for the history tree (and later > on for adding as bookmark, but by then it's cached, hopefully). > In Akregator I see both BrowserFrame and Feed registering for the favicon. > > Migration strategy: the kded module will stay around until KF6, so we can > ta

Re: KDE PIM Split?

2015-12-01 Thread laurent Montel
Le mardi 1 décembre 2015, 21:10:57 CET Ben Cooksley a écrit : > On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel <mon...@kde.org> wrote: > > Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > >> Hi Pim devels, > > > > Hi, > > So I reorganized

Re: KDE PIM Split?

2015-12-01 Thread laurent Montel
Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > > El 1 dic 2015, a las 05:10, Ben Cooksley <bcooks...@kde.org> escribió: > >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel <mon...@kde.org> wrote: > >> > >> Le lundi 30 novembre 2015,

Re: [Kde-pim] KDE PIM Split?

2015-11-30 Thread laurent Montel
t a pile of tickets in my inbox. > > Thanks, > Ben > ___ > KDE PIM mailing list kde-...@kde.org > https://mail.kde.org/mailman/listinfo/kde-pim > KDE PIM home page at http://pim.kde.org/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Soft

Re: KDE PIM Split?

2015-11-30 Thread laurent Montel
de-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kd

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125833/#review87712 --- Ping ?:) - Laurent Montel On oct. 28, 2015, 7:32 matin

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel
/kconfig_compiler/test_translation_qt.cpp.ref f5ae727 src/kconfig_compiler/kconfig_compiler.cpp 600d67a Diff: https://git.reviewboard.kde.org/r/125833/diff/ Testing --- All tests are ok. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde

Review Request 125834: Generate code with QStringLiteral

2015-10-28 Thread Laurent Montel
. Repository: kdesignerplugin Description --- Use QStringLiteral Diffs - src/kgendesignerplugin.cpp a2c3869 Diff: https://git.reviewboard.kde.org/r/125834/diff/ Testing --- It works fine in kdepim :) Thanks, Laurent Montel ___ Kde

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-28 Thread Laurent Montel
are ok. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125834: Generate code with QStringLiteral

2015-10-28 Thread Laurent Montel
/kgendesignerplugin.cpp a2c3869 Diff: https://git.reviewboard.kde.org/r/125834/diff/ Testing --- It works fine in kdepim :) Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
from long time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
t; knewfilemenutest does). Ok I will try it. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 -------

Re: Review Request 125514: Add a web shortcut manager

2015-10-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86688 --- Ping ?:) - Laurent Montel On oct. 10, 2015, 12:56 après

Re: Review Request 125514: Add a web shortcut manager

2015-10-10 Thread Laurent Montel
> On oct. 7, 2015, 5:27 matin, Laurent Montel wrote: > > What about rename class ? No news so I will rename it to KUriFilterSearchProviderActions - Laurent --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 125514: Add a web shortcut manager

2015-10-10 Thread Laurent Montel
time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-06 Thread Laurent Montel
tps://git.reviewboard.kde.org/r/125532/#comment59557> Initialize to 0 (or Q_NULLPTR) - Laurent Montel On oct. 5, 2015, 3:40 après-midi, Daniel Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-06 Thread Laurent Montel
:) - Laurent Montel On oct. 5, 2015, 3:40 après-midi, Daniel Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125514: Add a web shortcut manager

2015-10-06 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86442 --- What about rename class ? - Laurent Montel On oct. 4, 2015

Re: Review Request 125514: Add a web shortcut manager

2015-10-05 Thread Laurent Montel
?) - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86373 --- On oct. 4, 2015, 2:04 après-midi, Laure

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel
f > > headers, those that end up under KIO/ indeed I will fix it. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86327 -

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel
/widgets/CMakeLists.txt 820cd34 src/widgets/webshortcutsmenumanager.h PRE-CREATION src/widgets/webshortcutsmenumanager.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125514/diff/ Testing --- Tested from long time in kdepim. I added autotests for it. Thanks, Laurent Montel

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
arHistory->setEnabled(false); } } } - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125484/#review86250 ----------

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
from KHistoryComboBox > > then? (compare the slots to be sure it's the same logic). > > Laurent Montel wrote: > it's not totally the same logic > > it will clear the combobox + textline too. > > I will add a test application for khistorycombobox soo

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
from KHistoryComboBox > > then? (compare the slots to be sure it's the same logic). > > Laurent Montel wrote: > it's not totally the same logic > > it will clear the combobox + textline too. > > I will add a test application for khistorycombobox soo

Review Request 125514: Add a web shortcut manager

2015-10-03 Thread Laurent Montel
autotests/CMakeLists.txt 989acd4 autotests/webshortcutmenumanagertest.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125514/diff/ Testing --- Tested from long time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde

Review Request 125484: Allow to clear completion history

2015-10-02 Thread Laurent Montel
/125484/diff/ Testing --- Tested in kdepim from long time ago. Tested in klineedittest apps. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125419: Fix hunspell plugin ID for proper loading

2015-09-27 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125419/#review86007 --- Ship it! Seems logical. Ship it - Laurent Montel On sep

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread laurent Montel
bugs closed after 1 year because it's useful to read all bug and sometime it takes me some months/years to fix bugs. Regards I think this would make a lot of time consuming bug triaging much easier. Cannot agree more :) Cheers, Daniel Greetings Christoph -- Laurent Montel

Re: Qt version requirement in KF 5.13

2015-07-29 Thread laurent Montel
?), and by the fact that Qt 5.3 was released more than a year ago. +1 :) -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-24 Thread laurent Montel
in the afternoon. Please let's get this done and end this painful release asap. I don't know why it did not do it yet. Dan ask it 2 days ago but no news. I don't know why it was not done yet. Regards Albert Thanks, Dan Cheers, Daniel -- Laurent Montel | laurent.mon...@kdab.com | KDE

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-24 Thread laurent Montel
give us more feedback please ? It urges because Albert waits this moving for creating 15.08. For the moment it's postponed. Thanks Regards Thanks, Dan Cheers, Daniel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-20 Thread laurent Montel
2 months without problem. I fixed some bugs etc. It's not just a porting we use it. Regards Dan -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-20 Thread laurent Montel
do you want to move those to modules to kdepim? We don't want to merge it in kdepim We want to move in KDE/ . - do we need all kdepim, kdepim-runtime, kdepimlibs AND kde/pim? For what ? Ciao -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S

Re: Review Request 124226: Delete old highlighter

2015-07-11 Thread Laurent Montel
- Laurent Montel On juil. 11, 2015, 8:18 matin, Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

2015-07-03 Thread Laurent Montel
- Laurent Montel On juil. 3, 2015, 9:13 matin, Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239

Re: Review Request 124071: Load correct translation catalog for kdebugdialog

2015-06-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124071/#review81379 --- Ship it! Seems good for me. Thanks Ship it - Laurent Montel

Re: Review Request 124065: KMimeType mimeTypeForNameAndData() - mimeTypeForFileNameAndData()

2015-06-10 Thread Laurent Montel
forgot to update script. Ship it. Thanks - Laurent Montel On juin 10, 2015, 7:51 après-midi, Jarosław Staniek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065

Re: Review Request 124043: Remove unused dependency.

2015-06-08 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124043/#review81327 --- Ship it! Ship it ! - Laurent Montel On juin 8, 2015, 4:07

Re: Review Request 123930: Reduce temporary allocations.

2015-05-31 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123930/#review80991 --- Ship it! Seems good. Ship it - Laurent Montel On mai 30

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

2015-05-23 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123852/#review80761 --- Ship it! Seems good for me. Ship it - Laurent Montel

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
://git.reviewboard.kde.org/r/123588/#comment54638 You test after copy file ? It's perhaps more logical to test before no ? - Laurent Montel On mai 2, 2015, 8:17 matin, David Faure wrote: --- This is an automatically generated e

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79780 --- Ship it! Ship it - Laurent Montel On mai 2, 2015, 8:17

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
/ --- (Updated mai 2, 2015, 8:17 matin) Review request for KDE Frameworks and Laurent Montel. Repository: kcoreaddons Description --- Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests

Re: Kdebugsettings in kdereview

2015-04-21 Thread laurent Montel
Le Tuesday 14 April 2015 06:46:14 laurent Montel a écrit : Ok It's in kdereview from the 23 march. Is it ok to move it ? Regards No answer from the 14 april. So I will ask to move it from kde-review to kdeutils. Regards

Re: Kdebugsettings in kdereview

2015-04-21 Thread laurent Montel
Le Tuesday 21 April 2015 19:54:39 Albert Astals Cid a écrit : El Dimarts, 21 d'abril de 2015, a les 14:02:26, laurent Montel va escriure: Le Tuesday 14 April 2015 06:46:14 laurent Montel a écrit : Ok It's in kdereview from the 23 march. Is it ok to move it ? Regards No answer

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-17 Thread Laurent Montel
On avr. 16, 2015, 8:43 après-midi, Laurent Montel wrote: Hi volker What did you use as program to detect it ? Thanks for info. Volker Krause wrote: The tool is called elf-packcheck, part of kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as testing

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-16 Thread Laurent Montel
for info. - Laurent Montel On avr. 16, 2015, 7:53 après-midi, Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390

Re: Kdebugsettings in kdereview

2015-04-13 Thread laurent Montel
Ok It's in kdereview from the 23 march. Is it ok to move it ? Regards Le Monday 23 March 2015 08:19:40 laurent Montel a écrit : Le Sunday 22 March 2015 22:27:57 Albert Astals Cid a écrit : El Diumenge, 22 de març de 2015, a les 21:06:15, laurent Montel va escriure: Le Sunday 22 March 2015

Re: [Kde-pim] The Future or KDE PIM Releases

2015-04-13 Thread laurent Montel
by then? Yep after release kf5 version we will stop it indeed. But until it I will continue to fix 4.14.x version. So we will release some 4.14.x version yet. Regards. Cheers, Albert -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group

Re: [Kde-pim] The Future or KDE PIM Releases

2015-04-13 Thread laurent Montel
by then? Yep after release kf5 version we will stop it indeed. But until it I will continue to fix 4.14.x version. So we will release some 4.14.x version yet. Regards. Cheers, Albert -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-12 Thread Laurent Montel
On avr. 12, 2015, 8:03 matin, Laurent Montel wrote: Perhaps it's time to create an unittest :) We need to be sure that it will save when we change settings no ? Kåre Särs wrote: Any hints on how to test that QSettings::setValue() is called properly (or save()) without writing

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-12 Thread Laurent Montel
that it will save when we change settings no ? - Laurent Montel On avr. 12, 2015, 7:52 matin, Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Laurent Montel
On mars 31, 2015, 5:07 matin, Laurent Montel wrote: Yes but your review doesn't fix bug no ? You add more debug but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? Gregor Mi wrote: Hi Laurent

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Laurent Montel
but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? - Laurent Montel On mars 30, 2015, 9:22 après-midi, Gregor Mi wrote: --- This is an automatically

Re: Kdebugsettings in kdereview

2015-03-23 Thread laurent Montel
Le Sunday 22 March 2015 22:27:57 Albert Astals Cid a écrit : El Diumenge, 22 de març de 2015, a les 21:06:15, laurent Montel va escriure: Le Sunday 22 March 2015 13:43:25 Albert Astals Cid a écrit : El Diumenge, 22 de març de 2015, a les 08:40:42, laurent Montel va escriure: Hi

Kdebugsettings in kdereview

2015-03-22 Thread laurent Montel
Hi, Now kdebugsettings is in kdereview. All features are implemented before 1.0. This application allows to configure qloggingcategories. I would like to move it in kdeutils or kdeadmin in the future. Please use it and reports bug about it. Thanks Regards -- Laurent Montel | laurent.mon

Re: Kdebugsettings in kdereview

2015-03-22 Thread laurent Montel
Le Sunday 22 March 2015 13:43:25 Albert Astals Cid a écrit : El Diumenge, 22 de març de 2015, a les 08:40:42, laurent Montel va escriure: Hi, Now kdebugsettings is in kdereview. All features are implemented before 1.0. This application allows to configure qloggingcategories

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread laurent Montel
...@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Laurent Montel
://git.reviewboard.kde.org/r/122987/#comment53304 you add a / at the end and in source code you use MYSPELL_DICTS_PATH/%1.dic = it will create /usr/...//%1.dic = you need to remove a / somewhere. - Laurent Montel On mars 17, 2015, 11:16 matin, Eugene Shalygin wrote

<    3   4   5   6   7   8   9   >