Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- (Updated Feb. 26, 2017, 12:04 a.m.) Status -- This change has been d

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

> On Feb. 4, 2015, 4:26 p.m., Vishesh Handa wrote: > > I seem to have forgotten about this. Sorry. > > > > Do you want me to commit this for you? Didn't get an answer, so i guess the answer is no. Will discard. - Albert --- This is an

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/#review75426 --- Ship it! I seem to have forgotten about this. Sorry. Do you

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- (Updated April 12, 2014, 8:09 a.m.) Review request for Baloo. Changes -

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

> On April 12, 2014, 1:57 a.m., Kevin Krammer wrote: > > src/file/kcm/folderselectionwidget.cpp, line 198 > > > > > > maybe QFileInfo(QDir::homePath()).absolutPath() > > Much neater and less kludgy, thanks. -

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- (Updated April 12, 2014, 7:56 a.m.) Review request for Baloo. Changes -

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

> On April 12, 2014, 1:57 a.m., Kevin Krammer wrote: > > src/file/kcm/folderselectionwidget.cpp, line 210 > > > > > > p is a rather bad variable name :) > > the question is what does this check protect agains

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/#review55461 --- src/file/kcm/folderselectionwidget.cpp

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

Unless I'm having a complete brain fart on the subject, this is a fix for a small but legit problem isn't it? On Tue, 8 Apr 2014 01:00:20 PM Lindsay Mathieson wrote: > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- (Updated April 8, 2014, 11 p.m.) Review request for Baloo. Repository:

Review Request 117436: Doesn't assume that the users home directory is under /home

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- Review request for Baloo. Repository: baloo Description --- Part o