Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-03 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117930/ --- (Updated May 3, 2014, 7:51 a.m.) Status -- This change has been mark

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117930/#review57177 --- This review has been submitted with commit 59519f5b7f69d3c661

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-03 Thread Frank Reininghaus
> On May 1, 2014, 1:23 p.m., Frank Reininghaus wrote: > > Note 1: an even better fix would probably be to repair or delete and > > re-create the broken database if a Xapian::DatabaseOpeningError exception > > is thrown, but my knowledge of the Baloo/Xapian internals is not sufficient > > for t

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117930/#review57099 --- Ship it! Looks good! Thanks for taking care of this. - Vishe

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-02 Thread Vishesh Handa
> On May 1, 2014, 1:23 p.m., Frank Reininghaus wrote: > > Note 1: an even better fix would probably be to repair or delete and > > re-create the broken database if a Xapian::DatabaseOpeningError exception > > is thrown, but my knowledge of the Baloo/Xapian internals is not sufficient > > for t

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-01 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117930/#review57056 --- Note 1: an even better fix would probably be to repair or dele

Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

2014-05-01 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117930/ --- Review request for Baloo. Bugs: 333763 http://bugs.kde.org/show_bug.c