Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/ --- Review request for Baloo and Vishesh Handa. Repository: baloo-widgets D

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/#review63489 --- src/tagwidget.h

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Felix Eisele
> On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 53 > > > > > > Hmm. There is too much space between the new and KBlockLayout. > > > > Also, since we're loosing the spacin

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Thomas Braxton
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/ --- (Updated July 30, 2014, 8:05 p.m.) Review request for Baloo and Vishesh H

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Felix Eisele
> On July 30, 2014, 10:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Frank Reininghaus
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Thomas Braxton
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Frank Reininghaus
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-30 Thread Thomas Braxton
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Thomas Lübking
> On Juli 30, 2014, 8:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Felix Eisele
> On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Thomas Lübking
> On Juli 30, 2014, 8:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Frank Reininghaus
> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Thomas Lübking
> On Juli 30, 2014, 8:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Felix Eisele
> On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. >